From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DCDB2DE70E for ; Wed, 3 Dec 2025 10:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759408; cv=none; b=Q1B8DqgOtZBCTd/WcwtuOcBxo4YRMDr1CRw+uN9pI2W2OdUIcsVmuKiG9WRbku36RJ4gjVgoPV2Y4kAaJiUO9g9hHJUNcU27ogYAPMPz/ZNr0cq9KfQK5DK5kbWS0pVwFsYW4RH44b17+vnU2gQqBhy68nwxhW04A/tAcT9Re98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764759408; c=relaxed/simple; bh=OJtmt4XR/zighIaICaUQxLIlg7+Y3bLOoJXNW7fB8ng=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oC5079NgYI6VHTXH3nWO4gpjxVsoq6mdIevUMADsgeRywWd6Lyj4q92Fr74PsSdEuIgyk6M0vGNN2euyyP7fiVyHMa6Kd5vVwb5m8k4LzwASqmn5FPLP479uNpIFzTW/YMsoR7N041WXQRU8XwYg4j3O3Qg6D6sRRjLtCLX2kOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UnAs7cje; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A/Q2KYGC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UnAs7cje"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A/Q2KYGC" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B39jsRq3714898 for ; Wed, 3 Dec 2025 10:56:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wlkhF5TBHhAagkES0cixd99625eLuneBdUOcOeIUj9w=; b=UnAs7cjef2X6qXjr ydHGG+ErUGiagwyAzj9O0sDFMneZjnudxuhEV2zdSJBAneg2jRRhvQpQNE6D//RK G92qC30LVWEtfCbHZTcLFJRF8sAookVI5vip/mSVAYrhNUevVw3ocDXPvHMmBYYD yzK6RyYnTbqlCsRKwo3R9OmUoXI5fm4iI7CzYFj5+RN1MBTjsNURVzfOz2Vk+3rq xSRcNCTSu2j/OQo8ssy9LGS9SstdixmMUhX/mB8IYwjwTyFu8jln6fD1159OOtYi JVPUej+AOaQ9GNzqo4Xq2x7eZlohYskQPRWylmwSj5drpKt7NLmbsp4gAzQmhx0z E23/Vg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4at3r2328u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 10:56:46 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-882384d1cc2so18898876d6.3 for ; Wed, 03 Dec 2025 02:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764759405; x=1765364205; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wlkhF5TBHhAagkES0cixd99625eLuneBdUOcOeIUj9w=; b=A/Q2KYGColzq/qRb3ByxH5DOQAxHVNulWsaqNqkdKpj5UtipGh90POTAQFt3PcQ3mM EE8zZuAGczwSGgXx/wn9iX1yRO/XvrgJEIErFa+79PohxZLR+iiKXiPxu/lVcJ5Xcgml FwrQM9H9Gh8eknX7FUYM0xnufc7JW7sGT9l3VBrLkYu6mTd5NP7lNG4rO7pKeoPrHB5I oNZsffPAI+310+vZqz2ojs5VDNV5bK6w8kaPna6R9EZAwcMm8Bln+GZ4rCLqUQEvLTT2 gXPYoOyeo8InUP2O6CgTqKCsmgyuBR3tPdcaiBOo9S9bHhauPUvUUc6p9oojSgUupLs+ LeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764759405; x=1765364205; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wlkhF5TBHhAagkES0cixd99625eLuneBdUOcOeIUj9w=; b=I0iFPaaKlQw9LxInajOsdryXoEAm3NscMSB40vThVB7QXQ1SFhab+xBOpoLPyyckCl 2wmgf4TNbkSF4ZF3LS6D5nIwv2kGDBmY14XqnHuHUaVJxp8eXn2egobKc7Lr6YUv+5CW LFHv6kMp0hacFXcjElSOjjDqGB3iUmDZbPz7qWvYgcLZXPmnb3eV9ZIqoIEvvik2P9yK pxaGwo4jW/ywkISHVuali2ruH+ltGBjtC8vxrrszv6fG3FL14kZLwtmpGw3coI3HmUE2 w0BTnduYSyCQWCWAJr49NXnUx3wV+pqzfC6i+YGH7GGYFL4iSJ7472MXC2unALh+QrOF ZfHw== X-Forwarded-Encrypted: i=1; AJvYcCXz+sSZCjr/lMxld36ZQtDIKeih//AFsLJxyiaFz4+M2FKrCgRqXaH5z1XHV/uIw4YfPUMSyADjam/Co6Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yyzzo0UXtYGeYqvtpkdgl4sOKCKpcEDTvN3YULEMyU35jPVb2gT glsQOD8EFwkI3YgFi9ZKBbEyxzaivnJxNzRl4kaXJzJ9nQTBswL/6HOo27BYY6tdCQEibdeOG2G InfznoqUvmTKuZ+DgQ0TvmhrW0P6pi6EAmDOr4Tf7BPSg7ESlJqdnSh1JylaUraWFyZqaDpP1qt E= X-Gm-Gg: ASbGncuKNsMYlTECI9eyDdmzOyhN/SJMPn6bdJcq83/QFhpnEF4Ii0vHXlTvVl0/ASP 9P+4stlZ8D/faJsWtx6zCb8LmArQ5kzUBQ/ahxVB/IlT6fDK7BvuHTls3eR7T7cTTmt6O9xYHOj v7DmOJy5Q2yQVSQHoZ7LmwlM6m0JxBMWUHIg7WVKA8dWDk73otTAnnPFzpxMgQF43ERMlEu5Kal owyK7Tu7ygHdlsbPSjn942Rpsxd6CqCCA2/zPfaLBNLnZBKS6N7ScrCm1OmOZpARCVfVt/RT/1f D6jJAnhLmN7dE3HfFDXPTknS61lrF1+hxv6PVU3LNqguMDAP0clRth8naIY2Lks4hJQkPBAZOOz OwGul5x93koLwusZHyjgzdeg9688eaeXrqXX6kEI44j8Zn3jKkeggAsoNkhLtR1Wbrw== X-Received: by 2002:a05:620a:269b:b0:89d:4a69:1502 with SMTP id af79cd13be357-8b5f8c0c5d9mr69206085a.3.1764759405460; Wed, 03 Dec 2025 02:56:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFkj/PxGQiGLKLkut0E54g3hSB4S41eikEm1v5XWLARNObPBjqCpzJTcKDAApf3uqrKquQfRg== X-Received: by 2002:a05:620a:269b:b0:89d:4a69:1502 with SMTP id af79cd13be357-8b5f8c0c5d9mr69203885a.3.1764759405029; Wed, 03 Dec 2025 02:56:45 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79cbc1f1d5sm285405866b.63.2025.12.03.02.56.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 02:56:44 -0800 (PST) Message-ID: Date: Wed, 3 Dec 2025 11:56:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] arm64: dts: qcom: Add support for Surface Pro 11 To: =?UTF-8?Q?J=C3=A9r=C3=B4me_de_Bretagne?= Cc: Dale Whinham , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251201011457.17422-1-daleyo@gmail.com> <20251201011457.17422-5-daleyo@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: EqeAHKp8XIC16Z1QllckkcHFIw9uYcAJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA4NyBTYWx0ZWRfX1jZB24f4MySl 89E7b3cTCLATN3m4EPkF6ivjPkQNQpsOGayW6aZpxRscAPGpJMO150ndDhv5AZ/xJx7GjloO0aS 8GYK44kSemhroIIZac/AHu+Zf4r4F5n2aRNpdEBUFNib7e6914Xz65WFSPbXwYmzBvzWaM/+M98 5ng4JuqpnRsZ+eqwpA/aXxsPUkl9X3wkW5YiS5r8KxUCcsNu/NV9wZtMsap39wSEs50LAXmGqAa /M3TzXykOITXPOkQyDkhuAF0JKqGSER6WXLcONnYD+CFdwe/DPQwS3ynKciQ10+a+UMRZBcr/Id GLdQjz13b5YwxqZB/2B+fYNC7hV1ZvHIFrvNI0oZkZxMSkPEvEFmbfPjU1X755k6RrgNnn+UZXb IqnmGqKHApAgSORvHG+i6P6WGryObg== X-Proofpoint-GUID: EqeAHKp8XIC16Z1QllckkcHFIw9uYcAJ X-Authority-Analysis: v=2.4 cv=c+WmgB9l c=1 sm=1 tr=0 ts=6930176e cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=07xxzirJNneZIAj5VHsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030087 On 12/2/25 7:50 PM, Jérôme de Bretagne wrote: > Hello, > > As discussed with Dale, I will take over the v3 submission since we've > worked on this patchset together until now. Here is my feedback below. > > Le lun. 1 déc. 2025 à 16:35, Konrad Dybcio > a écrit : >> >> On 12/1/25 2:14 AM, Dale Whinham wrote: >>> Add device trees for the Qualcomm X1E and X1P-based Microsoft Surface >>> Pro 11 machines (codenamed 'Denali'). >>> >>> This device is very similar to the Surface Laptop 7 ('Romulus'). >>> >>> Use a similar strategy to x1-asus-zenbook-a14.dtsi so that we can create >>> x1e and x1p-specific flavors of the device tree without too much code >>> duplication. >> >> [...] >> >>> + pinctrl-0 = <&hall_int_n_default>; >>> + pinctrl-names = "default";in v3 >>> + >>> + switch-lid { >>> + gpios = <&tlmm 2 GPIO_ACTIVE_LOW>; >>> + linux,input-type = ; >>> + linux,code = ; >> >> I.. don't think this device has a lid - what triggers this GPIO? > > When a Surface tablet is connected to a Surface keyboard, opening/closing > the keyboard triggers a wakeup/suspend event. I will double-check if this > entry is involved and will remove/keep it in v3 based on this check. If you have a magnet handy, you can run `evtest` as root and try waving it around the screen frame - it's presumably just a hall sensor Konrad