From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
alsa-devel@alsa-project.org, fabio.estevam@nxp.com,
mail@maciej.szmigiero.name, caleb@crome.org, lgirdwood@gmail.com,
arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de
Subject: Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments
Date: Fri, 15 Dec 2017 22:43:14 -0600 [thread overview]
Message-ID: <aad404d3-fa61-3c49-6265-04fc3b256bc6@tabi.org> (raw)
In-Reply-To: <1513207108-30430-4-git-send-email-nicoleotsuka@gmail.com>
On 12/13/17 5:18 PM, Nicolin Chen wrote:
> - * We are running on a SoC which does not support online SSI
> - * reconfiguration, so we have to enable all necessary flags at once
> - * even if we do not use them later (capture and playback configuration)
> + * Online configuration is not supported
> + * Enable or Disable all necessary bits at once
This is an example of a bad change, IMHO. The original was written in
elegant prose. The new version is just two short sentences.
next prev parent reply other threads:[~2017-12-16 4:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 23:18 [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-16 4:43 ` Timur Tabi [this message]
[not found] ` <CAGoOwPSqf4oKB=gZdD8=W=q9y=CcpjYyUuWkmfm7dQc+P6QDmw@mail.gmail.com>
[not found] ` <CAGoOwPR3BQY9VNyi5qgQH-tdY3WPNyRhfiC26hLQabQQejGBRw@mail.gmail.com>
2017-12-16 16:27 ` Timur Tabi
2017-12-16 17:34 ` Nicolin Chen
2017-12-16 17:15 ` Timur Tabi
2017-12-16 17:30 ` Caleb Crome
2017-12-16 17:47 ` Timur Tabi
2017-12-16 17:49 ` Nicolin Chen
2017-12-16 18:31 ` Timur Tabi
2017-12-16 19:19 ` Nicolin Chen
2017-12-16 19:17 ` Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 04/11] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 05/11] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 06/11] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 08/11] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net Nicolin Chen
2017-12-13 23:18 ` [PATCH v3 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code Nicolin Chen
2017-12-16 4:53 ` [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aad404d3-fa61-3c49-6265-04fc3b256bc6@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.mouiche@invoxia.com \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukma@denx.de \
--cc=mail@maciej.szmigiero.name \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®