From: Yu Kuai <yukuai1@huaweicloud.com>
To: Song Liu <song@kernel.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: logang@deltatee.com, reddunur@online.de, jovetoo@gmail.com,
dgilmour76@gmail.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH -next 1/5] md/raid5: don't allow replacement while reshape is not done
Date: Mon, 22 May 2023 11:46:08 +0800 [thread overview]
Message-ID: <aad4acb6-ccc7-560e-e251-3b4b28a862ef@huaweicloud.com> (raw)
In-Reply-To: <CAPhsuW5YFnqkOFz2tU+GQT=TnVXc-RySECaj=FOHw2rEh5tz0g@mail.gmail.com>
Hi,
在 2023/05/20 7:33, Song Liu 写道:
> On Thu, May 11, 2023 at 6:59 PM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>>
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Set rdev replacement has but not only two conditions:
>>
>> 1) MD_RECOVERY_RUNNING is not set;
>> 2) rdev nr_pending is 0;
>
> The above is confusing. I updated it and applied the set to md-next.
By the way, I'm willing to add regression test for these problems, and I
already send two other tests and there are no response yet. Should the
test wait for fixed patch to be applied to make progress?
Thanks,
Kuai
> Please let me know if it looks good.
>
> Thanks,
> Song
>
>>
>> If reshape is interrupted(for example, echo frozen to sync_action), then
>> rdev replacement can be set. It's safe because reshape is always prior to
>> resync in md_check_recovery(). However, if system reboots, then kernel will
>> complain cannot handle concurrent replacement and reshape and this array
>> is not able to assemble anymore.
>>
>> Fix this problem by don't allow replacement until reshape is done.
>>
>> Reported-by: Peter Neuwirth <reddunur@online.de>
>> Link: https://lore.kernel.org/linux-raid/e2f96772-bfbc-f43b-6da1-f520e5164536@online.de/
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>> drivers/md/raid5.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> index a58507a4345d..bd3b535c0739 100644
>> --- a/drivers/md/raid5.c
>> +++ b/drivers/md/raid5.c
>> @@ -8378,6 +8378,7 @@ static int raid5_add_disk(struct mddev *mddev, struct md_rdev *rdev)
>> p = conf->disks + disk;
>> tmp = rdev_mdlock_deref(mddev, p->rdev);
>> if (test_bit(WantReplacement, &tmp->flags) &&
>> + mddev->reshape_position == MaxSector &&
>> p->replacement == NULL) {
>> clear_bit(In_sync, &rdev->flags);
>> set_bit(Replacement, &rdev->flags);
>> --
>> 2.39.2
>>
> .
>
next prev parent reply other threads:[~2023-05-22 3:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 1:56 [PATCH -next 0/5] md/raid5: fix several reported bugs Yu Kuai
2023-05-12 1:56 ` [PATCH -next 1/5] md/raid5: don't allow replacement while reshape is not done Yu Kuai
2023-05-19 23:33 ` Song Liu
2023-05-22 3:46 ` Yu Kuai [this message]
2023-05-22 6:25 ` Song Liu
2023-05-12 1:56 ` [PATCH -next 2/5] md: fix data corruption for raid456 when reshape restart while grow up Yu Kuai
2023-05-12 1:56 ` [PATCH -next 3/5] md: export md_is_rdwr() and is_md_suspended() Yu Kuai
2023-05-12 1:56 ` [PATCH -next 4/5] md: add a new api prepare_suspend() in md_personality Yu Kuai
2023-05-12 1:56 ` [PATCH -next 5/5] md/raid5: fix a deadlock in the case that reshape is interrupted Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aad4acb6-ccc7-560e-e251-3b4b28a862ef@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=dgilmour76@gmail.com \
--cc=jovetoo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=reddunur@online.de \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®