From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC921ABED9 for ; Tue, 21 Apr 2026 03:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776743650; cv=none; b=Z/5X4lgE9DCwrLhnFKB9tUTN4N1WgfHYCPoJyupHxHt8UbeVpCpKhNZhdaCMNnGmCoQX/Y9W56HyboKbG5ubDD/Z841y1RkwdX+gXKeUsyHjqCXY0fX5EZSBWhH2Y0dD5fWWGyKWahU74NtD9PeSFdAad8o4JbaFwNQ0pVjI6zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776743650; c=relaxed/simple; bh=1xHdqfLyvr7XpT1wmvpgqlQ789usxvTM24fjsGmXqZg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZFtyx6fzlgSS8s1mefPivWL47peewAqEHObx2tYZQ/suZpoTCosuLujmckzLY+KUEt6B42+hjL7fVKGuHbt7862gcJqyqAo4ybbR+zutziVdc3/nsBkZPTiupcqRobyUnCxYW8WYC9iu45SR4WVv60FOUv9URayceOkBS/qsFMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MTtxBLHc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=O0v9a24M; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MTtxBLHc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="O0v9a24M" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63L3Pfmp4168293 for ; Tue, 21 Apr 2026 03:54:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= reNIUZ1BQJrOjK881QqCqiO8dR1s9yebM1FUayY4Tz8=; b=MTtxBLHcFM6nTSOi vaV7YFFJDKXwkEgunTZYpZdlm8AaWAtEKg+BzfMN6lmOqaVYaaap/QoFA/l9Obsc nTPaiC7JeFYhhLdvXgo1H0tuv6v8GuzKyFfDBtTZ433/Z04iAx3AAEeCtBPPmWpm ERCQ104+4i6bHilokPjVte1JNQriJWN7z7h/XtiN5mtCaPKLMg6f4cbCaBoI3H0Z cAcu1LyROEF0rbVT5xg+x64e5tzZv8jtqtjxqRM+i2ja3xxo4RtX1k7LeMISQl28 57HLjPd19zyTNvW1AGn71aD+gXpZ47doYGJr9nn3vsJxRT7ahRW8HLiaCvaACpNH /Kacbg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dp1au02q9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Apr 2026 03:54:08 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82f74bcfb86so4505704b3a.0 for ; Mon, 20 Apr 2026 20:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776743647; x=1777348447; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=reNIUZ1BQJrOjK881QqCqiO8dR1s9yebM1FUayY4Tz8=; b=O0v9a24MiD6ZWlIxNHtGbV//r1cMn/crFOubkyka+szS3chC4psREGP2gkP8u8BUrH b424KFV2AqHphD5xZP/80MnOOhdcZ+8OXiV3dMcusVWsnTcyJu9Ns60AI5DI8gfq+z8u FfBKMGsF+1C+hd9YcQTNSqSW+TmwiyM+irQlBuzeWHv1+X0AqpQDlBkWc6e4RUoBukKx L+ueJMv31dX1qTHgnZCqt9l4VcMgagVEk51382noohL1B9a/evrWnkmeBQLiai/+jdS6 z4ydny93cjPAMb77k1iUaSZVLr7QzTzXgzXq5KZXw1GtzGtUCuqMnRODiofANUMcMpJP VvIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776743647; x=1777348447; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=reNIUZ1BQJrOjK881QqCqiO8dR1s9yebM1FUayY4Tz8=; b=Xggz69CXEQB53b2faPxGPfpvBj34rRVRA8R+o4kDDDsYrqo1ka0yxIQ9c5QPeiDHsD ir24ePY7oZrbjYQtO6Ot6SQORVr+wVQKN3BgV6uANswgYH+vG1Ok7WrtcrFix6M/BAlF a9YKxWWwIbnJoQ7r/2LwYuuuDHPvOyW7xPC5fxdTDETtPDehWwU1yQWBHL1+YNX4a4Gj xqRjreNC0rUBI2g6lLuEsXIkyfMMpBTn6JRza8mSB6KNQc5f23AxIKum2CFYAOezPbAm Y9yg1V5n5tlF5YMPZb+Z4SIK7qGutWTeo9cJRkKMdCFsT+B5FuJXXvU2RVZLaFnh3glX 2/mw== X-Forwarded-Encrypted: i=1; AFNElJ8x36hltp8KXieoshKWmawfjNXZrUy6MXHdFlBcDvZ/thOBbK+8ARuSfgCQI6cu7lAtbWDQ2GIli/xGt6M=@vger.kernel.org X-Gm-Message-State: AOJu0YyteiO9rLf87UXfci5uJI3hKUnfopaVN7c+YcHlYs4bn4pn/3vi gpM83OMJXCIV2CNwZj6Nrsqpc6KJvU8WrNnC0LFmeVNcrFQhv4sP2xr4knyyMFc89Jwhess80zG eHqIo/XQFsvd7vNN88exG0moQBdhxBhJHWqfqBCw0DPBg0MkPKCQ5zllSWKEBjeZ/10A= X-Gm-Gg: AeBDieuGWmzecgHoLB31kbcCkgT9JMoWPtPymJgfggK9GJYjQpZ4PwLlbpfDNuIG8hq EtW0pTCr6taTREeK6ozhdfegCcKVHkP2SSY0aR4hJqCh6/mLqPWnZRVLLCpqTMHeoyYZqUQVUjC JEynOiqyBakHFEyLTHYiVeKZVy8vL0N0EVOgNGnbmcZfdKkTYsW3Ir1NAoTK4lirRU/Rs+lnQn4 iQXyZKtNjcSu1xrGaFcobDzCll+v4Dtw7CMDkOzKYPyOvVA1DDZy7eDfpCKsW39cmvrNyAGUjQs 0aFh5NL+O0bKagvjhldH4rwxnhNqwtAovI9K4uYOofIt7TgiMbgiGzDKf2U2HLC+yoQF1ftGMum sF9EY4XVmOwdrFgbfYziBouSmKQcKXwpwQm7tTUh9KHFePHfnI3NGwg+8X2FB7JEhSx51s2hD0a IiQOMUwRw1YFQaD+pgV8UX+b5MhNAE X-Received: by 2002:a05:6a00:bb91:b0:81f:31c3:2e34 with SMTP id d2e1a72fcca58-82f8c902072mr16719739b3a.25.1776743647438; Mon, 20 Apr 2026 20:54:07 -0700 (PDT) X-Received: by 2002:a05:6a00:bb91:b0:81f:31c3:2e34 with SMTP id d2e1a72fcca58-82f8c902072mr16719704b3a.25.1776743646903; Mon, 20 Apr 2026 20:54:06 -0700 (PDT) Received: from [10.133.33.141] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f97eb5ce8sm10205408b3a.61.2026.04.20.20.54.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 20:54:06 -0700 (PDT) Message-ID: Date: Tue, 21 Apr 2026 11:54:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] phy: qcom: edp: Add eDP/DP mode switch support To: Konrad Dybcio , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260302-edp_phy-v3-0-ca8888d793b0@oss.qualcomm.com> <20260302-edp_phy-v3-1-ca8888d793b0@oss.qualcomm.com> <245f4589-d7ca-4d6b-8162-a86972752bd8@oss.qualcomm.com> <12e8a8de-49b8-463a-8b88-2cbbf1ab901c@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIxMDAzNSBTYWx0ZWRfX/ygRpeNPtOZb ASkkXngKGAOqHIT49afcCLGGTaixZwq7J/1lgR3wSyAxuwOSgWks4IQh8mq21t50FkJezBXYJKW Yi2z6ADXq4gcMayTdwMuBRONC2jyXrK2RPX3B+kPGm6ZfFDiapvlcU4o6/rskgo3owWtPi11hXv 5Af6rPIpqgg5DdXSptTCwBPM5XZxn0gf8ypFY/7ZlXzZNW63TTZiDB+MvZel5nYQmWu/UgHvbzH yEqh0IfH8xrez5kVxW/hkOdrwsCcj1iXPQzGUtiN1r2ZKz/+47h8Jxjfe7R9NvPZM6RJ++RJViD 83XNKri3V4KFqM6tDKhLFQo4fE8JAvORJ1rxjb91Ms/w21IcswqapRr3cIB7C8TBeiR3xwheI2h kHNAXtuOynLwKhszfdvRsutCzFjAwfQ+dfG01ZIN1LY8IQh33w0sL4GWkRwMTUinon6NA/lae3r 4mrNYQgBBW8FE/JtcWA== X-Authority-Analysis: v=2.4 cv=F9JnsKhN c=1 sm=1 tr=0 ts=69e6f4e0 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=i7yIW9Iy5qQLytvIRn0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: rPFvnZ8ZXnI5dEi-YOVCSIHhCMtKCizZ X-Proofpoint-ORIG-GUID: rPFvnZ8ZXnI5dEi-YOVCSIHhCMtKCizZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_01,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604210035 On 4/20/2026 8:49 PM, Konrad Dybcio wrote: > On 4/20/26 2:48 PM, Yongxing Mou wrote: >> >> >> On 4/16/2026 5:34 PM, Konrad Dybcio wrote: >>> On 3/2/26 9:28 AM, Yongxing Mou wrote: >>>> The eDP PHY supports both eDP&DP modes, each requires a different table. >>>> The current driver doesn't fully support every combo PHY mode and use >>>> either the eDP or DP table when enable the platform. In addition, some >>>> platforms mismatch between the mode and the table where DP mode uses >>>> the eDP table or eDP mode use the DP table. >>>> >>>> Clean up and correct the tables for currently supported platforms based on >>>> the HPG specification. >>>> >>>> Here lists the tables can be reused across current platforms. >>>> DP mode： >>>>     -sa8775p/sc7280/sc8280xp/x1e80100 >>>>     -glymur >>>> eDP mode(low vdiff): >>>>     -glymur/sa8775p/sc8280xp/x1e80100 >>>>     -sc7280 >>>> >>>> Cc: stable@vger.kernel.org >>>> Fixes: f199223cb490 ("phy: qcom: Introduce new eDP PHY driver") >>>> Signed-off-by: Yongxing Mou >>>> --- >>> >>> I went through everything and all the sequences are OK. >>> >>> SC8180X will need changes, but it's already incorrect so this >>> doesn't necessarily affect it >>> >>> Thanks! >>> >>> Reviewed-by: Konrad Dybcio >>> >>> Konrad >> Thanks here.. I didn’t notice before that SC8180X is different from SC7280, and will correct it in the next version. > > Please make it another patch on top of these two, so that we don't have > to re-validate the existing diff > > Konrad Thanks very much for the validating this patch. Could you sync with Dmitry how i post next patch?... He suggest me to splite this patch...