From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 236C4317143 for ; Sun, 26 Apr 2026 12:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777207277; cv=none; b=Qmq/yxmaYGQgIkGfcSfzW/au2tNEcQEFLIVGz0ElxXvkw0MnbiWhRjXeGhIM7756WbXn3X97+S/UpYTFa3uz69y4uP+8cxgKFwYJWflF4V/pODzXPOwjzIdfJL5vqfdtEBO0QYZxPJYohq5/Y1TNM8/+A5rd4HZIggc3RJwU59s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777207277; c=relaxed/simple; bh=8uZqWib87JQKwK1IbPwHjUWI4NthwEGaeUn5EZlIdWM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EPCMoKmQiovw39lV+ZXyjSeGvdv9thqoW+k5EdokuD7czMWRhRCl5DPel11iL/QKNOzs8aRRX2n7sroXk0ql+C40MSEtAGhOz4hkdJug5te2L8UzfWsig/e0TENBTkBh6XmBrI9HOkCP7f6M11WOVQ/z3osxJE3TYoKWQVr65TE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eex8Y6UG; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eex8Y6UG" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-38df1889fb9so89609121fa.1 for ; Sun, 26 Apr 2026 05:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777207274; x=1777812074; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PSMTNREp3Te6IScbhyBWeT+VZwwFBx8bmgCfL3Le1MM=; b=eex8Y6UGmzz9hHsowEjju77Dpf2D4Wv0qn54Lif1ceCJzqLR3B6+0EhiiqNmfgVyMO MGBH5ZGV+sRygNakktqK5pwqmPwtRh/TwvGhZqxpqy162fGCYkKPJcGKDOaqg0Av9tQd UDhC1AaLltPR+Q8WM689uwCCLeqfRJyP87gzpDa0CIAZmZ8bMn+7adCdLPEdr/G2TWeL LbYoeDOFxgBFRs3Yttg7XEhlKTYvqmWxQt00h6rr/BfZNHI6ufcY5h9t+TtjokkrHs9R 1w6kAF/+8lw6UjTqM0Mu8IQ1lqxmP9r37aaeYwgBIMdS4dvFsBw9Eq2fSvLsho876nYT zKoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777207274; x=1777812074; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PSMTNREp3Te6IScbhyBWeT+VZwwFBx8bmgCfL3Le1MM=; b=N7YWaatrRKREEfDdays0QUQzvi0WYP39KW39YIoqqXxCfHzA190bhZ7Jy+FvCnHsCQ NiJkZE6ddyt7AlXXa5eSCtfteTzt4/woCMM1LidvpzOqqnuPxxSkx6H+K7Qk6UpNZKrz 8viy5w7rQ7zJ2A9+Sl3XDPaWDQTvEVad0qZscU1uDwUkhb16WfHDXBVbGtBYF2R4BBRv RE8veHBHpGP6SoPcSL9N+l7HQv0mHaEqh4LXTJvYK6kr7EGTwkHrQeeNo6ytLWEiyzUY h2X90weTkxMaGUnA029TWv+wKTMxdINwIhaDvwygpVz90wcjUvg92rPKbMy3d4WkZnVU 46aw== X-Gm-Message-State: AOJu0YxzX6oh3i6wyqG1xHYEIl+56BOBAKEBhyhtfOrl5xVvGzN+ehHi Y38I1VzcVtVliyXvWah9l84/2YoNBn8/8IpTgob09GTKC66niOqlSP23k+sEpQ== X-Gm-Gg: AeBDievb2MB3qAF8+XHeEo6srZ2jJezYHLeh/E1JAzPT69U+m1+vorhvhWuqEaHB/U3 1pKgRZ1rJqoyqIupchql9fDwFcs+jVVW/RzcHYSjOSe6jgvcG+HxKn1LxQSShxQK4YGfpilhp7j uZTcmd54KHRprxyiG/eM53yeLRwPLciScB9bjvlSw7GaBnuoaCtlMWB7CD335CAPredDXUxEkDv 1kd9SLjhgsTNSCeDhOU6bZj5lIYl3JKHKSZhWuSr4TXHlcKpXJegRSPME6/WsCjI+0iedV6jdZR myblUyBTilTW/w5CMVyeg13oZtcfvkbLgCIr97sjCXL5WRJYnTb7Plxlmo0KR9DnAiSpVfxo4kw Gk0krmrDJquyT2iCTHlAUbgQJFnrcO3Ht9pLAh4lfQdMJKUbYvEJYld4b6XiKjtqdUex0MFz9+r /+k6Ueqptm32+rH1Fyz/kKyGcL6FyNWQmyf0ZLXZ/RMXY6Fw== X-Received: by 2002:a05:6512:3196:b0:5a2:843f:5800 with SMTP id 2adb3069b0e04-5a4172e7c8fmr14687683e87.23.1777207273986; Sun, 26 Apr 2026 05:41:13 -0700 (PDT) Received: from [192.168.0.193] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a4187e7a57sm7319133e87.57.2026.04.26.05.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Apr 2026 05:41:12 -0700 (PDT) Message-ID: Date: Sun, 26 Apr 2026 14:41:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9] leds: add support for TI LP5860 LED driver chip To: Steffen Trumtrar , Nam Tran , Lee Jones , Pavel Machek Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org References: <20260424-v6-14-topic-ti-lp5860-v9-1-b44d7025d741@pengutronix.de> Content-Language: en-US From: Jacek Anaszewski In-Reply-To: <20260424-v6-14-topic-ti-lp5860-v9-1-b44d7025d741@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Steffen, On 4/24/26 3:28 PM, Steffen Trumtrar wrote: > Add support for the Texas Instruments LP5860 LED driver chip > via SPI interfaces. > > The LP5860 is an LED matrix driver for up to 196 LEDs, which supports > short and open detection of the individual channel select lines. > > It can be connected to SPI or I2C bus. For now add support for SPI only. > > Signed-off-by: Steffen Trumtrar > --- [...] > diff --git a/drivers/leds/rgb/leds-lp5860-core.c b/drivers/leds/rgb/leds-lp5860-core.c > new file mode 100644 > index 0000000000000..648bf168f94bf > --- /dev/null > +++ b/drivers/leds/rgb/leds-lp5860-core.c > @@ -0,0 +1,231 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2025 Pengutronix > + * > + * Author: Steffen Trumtrar > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include "leds-lp5860.h" > + > +static struct lp5860_led *mcled_cdev_to_led(struct led_classdev_mc *mc_cdev) > +{ > + return container_of(mc_cdev, struct lp5860_led, mc_cdev); > +} > + > +static int lp5860_set_dot_onoff(struct lp5860_led *led, unsigned int dot, bool enable) > +{ > + unsigned int offset = dot / LP5860_MAX_DOT_ONOFF_GROUP_NUM; > + unsigned int mask = BIT(dot % LP5860_MAX_DOT_ONOFF_GROUP_NUM); > + > + if (dot > LP5860_MAX_LED) > + return -EINVAL; > + > + return regmap_update_bits(led->chip->regmap, > + LP5860_REG_DOT_ONOFF_START + offset, mask, > + enable ? LP5860_DOT_ALL_ON : LP5860_DOT_ALL_OFF); > +} > + > +static int lp5860_set_mc_brightness(struct led_classdev *cdev, > + enum led_brightness brightness) > +{ > + struct led_classdev_mc *mc_cdev = lcdev_to_mccdev(cdev); > + struct lp5860_led *led = mcled_cdev_to_led(mc_cdev); You need mutex locking while accessing hw to avoid leaving the device in an inconsistent state in case of two parallel requests from different processes. > + led_mc_calc_color_components(mc_cdev, brightness); > + > + for (int i = 0; i < led->mc_cdev.num_colors; i++) { > + unsigned int channel = mc_cdev->subled_info[i].channel; > + unsigned int led_brightness = mc_cdev->subled_info[i].brightness; > + int ret; > + > + ret = lp5860_set_dot_onoff(led, channel, !!led_brightness); > + if (ret) > + return ret; > + > + ret = regmap_write(led->chip->regmap, > + LP5860_REG_PWM_BRI_START + channel, led_brightness); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > +static int lp5860_chip_enable(struct lp5860 *lp, bool enable) > +{ > + return regmap_write(lp->regmap, LP5860_REG_CHIP_EN, enable); -- Best regards, Jacek Anaszewski