From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7FB36402D for ; Wed, 1 Apr 2026 15:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775057571; cv=none; b=TDo28LSqmwNAr6bRobjN4Vlhdqj/bYcGqIA/cSPgSWg2l11dNAifoh8r8AA5aQpS+XDnzKhdFcL+Ymak/31CovRrIUGa/AL8qjtxoe+H9cM7YFSyZlw2b9P7q127TgErhthZ3k+ZlZKePSG+AlohB3UYrZDH8MAwSAxqs4fWbjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775057571; c=relaxed/simple; bh=Ai2/x1kqo80rkpEaKRRyykEK4jbPrETJQvivg8Hd8Oc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S8gklb9l4le+hcegIHNtSdCFh7kFKu/5JiUQhC7xeLF9pSqZSuNCDu7lW+4Mhdy3xE/Pr9P0A5HSm3uKOaIzrTEvyrx9LnU25nLMcwYyeZJRXLoDuewCUsEzTey6/HDFGeEe4St7QWM+A2wUSeRAb3LVIjCiF3eF6m9Qk+7sqek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jtXA1g8P; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jtXA1g8P" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12a74039dc6so5756763c88.0 for ; Wed, 01 Apr 2026 08:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775057570; x=1775662370; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=21I3m8LqYZE/Hogk17E7dwBI5zTNe6gNNbn7uLVQjko=; b=jtXA1g8PoZrrOpDYaeJfsEf5yaA4/fX5+gX9LMPMddB8xYiVKy/T4gkrMrSwSTL1A0 8M/08Vcjj/8P0TES6zm/rvrngzfmH5XBA2eOUvWSihKryOXnBmhmiIsgO+ycUkiMtkhi 4UbWtCJg/Jw71DcY5lyZqXrfa68ARG0T5fU0kEg8x4SmUrlFIJJWZ8k3vAJdkfiXaUOO NQfyA/n5nCO7PwOGMIpy7X0FgcGWFO2nQwRA/xlMR3fXgNknyDLFp9PRSd4ojrrm7IcC 0aDJlJ6KOqke3nsre35iMeqZQnExGw3yf69wsGdgdX4oyFa8AgMSQpIgqlMRumvdapzW eehQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775057570; x=1775662370; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=21I3m8LqYZE/Hogk17E7dwBI5zTNe6gNNbn7uLVQjko=; b=J0tGExA24FTqs8n7ef63rB45PiEDDf0VRPiY7J53dOkhQrQ61b2D5suzqJPzof2VAp tVnf1Rv9SfHfPL7l+s3dwI1fZCIRQrtpVzMgzsE7Xw+LxgH4TOqCWH4msOU2aV4OA+m2 HPpGMt8hcgI6LqfLkkEGIvRVVtR+UC2Kn46fCBjIXLKcimWgUvYeocBriokFg3+30k10 dPusTHOJpr11ZFqTedJfeoC9eoqga0Oo0gsBg68hdiLiOm8+0Yz8fla5haAptzTXG44v p7JcaQur3ZHiyqJJp3rTGMmtjTEMhvVZ6O0FS36zSbhsObIWJD9FxF+jrDajnw9I9V4S 7dvw== X-Forwarded-Encrypted: i=1; AJvYcCX28uEMw8f7hEwYapC4JY+pmBcBMIyEEyO6u7nao9N6UfC54Pp/Lk8Lj/asjx3A8XBMtUJuSu5B80nCY3E=@vger.kernel.org X-Gm-Message-State: AOJu0YyYdZYcitYBK0AF6o7ygptMeai4ZOzQDY3nZpeJ77AwgFmNpeyc et6uI4ddmiWmniEdyAnTnJbT8Pc2oJ21zItxV/am6qjuRUba36oHn3LQ3U5f6w== X-Gm-Gg: ATEYQzwBIZeF6eOUxy/3lBQ5/6MyNjho1lBgAUGXDBUC/qTHWIHZInpn5DdIJ9d0e6/ dgFRaYOY2s3ZoALZuiwg9tPRVRVyPn7JITjeAmS9n4nF0uLlksV8juuGWnoRdnRT7twYEPYM96z EXJPYhgxSmgMkhpuHxl8ZbRwY46ZsxyQRPruk3IYog1SzM5qc4ud8Q6yz/aDQBUqjNzWL7L0/ym KjglHgC7JB1rqsd+O7bAZmtiuyme7LIEoHvxyCt4BD6YvaFoIL6GOV8/5wX5LnQjT00cievTHUT fsMrlb6B+dqeBN5Bf4OyzdTUqVw3sQr6vuusXXmFOJ9X54iX5Y+Kn6gRueZhvSyvC/Qn16DuAi6 EtH/hhva0KaNzIaVNFqdOpJkDye9wyMHmZW0+yTnnqV89hGfeHip2bilKyX/xY3MjLjm3+gNQJM 9sabaFnMiXR2kxdVxXDIgxkSnJtBDPISeNTWM1 X-Received: by 2002:a05:7022:6288:b0:127:15cd:9f52 with SMTP id a92af1059eb24-12be6457e26mr2297000c88.5.1775057569588; Wed, 01 Apr 2026 08:32:49 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bedd4e4e3sm131752c88.1.2026.04.01.08.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 08:32:49 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 1 Apr 2026 08:32:48 -0700 From: Guenter Roeck To: Aureo Serrano de Souza Cc: linux-hwmon@vger.kernel.org, linux@weissschuh.net, corbet@lwn.net, skhan@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6] hwmon: add driver for ARCTIC Fan Controller Message-ID: References: <20260401112654.60560-1-aureo.serrano@arctic.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401112654.60560-1-aureo.serrano@arctic.de> Hi, On Wed, Apr 01, 2026 at 07:25:54PM +0800, Aureo Serrano de Souza wrote: > Add hwmon driver for the ARCTIC Fan Controller, a USB HID device > (VID 0x3904, PID 0xF001) with 10 fan channels. Exposes fan speed in > RPM (read-only) and PWM duty cycle (0-255, read/write) via sysfs. > > The device pushes IN reports at ~1 Hz containing RPM readings. PWM is > set via OUT reports; the device applies the new duty cycle and sends > back a 2-byte ACK (Report ID 0x02). The driver waits up to 1 s for > the ACK using a completion. Measured device latency: max ~563 ms over > 500 iterations. PWM control is manual-only: the device never changes > duty cycle autonomously. > > raw_event() may run in hardirq context, so fan_rpm[] is protected by > a spinlock with irq-save. pwm_duty[] is also protected by this spinlock > because reset_resume() clears it outside the hwmon core lock. The OUT > report buffer is built and write_pending is armed under the same lock so > that no reset_resume() can race with the pwm_duty[] snapshot. priv->buf > is exclusively accessed by write(), which the hwmon core serializes. > > Signed-off-by: Aureo Serrano de Souza > --- Looks like the patch is corrupted. Applying: hwmon: add driver for ARCTIC Fan Controller error: corrupt patch at line 587 error: could not build fake ancestor Patch failed at 0001 hwmon: add driver for ARCTIC Fan Controller I can not figure out what is wrong, but both git and patch report that it is corrupted. Please fix and resend. Thanks, Guenter