mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fange Zhang <fange.zhang@oss.qualcomm.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dmitry.baryshkov@oss.qualcomm.com,
	tingwei.zhang@oss.qualcomm.com, xiangxu.yin@oss.qualcomm.com,
	kernel@oss.qualcomm.com
Subject: Re: [PATCH 1/2] pinctrl: sx150x: Make the driver tristate
Date: Wed, 20 Aug 2025 10:55:38 +0800	[thread overview]
Message-ID: <aae972ca-5b8f-4329-ab32-12da1522e01b@oss.qualcomm.com> (raw)
In-Reply-To: <CACRpkdaeAqD=mpG4y16CPKwJ=pjATY9TxeRnXR9abziCOQb-0Q@mail.gmail.com>



On 8/19/2025 8:55 PM, Linus Walleij wrote:
> On Mon, Aug 18, 2025 at 6:41 AM Fange Zhang
> <fange.zhang@oss.qualcomm.com> wrote:
> 
>> Set PINCTRL_SX150X config option as a tristate and add
>> MODULE_DEVICE_TABLE()/MODULE_LICENSE() to export appropriate information.
>>
>> Signed-off-by: Fange Zhang <fange.zhang@oss.qualcomm.com>
> 
> Fair enough!
> 
> This patch 1/2 applied to the pinctrl tree.

Thanks

> 
> Please funnel patch 2/2 through the SoC tree.

Hi Bjorn, Konrad,

Would it be acceptable to include this defconfig change, or is there a 
preferred process I should follow to get it reviewed and accepted?

Thanks,
Fange Zhang

> 
>> subsys_initcall(sx150x_init
> 
> I seriously wonder about this. It feels like this driver should
> be a pure module_init() device. But other users may disagree.
> 
> Yours,
> Linus Walleij


  reply	other threads:[~2025-08-20  2:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  4:41 [PATCH 0/2] Modularize SX150X GPIO expander Fange Zhang
2025-08-18  4:41 ` [PATCH 1/2] pinctrl: sx150x: Make the driver tristate Fange Zhang
2025-08-19 12:55   ` Linus Walleij
2025-08-20  2:55     ` Fange Zhang [this message]
2025-08-20  6:18       ` Krzysztof Kozlowski
2025-08-20  7:34         ` Fange Zhang
2025-08-18  4:41 ` [PATCH 2/2] arm64: defconfig: Modularize SX150X GPIO expander Fange Zhang
2025-08-18  6:33   ` Krzysztof Kozlowski
2025-08-18  7:10     ` Fange Zhang
2025-08-18  8:02       ` Krzysztof Kozlowski
2025-08-18  8:38         ` Fange Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aae972ca-5b8f-4329-ab32-12da1522e01b@oss.qualcomm.com \
    --to=fange.zhang@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=kernel@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=will@kernel.org \
    --cc=xiangxu.yin@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®