From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F9DC83003 for ; Wed, 29 Apr 2020 04:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35D342070B for ; Wed, 29 Apr 2020 04:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=rylan.coffee header.i=@rylan.coffee header.b="crNq3xEQ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Ap0rU8p2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbgD2EEO (ORCPT ); Wed, 29 Apr 2020 00:04:14 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38215 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbgD2EEN (ORCPT ); Wed, 29 Apr 2020 00:04:13 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9CA7E5C0395; Wed, 29 Apr 2020 00:04:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 29 Apr 2020 00:04:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rylan.coffee; h= date:from:to:subject:message-id:mime-version:content-type; s= fm3; bh=XdFu2LVocl6Q8NRZueDlDbnMeY4kJhnop+dhw+CTWks=; b=crNq3xEQ miE6QtiCrnOUqpkUSUbBDRh2qsLXBjG4HVxh1b2hlkbmRldO1/jHjbCd+DtOcTLb f0cvGH7kS9R/3NQ5gjzO3xU6h9azxNRaeWXTR/zdxxJDju9+V0ZtWO5aly3a7d3B T4FTCp2jg8a1S0f3YywQO1H4oYS7lgrTQ6vDggyCIJ5oIoM3O8UOZ0LQqk8FgtPI 8gW7GdqDfVEpP2lDdEs14v7bEv4zTML0JsdAdOybOrB1t2IluWVE4poLi5NuUy0o kpAGo1Ky+yaZsyscpDdTCyClWPGweoOBktpAJDCpliH0ySPgW/DNg0qHuLSTsHMm 2M9nJ+0DutgrJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=XdFu2LVocl6Q8NRZueDlDbnMeY4kJ hnop+dhw+CTWks=; b=Ap0rU8p20uDRjVwyqeEfPRPwYh8Yhg5FhwxcNYkK+Fi/s dkygVnc4RUkpT7vGrkLzMcoG8xOSINjIPzdVgZVIgCIway5XhZpia30qEoiUg9YP Pe39K0EozzX2HdZUnX7zTIWsKgpE6EVlChCVoiI2f6EuYYqqvNIbiemHDHRUSmmy R2aKBYH+WoeZmvyRLR7cUUzcDU6TWj3ZOpaNteojVaUbQzlJtkc2aIjZHMU9mLIq E4ZwKiUo3X59+Bo40uQpGazN2bCwa5joz6Fwu4O/NvgUe/4/AHrIe8/EBsueOqJj dkqJYnmuYHCjRl9q0661QnGRuvohFcjphPTfF8ATA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedriedvgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugesthdtredttddtjeenucfhrhhomheptfihlhgrnhcuffhm vghllhhouceomhgrihhlsehrhihlrghnrdgtohhffhgvvgeqnecukfhppedutdekrdegle drudehkedrkeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhgrihhlsehrhihlrghnrdgtohhffhgvvg X-ME-Proxy: Received: from athena (pool-108-49-158-84.bstnma.fios.verizon.net [108.49.158.84]) by mail.messagingengine.com (Postfix) with ESMTPA id 1479C3280064; Wed, 29 Apr 2020 00:04:12 -0400 (EDT) Date: Wed, 29 Apr 2020 00:04:10 -0400 From: Rylan Dmello To: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Greg Kroah-Hartman , netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] staging: qlge: Remove multi-line dereferences from qlge_main.c Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix checkpatch.pl warnings: WARNING: Avoid multiple line dereference - prefer 'qdev->func' WARNING: Avoid multiple line dereference - prefer 'qdev->flags' Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index d7e4dfafc1a3..10daae025790 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -396,8 +396,7 @@ static int ql_set_mac_addr_reg(struct ql_adapter *qdev, u8 *addr, u32 type, * the route field to NIC core. */ cam_output = (CAM_OUT_ROUTE_NIC | - (qdev-> - func << CAM_OUT_FUNC_SHIFT) | + (qdev->func << CAM_OUT_FUNC_SHIFT) | (0 << CAM_OUT_CQ_ID_SHIFT)); if (qdev->ndev->features & NETIF_F_HW_VLAN_CTAG_RX) cam_output |= CAM_OUT_RV; @@ -3432,9 +3431,9 @@ static int ql_request_irq(struct ql_adapter *qdev) &qdev->rx_ring[0]); status = request_irq(pdev->irq, qlge_isr, - test_bit(QL_MSI_ENABLED, - &qdev-> - flags) ? 0 : IRQF_SHARED, + test_bit(QL_MSI_ENABLED, &qdev->flags) + ? 0 + : IRQF_SHARED, intr_context->name, &qdev->rx_ring[0]); if (status) goto err_irq; -- 2.26.2