From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB73C433DB for ; Thu, 25 Mar 2021 15:15:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B9A661A16 for ; Thu, 25 Mar 2021 15:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231322AbhCYPPV (ORCPT ); Thu, 25 Mar 2021 11:15:21 -0400 Received: from mail-bn8nam11on2058.outbound.protection.outlook.com ([40.107.236.58]:18497 "EHLO NAM11-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231319AbhCYPPC (ORCPT ); Thu, 25 Mar 2021 11:15:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFGdgnipvncVDp8tR+0bZ+iFc0Aa/Fe74WExk5Y6kelbZdsoxJ/SIgNIK1ucAqilwPMuLlUFxr19GBq+/nuaHDKo24AHXNcDfIXpt5B57fGOUnismmvaCwBD4xIF9D35A4PEJHINH3od2i3ZQP7JPWOiw2KuPPfkNgt1ddU8bcUr2+g68MgStuGzj2UArk3QcSqsYcLmfCgE576gzRsInXaI3ObIfJRrSwBmpvGv69nCEsApLNpLTNyJFmtp3OuX5dksnjsYR3efEVAF8T9c3zPigQtsXdKe6zJAz1B675dbk1J6/BmP60z9529vPPlx43k367BKD1jaeM9wkhul1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5g8Km8Pg25YFNhsXEHye2rR2PBLTHgsNqdzcWH4TzHw=; b=k8ZQmQIKvvdtUPHMPT5sRiSM1Q0ThF/rUN/dHnMzwhvAuXckSQpV09Np+NAK5ZhUWo6orn0Ak5+Lt3EKXvCwIW17DSej7VxgV9Y4OVanVqtLxUOrAtW0ARSTpD+5wDJSdwRqeoFy74mnfT4ddygahLS4mZC/0yHjTKWWv8O6qzjH0JH6LQX+FCtE/c04G8+8kjs3udQrhgkP+g1GigewUK4Xplk5n7+ubUx8PPMyUdUFnQOSXGWACFSlFbs7iKF/3F88K6kTBH8F4Nv7JQ1C3Mp8hn2spyimB3veMgkY4zM5A3LxlUn7S7gYLOLItopiU9wWwT53xGvgMqZGC8mKzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5g8Km8Pg25YFNhsXEHye2rR2PBLTHgsNqdzcWH4TzHw=; b=BbUqMdq7pdQNUUBtAwBS479Tdk/e1rJn6O/sEY5bBqdN1ddZBBUi6HnBcAN73EeWkt+8wRO8w1DSF8jW8ZFkDz78PAyVd63JdoYE0TQ98yuPDbQ/P4AeUwYSwAWk1+L/XMF26ove+q+HIPuXgOMFs/4mAnjdA7cRT1UMdSMeLJQ= Authentication-Results: lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by BL0PR12MB4707.namprd12.prod.outlook.com (2603:10b6:208:8a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Thu, 25 Mar 2021 15:15:00 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::c1ff:dcf1:9536:a1f2]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::c1ff:dcf1:9536:a1f2%2]) with mapi id 15.20.3977.029; Thu, 25 Mar 2021 15:15:00 +0000 Subject: Re: drm/ttm: switch to per device LRU lock To: Colin Ian King Cc: David Airlie , Daniel Vetter , Gerd Hoffmann , Huang Rui , amd-gfx mailing list , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org References: <22ad0b20-b879-bcad-5c94-80c162a9da74@canonical.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 25 Mar 2021 16:14:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <22ad0b20-b879-bcad-5c94-80c162a9da74@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2a02:908:1252:fb60:72d1:2a48:a80e:e149] X-ClientProxiedBy: AM0PR10CA0079.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::32) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:72d1:2a48:a80e:e149] (2a02:908:1252:fb60:72d1:2a48:a80e:e149) by AM0PR10CA0079.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Thu, 25 Mar 2021 15:14:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 67f27be6-de8a-4171-8778-08d8efa0c1f3 X-MS-TrafficTypeDiagnostic: BL0PR12MB4707: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1201; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xanag8VqMuT3tGtaP8gpQd6F5RFEm9xJHf9SnpCg874dq1VRwmiFOPXeMgtRsKVFBNwHkW20ybkA8Zq4ViV5iw96f+if645/CoguXvDOlByo60Dpjyw34uASqTRMr9KEWgAIYg9LQkrNpZsmdknm0WnIPECerxxrWTT9Aeum89t53xWPp2J8/pIxr51nlONmNo4OrqD3sdiQ6oYk08L6I0aBaUCokurTc8T0UD2GzaV8LIAmSgoHxT0Y/vBrc2v1TDxa8zDFM/7IIQsNIvmP7IhApSg2iuhJupEHOpOiQD3l6du92ZnUisuYECZzlUTzLUehVF20+Q4PBOGFiLZUqTlzRFmaX3YTdzHEFDf24iYCM0aFfc2WdBuBpecbg6kqaJxko9ZpE2E/gKjiE0uOzibdEufjFis6ZDB8dmwyoHQpPfGcnZCbljNhvNmQgKdo509kboyzbaDiLHxPEPTO9qsurs7U0La2tDmHjWERSoxEKrqEPY67cde51iGkyk2FZqdYXspJpsot4yuT+ax3obZjQ7/aVfBGo2HHZO+VQ5ANfeiwsUyuHYRc0B0Jb03s/lpWe9MvcS5xsQTr2gTadxjpADVaOhAWmIjiHpSUIcyOvr+HneuNeEtaDHcJfshNH4i0RutcmgxOzSvCDGDEhqmOU8Xotwiqgt8UKRAm9vcxF2Ouy1/lNM+WW95khrxQ8iyNhsR5C+TXRKGTxsoM6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(366004)(66556008)(66946007)(2906002)(6666004)(38100700001)(6486002)(31686004)(31696002)(66476007)(52116002)(8676002)(36756003)(6916009)(83380400001)(4326008)(2616005)(54906003)(5660300002)(8936002)(86362001)(66574015)(16526019)(478600001)(316002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZlZTUDVmcEpSMXB4VGZhTmZBSHNwSmJIMWhzQzJ4NW5ibHovTkRmTFF3SW10?= =?utf-8?B?dEJMTXF0c2N1Ym9wcncvYXlZcTF1Zy9TSVBwcDcxWldvemFMTDBHUVp0Q3FG?= =?utf-8?B?cHByenN2RTVzUWdmZ3ZKaUJwT2hXaGR1cndndXRMUE92dnhWdUVtV1F6dzNM?= =?utf-8?B?S0drV3JyTjZQNXNPSFViVWZGeXhicW54RDBLSlRKUG41Yk5MUTg0NCtHZUlE?= =?utf-8?B?dERPcnM4bmdSa3EzMjdpN2VJaXp4L2k1a3JKYmQ4N2tWRDFmVlBqdzQ2WkdH?= =?utf-8?B?RlY3c2pGZ0FRZ1dBaXhPTUZjcnp4L0pOVzZWdUhyOHI3Yy9BU0N5QTNHY0Zo?= =?utf-8?B?Y2NXK1ZobzRwVS84em1randwOWN1UFVsYXFvUmJpa0h3cGovdDNnak9rV1dU?= =?utf-8?B?Y2RTUEpQbnFmMjNYVGxNaEg3RlV4aDVwUVdBa3M5WmZ4cTFSS1dXbTFzV3V1?= =?utf-8?B?Vjk1UWtWb2ZnUU9VQlhMR2liYkpVUlFIZjVZK2dvMEhhcC83eDBQWTRsWFlE?= =?utf-8?B?TDIybW16eUxuVFNKMzVXMlJpb3o2NWg2UFU3eXN2eUo5c1IzTG05WSs1VGNq?= =?utf-8?B?b2gxRm9HaHV1VDAzOWRZd2xBdHVtSURDUnVMdlhxQURrbldWaXZTaTR3cDhV?= =?utf-8?B?SG94WFNQeXhIVGRRbGphWVlKR3U3MnZNZ2hoSVc5Qzl3VmV3N0lqcm52UVJj?= =?utf-8?B?WDJEaDFPN2xGTHZHNi8yQXlIMFBuSEJJb01jakdrSVVBcE1TaVpiQytJaC91?= =?utf-8?B?ZlIzbkIrR3Y4YXBzbUwvUkNoMlFna0NrQ1hkVW9QdkVDRzNpVUZEU1NHVGth?= =?utf-8?B?MWZPMWxQZEdkQXBpQVVsTTVxRVpUSU1zMlArN2dzZzRhZmNNU095SmNQb3pD?= =?utf-8?B?eHJPcG43N01qbUJucHF6Z1lDKzNLWnVlMDNjWVNVSlFvaWpiTXFoZ3FmSkU3?= =?utf-8?B?MjcrakJBQ2c4MVFaMTZWdXVWN3VJZG5xS2pteVRaQlFUb0xJSTAyakdKVlpy?= =?utf-8?B?K25aMFkzYmRyR2FsU3pUd1pDbnBMeTcwdnVoN2FCcXZ0cmwvbTZCOTJXV2Y0?= =?utf-8?B?ODNaaExJcnZrSVNGVm4vYVo1ZjVMOXBlTjh1U2NqSzBSVTlIdUpYNjJRemNu?= =?utf-8?B?Mm5MVG15V2cvanZyelJVMW5ZODBCalVFTjE5c3RmcTVNdnFHTU0yMDJXSU9C?= =?utf-8?B?WUY3bWdtcnk5WW04VWVJaHUybjkzVEZiUEJOV29YK3djajd1U3lhVlN1K2xR?= =?utf-8?B?OHF2cDBhVHBacUdXcGVsK1pldFJucmUxTjJJaXUzbkptVzRzMHc3OFpnRDQ0?= =?utf-8?B?KzgvRDcrclVFUmZIUk9pcjlFR2ZjUjZwM1ZOTytPMHpEMmdFTHdIeGZJZE12?= =?utf-8?B?K2dSTGRITlg1RVdFNzNneVNPRUJNTFFHeXVvL01vSW9wbmZwd3J2K2g4Zm1P?= =?utf-8?B?NkNkNXFrVXhrUmg3UDdSMHA2NW5BNlphb1l1UUk2Wnh4NjFZRE1KZTRkMlYv?= =?utf-8?B?ZEJxNk1mQ0lISDRtMjVPZitUTHoxSEVNaHd3Z1VkOVZIOXpDTXFBWVUxZUZ3?= =?utf-8?B?REx1OTU1dWhJUjVTYkNiZWNTcUtWWGdjZ3lDMGg1Nlh2ZHpYNUdZN3FSb0Iv?= =?utf-8?B?NUR1TnE2cEg0akxqeDBsRC9NV2hyOW9YSzllaEFjL0dHM0tNc2FDRndvNW01?= =?utf-8?B?ODdaYkhaaGFkZEdNZUFGVG42dTJFL0Q3aVJKR3VFeThNNEFXendnQkp4UzA2?= =?utf-8?B?bDRlYitEYkcxMmp6WVAwSklXcVJRaWhzTlVGZlcybC9EZjFHREJ6KzN6Qkc3?= =?utf-8?B?dlJscXdZVHUrUitiN1RSRmZMcnVQOThScEQ1QXppcnRBbThLMkRuWWlGYVJQ?= =?utf-8?Q?PP4cAASUWcxGc?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67f27be6-de8a-4171-8778-08d8efa0c1f3 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 15:15:00.3172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9vYN0UjV+Je/g0Xll1k2Fj7wTorfjV+R8/+6lWQTJaoBDDeYbzctyZYFfnH3Lr3g X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4707 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks! Just a copy&paste issue. Patch to fix this is on the mailing list. Christian. Am 25.03.21 um 16:00 schrieb Colin Ian King: > Hi, > > Static analysis with Coverity in linux-next has detected an issue in > drivers/gpu/drm/ttm/ttm_bo.c with the follow commit: > > commit a1f091f8ef2b680a5184db065527612247cb4cae > Author: Christian König > Date: Tue Oct 6 17:26:42 2020 +0200 > > drm/ttm: switch to per device LRU lock > > Instead of having a global lock for potentially less contention. > > > The analysis is as follows: > > 617 int ttm_mem_evict_first(struct ttm_device *bdev, > 618 struct ttm_resource_manager *man, > 619 const struct ttm_place *place, > 620 struct ttm_operation_ctx *ctx, > 621 struct ww_acquire_ctx *ticket) > 622 { > 1. assign_zero: Assigning: bo = NULL. > > 623 struct ttm_buffer_object *bo = NULL, *busy_bo = NULL; > 624 bool locked = false; > 625 unsigned i; > 626 int ret; > 627 > > Explicit null dereferenced (FORWARD_NULL)2. var_deref_op: > Dereferencing null pointer bo. > > 628 spin_lock(&bo->bdev->lru_lock); > 629 for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) { > > The spin_lock on bo is dereferencing a null bo pointer. > > Colin