From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23C6638F624 for ; Mon, 16 Mar 2026 10:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656970; cv=none; b=fi6xKrFl+fgEdYXDrs2ajQVjKw+Zg3ZlLKYJb1LZxur7TKbUBTnzWAcM47Yu+hhZooGmHEkF4eaHWt2ppiL4Q+TdXQUwyhuS2nDeRUAmK6S1Z8hE43XWcqu9aJjeSELtwp6Q0SKsIRbyfjRRnI0GOoQYjQ0IAnutGnkdP7l3nmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656970; c=relaxed/simple; bh=sinyi7GmNx1mY7QcKno1ufbgfnuVSamjAas3mDig7QM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SbuqN8h6cwJ5nAwE1hZrJ2jTP0jZPrlebVrExl+Cq4T/fik++oa+0efp6ZhG6YbmpiMaL0LLQVJZibbpBY6rhbvTGzaL06+M424DxNmpqT6Q1nYel1o/oiHCm5J27AnGTjfilnB5Gc9lwHk4LbqjEytMVMnQ2zp6LlbDAGnXKUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G6aV0x6a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DzasGIe0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G6aV0x6a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DzasGIe0" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64jW6538903 for ; Mon, 16 Mar 2026 10:29:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1SyIK5mrij/+PqCxigjEeQmg92ExBxvCySG5xA439Ek=; b=G6aV0x6axHC7xP9b tEyrqajS9VD7TDEDv43Rb0nvkVZGF8pUrIlc4Zk6ieV+slRyBvyxyW9pWgEk5HUm vCbGDH0NTBcDvKXudHf5Cg2+qWymTirlODrBtKKqikT3pI8ASzdydwrzUzTLpNk8 4QGWWtaZFtoOPK7jTW+jiv5RhLj8uXLvf0B1Y7GnJtzuktWv6869gvsk1/M1fc8z vEVplgikeDQ3sdkPrj0ntKHV6itEgXQC6C3tmDW/bMDULWJSPbEXrZi8ywSn8hvL BTjHNcXixfDQWcF7RkUpQcX/6m+D/0rf2rogXTnUNZzyk9AfYhzhG1ASe/nvA9M2 sRe7rg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvyy5n7ux-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 10:29:27 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb39de5c54so286515685a.0 for ; Mon, 16 Mar 2026 03:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773656966; x=1774261766; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1SyIK5mrij/+PqCxigjEeQmg92ExBxvCySG5xA439Ek=; b=DzasGIe0+6QtrCv+Qe2vJjiDYVo1WoWyHkAl1hsNzC+jrIYJgC6tary3Auro7vpYG3 NaqTqBJoiSyPacIBtYDKjtBLV7zDwxY7271ZHOZ2q6+dtbmGyebM+a5KfugzLIv9JS57 lhNg77AQC9T+jdVB+3rZk+NdDItj9yJqsPdgJ7itItO6Qve0BLhLxLOxlZdDn0ZPxpTI jnGSHt/2ueo4sP1jJ8PTV+Ox98b+HA8WU0aILOgNBuXwKMrV0IuYj0HRW8g5+oerycjf pv0dFaYqpiWkhG+/xz6/Xgh0dleu4sTAc+UR/oo2xrOPpba9WcJjjQAKixuvZ8FAkJhf p+HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773656966; x=1774261766; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1SyIK5mrij/+PqCxigjEeQmg92ExBxvCySG5xA439Ek=; b=UHDrT5RwK8Pex5UR2Nf8yLVHeG2vrow8coKkPZzbwAMaFczFTzicrV0c/4mQyMGe+e XkI2IO/2lJNvt/ofrjHp8en5igFdEObBbgqfw8Cq9oNNVoItYt7xsQRmlYfXptXYnDAT BqBIHrNiTDIrkEq7c3nB7kW5zT9w5mY6Ro4lOXJ3BYitn3xvTcohC/8fXnj1pGEaT3pE mFxGM+sPxUeJQNc59KohvMOoPAPlFHGRpAvGwIVwjku7Y5Iz7M2yGrYn9Gs1VwjBsVh4 qDznu53fMCFzrt4RdRS29vCGlZdnp8WmZqcrx11DE2KNa7Vx6ZPc4mcXHbwdSZp+L9fB SkZA== X-Forwarded-Encrypted: i=1; AJvYcCXNlHh/x7ROtH4F5DNDPpD6MbaLWpY76ChEzKoJQx5PbbV8njo9QrX221y8/IJkgmziV+votYmAjGQjCJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YzEJDwoHvtE6i/s4D6YWYCDbWIkPZ9xDRTKRuXNCBUyJN+WIxlS Adafh83UuBkb7IYdsbp9W1Hbu5YuLW0+Can3CFCUJ4JxJj3PFAZDWPpcvSTQ7vOaqWqgLcrr5Nz STxaeG5lrJRy+/BavGdjKlwOjvOVZLnko3MYCQPJsL0jNLz1+KfLZbEsW7Zc0CikP1I4= X-Gm-Gg: ATEYQzxl0Mz/qydF+3TQ7XlutpNBJ1hzuAzDOWupt3WDSFtLGelrsLAkMfv5KBe+T5c 7KXHgQ0Cdrz8Qb1f7hx+VJ0+wYOxFd/z9iYT/mIpLr0ipbn8Xx6Dd/JMvRjhEi9MlNHigwJfVrD aeykp7hHJHXuZfgUcz693hIELSVHfRmjfUI9Flsn5AruPaZg7ywY6Eb6AHzQZH6Xi8swEwIPxy0 H4sG1WlP5y4i7iT1vZTzQDuq61O0ClerZRGwh/XBvmWssoBT7eB9ily9a+EJyu4wXnV8HQkA9z8 k99x+5BiGqRfnEnS6S7YN2lICu6rLj8sSTvJk/eZtggayoucVrtGWwwUQoJI3tZ8tjFbFNCJJ8J RiT7V+ZYb/Zb9w0kI67ugG+DGtFWYYzwMoqb4oKm1tIsPyXVcl+DFyegxeh+zQ41k+1eOtSc9u1 NQQR8= X-Received: by 2002:a05:620a:4113:b0:8cd:9828:a7b4 with SMTP id af79cd13be357-8cdb5baac4amr1112216085a.9.1773656966466; Mon, 16 Mar 2026 03:29:26 -0700 (PDT) X-Received: by 2002:a05:620a:4113:b0:8cd:9828:a7b4 with SMTP id af79cd13be357-8cdb5baac4amr1112213485a.9.1773656965884; Mon, 16 Mar 2026 03:29:25 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66350d80a90sm4876205a12.32.2026.03.16.03.29.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:29:24 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 11:29:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices To: Anvesh Jain P , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: SbIIQ_bBUJDggFRnX5GZjrf81b6Bj8Px X-Authority-Analysis: v=2.4 cv=QOxlhwLL c=1 sm=1 tr=0 ts=69b7db87 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=sGNizEhdnyv83XcJ-SoA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: SbIIQ_bBUJDggFRnX5GZjrf81b6Bj8Px X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA4MCBTYWx0ZWRfX3kDiI1Vfct4L /uqLqAN+XWP9vF/wnnUbPi8/w3zuGcGgBmzoqCKCyRFFhRxbJpAW22y0Q+ICeL6MNNnz/GsDXWW 9T7Mz9/rmpzt+Ad4e9ihRsZuhlaVkJdMyRrRo75D5yxzOp6bmcnDoA8Q9J0nTKnP/Ts8HbNW9xB XIWT2MnbfNdilp4VsjFdp2AKJMZKVdZ6r24gBuhT3iG6bM9GkqRM9/mT0hJa/6k6AFp+WiKC7tP JTN2dj28ilGsHD0p58tIDAno5JRgXoaH7/ycQa/9KA/irwG/bJPYEdruyQ2FSUgWqMC2daglkpP LqI8irWMrdFGZ4rf169nV7I7cAhlF4M/7heHW25xFULZW+ZCXXlaeQAQ4oMSGlUn0NmHXyj+dPN 8IZIkf7uZCe0gfF+fDHz8jnvHYlVFSN645kAboZMC2baseLgx3PQltjz+NPDuGxM0X/5gmdPbRX pO/sYvV361hLY2LARzg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160080 On 3/13/26 11:29 AM, Anvesh Jain P wrote: > From: Sibi Sankar > > Add Embedded controller driver support for Hamoa/Purwa/Glymur qualcomm > reference boards. It handles fan control, temperature sensors, access > to EC state changes and supports reporting suspend entry/exit to the > EC. > > Co-developed-by: Maya Matuszczyk > Signed-off-by: Maya Matuszczyk > Signed-off-by: Sibi Sankar > Co-developed-by: Anvesh Jain P > Signed-off-by: Anvesh Jain P > --- [...] > + * ------------------------------------------------------------------------------ > + * | Offset | Name | Description | > + * ------------------------------------------------------------------------------ > + * | 0x00 | Byte count | Number of bytes in response | > + * | | | (exluding byte count) | > + * ------------------------------------------------------------------------------ > + * | 0x02 (LSB) | EC Thermal | Bit 0-1: Number of fans | qcom_ec_fan_debug_mode_off() documentation only mentions values 1/2 to be correct - is that the case? > + * | 0x3 | Capabilities | Bit 2-4: Type of fan | What types are there? CPU/AUX or similar? Konrad