mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Aldo Ariel Panzardo <qwe.aldo@gmail.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Cc: horms@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH net] nfc: llcp: check socket state after locking in nfc_llcp_recv_dm()
Date: Fri, 25 Sep 2026 17:16:48 +0200	[thread overview]
Message-ID: <aaf33c3c-7a52-4afe-82bb-930b553a4b39@ixit.cz> (raw)
In-Reply-To: <20260925023509.3060096-1-qwe.aldo@gmail.com>

On 25/09/2026 04:35, Aldo Ariel Panzardo wrote:
> Between nfc_llcp_connecting_sock_get() and lock_sock(), another
> thread can move the socket from connecting_sockets to sockets via
> a failed connect + re-bind. After lock_sock(), the socket may no
> longer be in LLCP_CONNECTING state, so unconditionally unlinking
> from connecting_sockets corrupts the wrong list.
> 
> Add a state check after acquiring the socket lock: only unlink
> from connecting_sockets if the socket is still LLCP_CONNECTING.
> 
> Fixes: bf1460acdf8c ("nfc: llcp: Fix list corruption / refcount desync in nfc_llcp_recv_dm()")
> Cc: stable@vger.kernel.org
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Signed-off-by: Aldo Ariel Panzardo <qwe.aldo@gmail.com>
> ---
Thank you for your patch, but please never send new version OR another patches 
as follow up to existing thread.

Please read: https://docs.kernel.org/process/submitting-patches.html

Thank you
David

  reply	other threads:[~2026-09-25 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 13:33 [PATCH net RESEND] nfc: llcp: Fix list corruption / refcount desync " Aldo Ariel Panzardo
2026-09-24  3:10 ` patchwork-bot+netdevbpf
2026-09-25  1:35 ` netdev-bot+sashiko
2026-09-25  2:35 ` [PATCH net] nfc: llcp: check socket state after locking " Aldo Ariel Panzardo
2026-09-25 15:16   ` David Heidelberg [this message]
2026-09-28 17:38   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaf33c3c-7a52-4afe-82bb-930b553a4b39@ixit.cz \
    --to=david@ixit.cz \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qwe.aldo@gmail.com \
    --cc=sashiko-bot@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®