From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36404C433DB for ; Wed, 27 Jan 2021 03:55:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE8BB206B9 for ; Wed, 27 Jan 2021 03:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237591AbhA0DzJ (ORCPT ); Tue, 26 Jan 2021 22:55:09 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:11602 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392495AbhA0Bm4 (ORCPT ); Tue, 26 Jan 2021 20:42:56 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DQQll5dQ6z1607q; Wed, 27 Jan 2021 09:20:51 +0800 (CST) Received: from [127.0.0.1] (10.174.176.220) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Wed, 27 Jan 2021 09:21:54 +0800 Subject: Re: [PATCH v3 2/4] arm64: dts: correct vendor prefix hisi to hisilicon To: Arnd Bergmann CC: Philipp Zabel , Wei Xu , "Rob Herring" , linux-arm-kernel , devicetree , linux-kernel , Zhangfei Gao , Chen Feng , Manivannan Sadhasivam References: <20201208124641.1787-1-thunder.leizhen@huawei.com> <20201208124641.1787-3-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Wed, 27 Jan 2021 09:21:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.220] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/1/27 6:23, Arnd Bergmann wrote: > On Tue, Dec 8, 2020 at 1:46 PM Zhen Lei wrote: >> >> The vendor prefix of "Hisilicon Limited" is "hisilicon", it is clearly >> stated in "vendor-prefixes.yaml". >> >> Fixes: 35ca8168133c ("arm64: dts: Add dts files for Hisilicon Hi3660 SoC") >> Fixes: dd8c7b78c11b ("arm64: dts: Add devicetree for Hisilicon Hi3670 SoC") >> Signed-off-by: Zhen Lei >> Cc: Chen Feng >> Cc: Manivannan Sadhasivam > > I see this change in the pull request I got, but I'm a bit worried about the > incompatible binding change. Wouldn't the correct path forward be to > list both the correct and the incorrect properties, both in the dts file > and in the driver that interprets the properties? Hi, Arnd: This is one of the patch series. The other three patches have been applied by Philipp Zabel and are currently in linux-next. https://lkml.org/lkml/2020/12/10/697 > > The binding file in this case would need to list the old name as deprecated, > though I'm not sure how that would work without causing a warning about > the unknown vendor prefix. > > Arnd > > . >