From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC54C83F13 for ; Sat, 26 Aug 2023 10:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231995AbjHZKQu (ORCPT ); Sat, 26 Aug 2023 06:16:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjHZKQb (ORCPT ); Sat, 26 Aug 2023 06:16:31 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BD8D1FC3 for ; Sat, 26 Aug 2023 03:16:29 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-500760b296aso2060435e87.0 for ; Sat, 26 Aug 2023 03:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693044988; x=1693649788; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4JjUBaYdPSxFwsO+4WnIkvUUmyhb29fFdO517V2zTpg=; b=gTfYUL5JVbtspwhN/UePvR3q2PQJd+IuzY1JRC9g9GFZn8GeulpqfHPOCtCX7MgYFX +27RaUPHJ+frWPlhLJ1sNYujHSSpHry2yk/KOMyT/9c5UEG0BjvwJuNfrPQrHNQeKLJj bjFkAyNbTygXSuWM2mLbOzPrjJt+Ayj8N7dfYgHNYY2kdU024pDLaNDubP2XoeO3OrVb wyli8Gro7axizoksTrGM4Jb8D3jONfvGFeRRn0dZBt8Bs9vxHu0bgMBzp4yYWkY1tFwn 4XKDq8xlXROcmpn9S5w1Bi3T0E+PODPXoZqdz6z57QlX/V4D7VIfOPH1v5CRflBQq+eo NLSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693044988; x=1693649788; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4JjUBaYdPSxFwsO+4WnIkvUUmyhb29fFdO517V2zTpg=; b=BTLB1ue0fhYsMOVzR5RnJxPoHyEiJH2Uyg+b0X5cIX2/x1EX4MhmY5sWRB9aU32wmH TVYfY6Fsfr7d1nEYffO6c7nJoJtwqqclv9zfqbos9kcXUeZ5A6at4u9QniantaqINF7h qJ+TSLsnCilO9Vf4iiQsQsCGoPl7U4vVMt08OkXjJd7vdhMGNXaSoRv/iu9/8hvNntQ3 tok27219i6bti+vy9oDgM7y0I2tbSJO2mbTaMKv6aU+2GsyOfgMYWpfGXdghYaiPyLPd aK0IH6zzzrdsUr9MIXEAdnuAiGz0CUT6eL++w5r2KsTostoWEnlXOjTY+eB1MsanVm9v orFg== X-Gm-Message-State: AOJu0YzCotCYpS3MpQlQQ1axjPghhQN0jKENx9PkC/dG1XJ+ZXKDpUxr rsADr+OHO5Mflt16a4XhDv1rYQ== X-Google-Smtp-Source: AGHT+IGtRGMiExpTYje2siebBOhfYj4Z0a2s3NPoLgi6o/rDLWuwAlcGfIicvCPbKKfT6Ps+SfvJyA== X-Received: by 2002:a05:6512:2202:b0:500:96bc:be60 with SMTP id h2-20020a056512220200b0050096bcbe60mr3812461lfu.1.1693044987646; Sat, 26 Aug 2023 03:16:27 -0700 (PDT) Received: from [192.168.1.101] (abyl74.neoplus.adsl.tpnet.pl. [83.9.31.74]) by smtp.gmail.com with ESMTPSA id i11-20020a056512006b00b004fbad682ffesm665461lfo.88.2023.08.26.03.16.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Aug 2023 03:16:27 -0700 (PDT) Message-ID: Date: Sat, 26 Aug 2023 12:16:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] media: qcom: camss: Convert vfe_disable() from int to void Content-Language: en-US To: Bryan O'Donoghue , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823104444.1954663-1-bryan.odonoghue@linaro.org> <20230823104444.1954663-15-bryan.odonoghue@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20230823104444.1954663-15-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.08.2023 12:44, Bryan O'Donoghue wrote: > No version of vfe_disable() currently returns nor has ever as near as I > can discern ever returned a meaningful error code. > > Convert from the unused int return to void. > > Fixes: 633b388f85c5 ("media: camss: Refactor VFE HW version support") > Signed-off-by: Bryan O'Donoghue > --- Up the chain, vfe_reset can fail but the error isn't propagated Konrad