From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32233C433EF for ; Mon, 27 Jun 2022 09:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233591AbiF0JfU (ORCPT ); Mon, 27 Jun 2022 05:35:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232769AbiF0JfS (ORCPT ); Mon, 27 Jun 2022 05:35:18 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 162DD63DD for ; Mon, 27 Jun 2022 02:35:18 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id q6so17793541eji.13 for ; Mon, 27 Jun 2022 02:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TeN/iwsTV4FhP/OywXKY/fx1M3aFIWw7RCkbflk2R9o=; b=WdWufUduLcKXBmqthhLKerQLhk1pUFi7XWTD9qKZ3PlDx5Y7FjMPp8ypB8pn82kYKi BWSaxzMgNqx9STnQ46/HTMxh014kcmYRTqsqAQ08HNwys5PInRLlaxCG7RqB2iU3/pQK Y3UHsv5GwvBYbZdrNKivf/IuS2O6MgYLqD08RMXgfElnyrjg+waj73Eseg3z+rGjdnkM A5Ec6P/315Yqt3hvigPyvgpTsZtqSSM+S7JoXw2IUzApO34x6jRHqwaTk4bk7podakac ESSpBJdo7E1FoMYDyDkzql1ExNYhOqa4sVgaUB31NUnwCifu/DcaIfCxeWsEPjwBizit QkOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TeN/iwsTV4FhP/OywXKY/fx1M3aFIWw7RCkbflk2R9o=; b=ciiWQ4WJtWDnSHe0frcUG2rqJ+Q8nRYwpQmZd+sYmjNeogdUg7tEFygFlAZW6R2KbN fUo0c/bhD2UIqulD7u5VTYc/qoj7yaKFF+Ulj/LmdIwDwbr3QfNF7hEH+/3t0I05chZ0 XmRp2UTNcedkaIykgiwPE4rxtbzdGqP5oYs5o59ECi5PNZgwlc1D79RwAfDWcsbhxnqG x2vTAIa1+xLL+dYtE91Yz2tvlMFBedXl3jLbMG7kr8yjhJUsMYQm8KOXoGEhAU/5S12J LYE3gTh5dZxRyqSNjS17gBlEvvsFGgR9ik20kaD8EOF7DSc1ss6c92D6dvWUUrUaUXeT JPEA== X-Gm-Message-State: AJIora/vW8eAb7IiqZm8Z1qz+NQe4a3fZdJgD26nPZyw4Zxl96TIHuex Q9y79XPMFQtxKPvEYLaV0y6FxA== X-Google-Smtp-Source: AGRyM1uTdIi0aYEYixohA+nAVSHM9M59wtJB/1A4P8XfRZh7rsryDIKZ3vrVQ13PulLSe/wHT/dBAg== X-Received: by 2002:a17:907:62a9:b0:726:2a3b:8507 with SMTP id nd41-20020a17090762a900b007262a3b8507mr12026191ejc.666.1656322516674; Mon, 27 Jun 2022 02:35:16 -0700 (PDT) Received: from [192.168.0.247] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z21-20020a170906815500b00722e7e26d22sm4812672ejw.58.2022.06.27.02.35.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 02:35:16 -0700 (PDT) Message-ID: Date: Mon, 27 Jun 2022 11:35:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC Content-Language: en-US To: Quan Nguyen , openbmc@lists.ozlabs.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Open Source Submission Cc: Phong Vo , "Thang Q . Nguyen" References: <20220621092120.2427152-1-quan@os.amperecomputing.com> <97934f38-4da5-ab9e-7089-d6e48edd5e6a@linaro.org> <9120c167-38c2-f8c4-e039-4202d5844639@os.amperecomputing.com> From: Krzysztof Kozlowski In-Reply-To: <9120c167-38c2-f8c4-e039-4202d5844639@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/2022 11:32, Quan Nguyen wrote: >>> + >>> + ltc2497_reg: ltc2497_regulator { >> >> No underscores in node name, no specific names (Devicetree spec requires >> generic), so ltc2497 has to go. You could add some more specific >> prefix/suffix to describe the function. >> > This is to monitor peripheral voltage so it would be updated to: But it is a regulator, not a voltage monitor, so the node name could be: regulator-0 regulator-voltage-mon voltage-mon-regulator > > voltage_monitor: voltage-monitor { > >>> + compatible = "regulator-fixed"; >>> + regulator-name = "ltc2497_reg"; >>> + regulator-min-microvolt = <3300000>; >>> + regulator-max-microvolt = <3300000>; >>> + regulator-always-on; >>> + }; >>> + Best regards, Krzysztof