From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbdHZGJy (ORCPT ); Sat, 26 Aug 2017 02:09:54 -0400 Received: from mail-eopbgr00093.outbound.protection.outlook.com ([40.107.0.93]:44400 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750737AbdHZGJv (ORCPT ); Sat, 26 Aug 2017 02:09:51 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and devm_kmemdup() return values To: Jonathan Cameron Cc: "Gustavo A. R. Silva" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe JAILLET References: <20170707045311.GA4535@embeddedgus> <0ba9b76f-41f8-3171-2eb7-d9abbe106674@axentia.se> <20170709181023.54458b6c@kernel.org> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Sat, 26 Aug 2017 08:09:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170709181023.54458b6c@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.168.30] X-ClientProxiedBy: VI1PR0801CA0067.eurprd08.prod.outlook.com (2603:10a6:800:7d::11) To VI1PR0202MB2559.eurprd02.prod.outlook.com (2603:10a6:801:6::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 269c04ec-0b7f-4ea0-f839-08d4ec490e36 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;3:9pyO/fwl8HBfzNDzB5g88VDQV9wq9IXYgnPG+9Z5DBuCxxrAjd6ouaUc0jjjTw7nXRcNM0rZu1+thrKcjS9SWiML58d5oKeq5FkYY4qBBcNYR4ijWkqRwcWh2cDWecObAy4ubG2m6jfzH+45fxR+9Ii/j+aKuaHau02n7GXDbn27C/MF7oMo57LUzHmPYwLxhO+kdtJNVAn0gxvvJ3I9SG07RGR110c2frDbyM8K1ykmwSNOwd0dPrf2pEfRXUN1;25:jld7r5gZpZMRT2jhqxkH0PDRDRsFhliHaC9evUZzCp96bHxYoyFDgRrOh1aSqaNJao/N46VDpMHK0txJQnxHdbjuRknttuD8iu9TJ7j4rCXmkZBw/e6mWACqb3Zy7ah//EtKkqc3iH9ha2zN66Swaq1vks2d4kQKLPsJs+Epgy0rVjkkV2S6ISv4MNM4X8UhIJzXmJa2DAjPtgEz8SC8xxAUf41Rh3kR7E0H2QujdzpmSNBFQvqm3xUHnpggnIISlUUPWxEJNLOnvieNK5PIi5G7NP4xOHfQTDz5OHLr1KIOdvqMSRWPHY2L1aoSpijixsEMZzLANXdFny0Y/p8XXQ==;31:t2sFs2qgJtF2It+HN37Nku9p3RJp0UjvFkQsrXUxpb3OiF1Yr+fbopZ2Lndw/bdllq4/DUw06VVArVobul766+mPVuS2getGQ1tlHCybwWZyfH9h5KEJ5t14FtazKFXsuUTlrAjJSLKuqHFvn2c6rR+9mx2Un63pteufwGxnFqgtRjvci+PamEluDPvOJoHJ0ZX5WhfwDUm4WdUUZoDuOQGdLwwRylwzPwPMON/q+lo= X-MS-TrafficTypeDiagnostic: VI1PR0202MB2559: X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(201703131423075)(201703061421075)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(2016111802025)(20161123558100)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0202MB2559;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;4:x3jAsZfHjSkWEGgNAl7jtA9btJZqN+0FGkS7KPL8i0PAknXZs1RwnKEbnlQe1JDbNke3NUpM8h++mIF9l6jQqN15NWHxEkGerNKMNJ0VFCDokBvxBoP9Fuan+Xhc5QIpexW4G/yiuA5oLdsq98YH0VIkZEfM7Bb2TXis9M7syZx0TgTcf6yTbnbM+zp8L4WNyMxAwxNxNNtuRoOqSZlhL1hbWDeqt4vy0+3EeL4K/bHHfM99cAv8ERXDp2seSJm9 X-Forefront-PRVS: 04111BAC64 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(7370300001)(4630300001)(6049001)(6009001)(24454002)(189002)(199003)(377424004)(8666007)(7350300001)(508600001)(2906002)(23676002)(105586002)(97736004)(54906002)(93886005)(106356001)(4001350100001)(65956001)(65806001)(83506001)(189998001)(76176999)(54356999)(74482002)(81166006)(86362001)(3846002)(81156014)(66066001)(117156002)(6116002)(8676002)(229853002)(47776003)(31696002)(36756003)(50986999)(230700001)(68736007)(6916009)(2950100002)(6666003)(3260700006)(50466002)(25786009)(64126003)(101416001)(33646002)(966005)(77096006)(5660300001)(6486002)(53546010)(53936002)(65826007)(6246003)(42186005)(305945005)(4326008)(110136004)(6306002)(31686004)(7736002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2559;H:[192.168.13.3];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAyMDJNQjI1NTk7MjM6elFuUW90YzJFd0FjM0dpNlg5UGd0ZkJh?= =?utf-8?B?bXlIb29WK0JpLzZIcWphcXVFWnp3Uy82MUNPQlc2dkZXdXNSZ040M2F5YWpN?= =?utf-8?B?S3RGVGQ1MEVtLzkxYnNiV0IzMnhBeHA4UVcvQktFRkNJMzVYOURIM1lhRVpi?= =?utf-8?B?SDUrV3lKWmdxT08rWTE4WkhvRVkzSFZrQURhTGIrVlUwNmZiOVBoYVFOamxs?= =?utf-8?B?eGlQZlYyU1hDTmZNb2JUVUFLaTV0TGtHZlBUVklZS1dCeVNzSitzK05uYTNT?= =?utf-8?B?NW5pL2dBdFNFazVQTzJwd1dURjF6RmI0YUJLNUFra2p2WmNzbTVNRitRODl0?= =?utf-8?B?UXhEMUJkeGhPVzV4VmlHcFpJbERDeXFvaXpGSVZsZitaVlhuU0d6NDhNaEpz?= =?utf-8?B?SlpXSCtYQ2l1aDF5OXdSWHFXSm9OelQ2d0NXYytiS0xKdUhUb2tUWVdSWFNP?= =?utf-8?B?aW0wZWxWblB6T1NtczZ6TXc0YXo3S1BxajRjZWZiVnJ0K3FMSWI2MEUwa0VZ?= =?utf-8?B?Yzd1a0xjcFdBZnV6Qmx4SExkVzAxaG9BSnZXUG91bVJqSjNKU2hacEJsTlpM?= =?utf-8?B?eXYwd0U3QVFzT0MwU0NyMGJQK1FndkVWSTlIaGlqSTUzUGxTU0RiWlVBVGww?= =?utf-8?B?Y1lJUTRLMzRmVGdFTmN6Qldwa2Zka1dvWXJ5MUMrbWlqNWdOOHZCYUZ4R2h3?= =?utf-8?B?UHByb3pRWlNoTm5sVE5NVit3c2hpZDJma3A3eTdNcWlIYWZRZ0FaV2htOFIy?= =?utf-8?B?bjJKb0JmSDN0UDN2ZXdEeVRNNEl6TlQ4Vmd1TkZzaDhvaGExZVhiNnd0RVdy?= =?utf-8?B?RTZVSFRHUTRvcXhJamxocTNXL2FFaVRYYk5OUlEveklrZjMvMklzbGNxWUFD?= =?utf-8?B?dFZEY0c1YUViR1B5OXFjWFN4ZWtGamE5SC9DVkI3TFJRaGlCcGlRN2I1TCtG?= =?utf-8?B?VTFBa2JQUWxXYW5YdkRMejN0N1p0UVBLb0thTHExcmdrU0pkb2F1UFFsQ0Yr?= =?utf-8?B?cFlUbHZaODRSVDUyNzFGVURjOGNzVGN3QjBwWHd5anBmcW91ZzNNblBkbnBw?= =?utf-8?B?L1k3SkZScEl5c1l5NXBZenJTQmdJVUZwUzlBSjhTZ2pPQ1VwTnZQMXJOaVlw?= =?utf-8?B?cytCY0lRTzg3L01WNGdueGpxTGg5S1BZTURNK1VOYVA1OTJjZ2I1UlhSSWFM?= =?utf-8?B?UUVJbXUzWlFGY3ZUZTY1YTRSMEN5SFdESnZFSC9PdWJwdlBFTjdvTHFKMER5?= =?utf-8?B?OEsxbWpCVEJtRiticDJaemljejQ1UEFsa1ZlUFBOUXhrMTNBR1RGRHVkL0R4?= =?utf-8?B?RGY5Qm4yUXR6ZnpUbkhNZ1lIcGJJdHJIbWMvazVOdlV3bkhUaUtOZGFXRE8w?= =?utf-8?B?aE1URUx2SUljOHJiVnJCZ0V1OWpwU1RGazM5bVpKTFZ5MWVOellXZTh3b3U2?= =?utf-8?B?MWQ4NHdlK21lZXhQZEc5aG1IR3NLWlNJOFBZR3JvK1FsdStzWDFZTXJXZUdq?= =?utf-8?B?Sm1oUU9wK1kyVElVb1B5enAzTXliU1JNTy9xamtudmtUYURVL1NnV2tiYUpP?= =?utf-8?B?cWJwK0RRSGZMMDNETGxsRmlrdFRucW5jSmNNbkczUUpmYURBQXpZdzFMazNV?= =?utf-8?B?NVA1T2h3RCtpQ3MyV1dxNTBnR2RHcDRkS0xLc0xXc0VmcHQ0RTJFT1JtUDA4?= =?utf-8?B?Nys3aXNnQ2lzRFZ4R2doM24vL0pvcFpVT1ZyRHpmRmMydU00bUY4K3E4VUxz?= =?utf-8?B?Rm9kMjdYK0laT0FjMThHRW1DODNkTWZyb2V1T3VhcUtCU3BicWlnN2N2cm1x?= =?utf-8?B?cTN3byt0SEFJZTYrYklpRTUweFFXMzNDcE5OUGZVRVl2eEtDKzg0Lzk0RU9h?= =?utf-8?B?ajJMMnl0NWdUOFVWR3EzTWNKYnZ1ZU4yeGh0RTZYcXE5T0JqYjJCVGdvaUxo?= =?utf-8?B?OGZ5RFJvN3Zycnk1bmR2Y1pLeFcvaDVQUm1IbEg3UnQyTFFMWU5sNlIvSi9N?= =?utf-8?B?QWxwc01WZ3p2L2FTNFBCUjErbjkwdUh6dnkxZEtSTjdDWSt6WW1RZlBxelZW?= =?utf-8?B?VDNTRjQ0VEhkc2FiVlA2K0pEaFZYOUYyZ3ZQeSt6WEllK2VBOTk4WkQ3V1Zz?= =?utf-8?B?REN6dz09?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;6:PHI1BQR/+ul1KDYBxmJ/dWtPo4ecU2U+CXzIDxVmyRq6tzvphuyPaD9oPM/uyxxYk3+PSI8lGEv7idgUZZZsGK+YsMpyEMyLZP7HdeFXD1Yk+NOPHAf4vWkKE1tiHc/jt11fA21OgxqwSgyo2sQf9igkDQV/cvmdvWrI19N3NTjcQEC1wnqk7M5qLxiWCvFDi/Fu0ddWaDMaJvw+PL9sLTD3/h7qQEesAXq5I2UoQXhvfYSnzFQU2Kzc/q2skc4z17cLSf9qYg607HnRRRE+Z6ZFqD0Mw5dmvnXbhSvrn/keJfJMGDNNPEcvsNSzJAV2IOZergzPt87Fuqir8+Pa3Q==;5:dwbir02HHuCJZlamKj+fb3h8sje25nZTkBLAzZB1lS1SNNXsKyMbU7OBn/DiReYzhvBPEyjT9dd6pyP4QcbUshP3LN8qJToBFYs8LGNfiFC4GmlwdyAy/si3vdHpgpGrkQyiLIb+Kx6HH8f98Naa1g==;24:/utSxdNHVQS+bDajeKX6k8RllNsnkmL1zTQ3yEXldgKysaQMV04GG49PMuhUFoXCJndHV5VhDzoN/Bz+zfbQ7Pz+co+CigHU6mYSi9K48zQ=;7:TP7grhQpYf5B/8s5WKxsAGOL6yEuqHPYvOXmeRvoJyhTrC5NMp6DQ3EqiIXBwSzpInEf/HqViFZcdz4foTURB3JoP7u5+0RgTANxBLcomhegV5gaODszzs0xWs9TtVgJEBfdVOqjvgnhVTtn4Y5ekydGWaRBUVje8XnEC3/VYY/Bs8m3Wr+F2TXF4WPfJaCAyW48qX62NCYmP/6lIacrC0UOFEk6CvzBoqtHrFFRsK0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2017 06:09:47.2895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2559 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-07-09 19:10, Jonathan Cameron wrote: > On Fri, 7 Jul 2017 11:26:35 +0200 > Peter Rosin wrote: > >> On 2017-07-07 06:57, Peter Rosin wrote: >>> On 2017-07-07 06:53, Gustavo A. R. Silva wrote: >>>> Check return values from call to devm_kzalloc() and devm_kmemup() >>> >>> If someone cares enough: s/devm_kmemup/evm_kmemdup/ >> >> Strange, there seems to be some inherent shortage of 'd' characters... >> >> Cheers, >> pea :-) >> >>> >>>> in order to prevent a NULL pointer dereference. >>>> >>>> This issue was detected using Coccinelle and the following semantic patch: >>>> >>>> @@ >>>> expression x; >>>> identifier fld; >>>> @@ >>>> >>>> * x = devm_kzalloc(...); >>>> ... when != x == NULL >>>> x->fld >>>> >>>> Cc: Peter Rosin >>>> Signed-off-by: Gustavo A. R. Silva >>> >>> Either way, >>> >>> Reviewed-by: Peter Rosin >>> >>> Thanks! >>> > The relevant patch adding the file in questions hasn't yet worked it's > way back to the iio tree so I can't apply this until it does. > > That is likely to be a few weeks away yet. Please give me a poke if > I seem to have forgotten it! Hi Jonathan! I saw a patch from Christophe JAILLET [1] and it seemed familiar so I did a bit of digging. Now, I did go back and check this a couple of weeks after you request, but iio-mux.c still wasn't in the iio tree, and then I did forgot about it. Sorry. But here's the poke... Cheers, Peter [1] https://lkml.org/lkml/2017/8/26/3