From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012050.outbound.protection.outlook.com [52.101.66.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82BCF2773F0; Wed, 4 Mar 2026 16:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.50 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772640227; cv=fail; b=B55QLyOkrh6beNHwhGETZxAp0u+t+cqvzbaxy99Az6iu7n7ncjsfXNs1W6tNQjbuOMyiJs+HwOWhC9jtHlmmbNtTn+Hm1hVVfP+O9Ey+nUft4rw3kCJDjVuEPWdiVAXXDSlDJRd2uCKA6v/FCbvVpJWJSbnNIwyKJ5v7Q5SvkLI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772640227; c=relaxed/simple; bh=EWxUdQRJjgkJtsTzSKahMXRd6c1vaFnlMGfDRDsWiME=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=N2s6Ouj9pXZcLTNIINgX7jvSJFYDcUilkyy4soJQhbs3uqJIz4dGawImT95+f7+16DTE4KdxuQvIdqXg0EHGOAKOIGF9hjsc05ewwQRR/7KV+X//cO9R4MnL1seTCEeoSEZBpgAW+yNr5s4mbEIZZaswWklnqlIwFq1RCKY1rBg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=fail (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=aQ0mCYaO reason="signature verification failed"; arc=fail smtp.client-ip=52.101.66.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="aQ0mCYaO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A1vnVnmm66mEJpEfgyR9/DoH73k6134WPc1estIuanyUknO4xgUro3/0lPMhZ7kaveDwZbb1cmb2scuVzQ4Hb4j1PcDdXMU0mNuTNZCKzi/Y/Ghp/pMNBynlDAhmFkx8tFv7Nd+Trw19aZdh6uHx7tG7iSWHoNdYylwAoNGHsHAGL40sNhV/dywf+UF0I+/4Y2TBDflwxLwDNaSY0+IIXwkpgyuZc4ck2n7YQ9rASjXHWOW6+eXxoL+GTwnAKrAS5TYZgqIbeOojqgQ3ONG4sj7Dv39B13hn3g/35XJ/fP6p2XBoic0ElFH+7KTlKJqo9zmm65KmcROvgQVf1P1l0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mcNieiVyyOhKy9ukLqxNq+mr1XP4+QDrgg20DGMFD1E=; b=Eg27Fw1QSN5g0/0GTWn+a9SZ0fMe4jrXeZ8pnl2SHvznTHsz1wuz7a8A7NfQDEKKwBOQwSr72JglFUovWeHHnMSfC7ji4oYBfWwG31xaG8o61YSnvSyxxqq/cEcR5LW9ujP1BCzmRtydxlg3CZu2iMNwnekgzqQqUJu3XkviF+Wzh9MrG6+wYna97FkKlvFbU+ktOHmeWIzhZaWIb8WxhhXcWS5rOM/PMnBSNuAlx2FDlYLvb7yWrOV3fdsRPEf2UoWKi1ErYmvFq/sTaSVTiq9L4bFVM1ljUPqFA2JSVOsUIaarkU6mx2TMvn1lj7XIJIEeTPbg05V3yHdk3tEkqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mcNieiVyyOhKy9ukLqxNq+mr1XP4+QDrgg20DGMFD1E=; b=aQ0mCYaOOmc31k7tb1C2Cessr0tZ/FfYXAk6G36sPcUIJ9vdgXx5lzFQ7a/rFSta0sSpJjz+wXop0VnPzc9zrUG3Do/jvZqKOY4qqNOhsGRiX+dV4ay+UMNTd1wHPHqvClOdLImauYnu9NVP/zqJySDyFy67va8hguafEIF4Rf8/glu554YRyQ7od9QVQccBcXtEvIxlg/Bck+w4yoEFuLM0fJUoJ3FCWGfkK+UoNT4JrE7ySYXl5Zwixz79x5ijB9+S05yRoUqtCXE88VPvn9CYGjPnJ/mHAvbmL2r4ZUhDHz80tgcUhvuxC6oJ1JUJJggl9sWiK3z5Wx56cGTgBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) by DU4PR04MB10498.eurprd04.prod.outlook.com (2603:10a6:10:56a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.17; Wed, 4 Mar 2026 16:03:44 +0000 Received: from PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588]) by PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588%6]) with mapi id 15.20.9654.020; Wed, 4 Mar 2026 16:03:43 +0000 Date: Wed, 4 Mar 2026 11:03:34 -0500 From: Frank Li To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Vinod Koul , Frank Li , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] dmaengine: ioatdma: make ioat_ktype const Message-ID: References: <20260302-sysfs-const-ioat-v1-0-1229ee1c83f3@weissschuh.net> <20260302-sysfs-const-ioat-v1-3-1229ee1c83f3@weissschuh.net> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260302-sysfs-const-ioat-v1-3-1229ee1c83f3@weissschuh.net> X-ClientProxiedBy: BYAPR05CA0097.namprd05.prod.outlook.com (2603:10b6:a03:e0::38) To PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR04MB9366:EE_|DU4PR04MB10498:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ac34e2d-af57-4e0a-a800-08de7a079c20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|52116014|376014|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: 0Mo1+Ighlo4GXC5RAMZn9F+SRjgwQn9lV0JuW7fIsux3eQA4KSlz/4bpbIY/x/Cf/rWCzJRAMqhOCXCNGzgRsRk5stc08CqPg35Fwp0q1K5yWDe6xgYLPqlihjj08hLc639BEJpn++pF9kOp0l6pxGQTwYEDaT2kIt+CSm1a/HAiS6kX4eGtmJjnkGFMFJBNNYCed/vQiBv+Gh4va0viPhS0Fn20+LxCf+Ci5+qLaqbiY31FeNvdqUJ2AKKKBsc3NFwjLoQNpkKjnOLIoQ4lViJJMgbIyRIo9XFkcfmzlnzzNdOVTDEO8ngw+S+9MpcXDt8lOY+lyWU04ajmLfJMKjHaHJcd0QVtgfCMJ+Wy4whFD68KU9Z2chNU3u+kf7CDjryprDSU0UVAehKaz1z0JfWcbcb6z0KQ35QJMj9WMevgx/lM40j2OY40p3SGqR8uLfRRDjvJZn0jzrmUYmuqIY9ii6W6hYn1veTcjhHJ6Y1byRpBHJ/Z7BsrdGiornoQ7+3jz5XY49KAY+4jQWnro+VoWkzzXlIdKMJ6TG+S8ziuOU10Qx0UhQPDz1AmNQuRi6L2ivt7YNOc0mxRRwHuxH0usWr3H2iI162bsdcBgEXYg2m50KSqgnHAobQjVps64j0qkQYXpRZ1+FDR532LDrsiwOIgJmNybTk81V1cBgKFJRd7mRY3SrwGe+dNNtk3shRa9Z5rlzxUNndihjXb2mMRwwjArsTqXoWeEtagamKlLY/hXLedCCBFiGvWaHvjjuQDC7+/7BPqaE/JzoMAYGHrxW1L1QrB+0y74VKgClc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB9366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(52116014)(376014)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?LqNxU/726VT4bW57z/ItjePRbqPHp44gf9e4uGT9Q9faOA3nmBitTx9hsP?= =?iso-8859-1?Q?P4PtQnJSM18PfkDpKXTh84rcM0xeA6RAIbzWIjYDxxsa6cwZe0L55HvBGN?= =?iso-8859-1?Q?K1Ese7rr0Ceryqm8Yjj0mFsY9V7Tse6UZOLQAn05+KUpppRt3cR1FXdzeU?= =?iso-8859-1?Q?rxwI8KXhUAGHSK9k2O6T0o/WVH72Jkjpl0aQdfLppcvPhKGDycyfui+uQV?= =?iso-8859-1?Q?BOZViZuOllwHPzVEwaPtwxZefDd62DlkcE+HRrOwV5+YfjCWped7xgYoY+?= =?iso-8859-1?Q?IjZ+Slxvjk+Y/C5/YRX73MNw4kf1gde34QsGVQcPO1tjuN3Dww2VMg7DTS?= =?iso-8859-1?Q?cTpWwtq/Kutoq8cs5pL0o6pjIyvBGMdVhuFfrNcpLIxwiRtRZk+PAHalFg?= =?iso-8859-1?Q?Lc9kBQIcozXB9WwT6bub3w1Sr2+WhyFNU1snNUC+WDVDgpbJapKRcxdGZi?= =?iso-8859-1?Q?A7koRrq99pn7FkFi0po1ZbQoGm1Pug1qq42D3SqCGFr6gSNd6OcOe8ia1D?= =?iso-8859-1?Q?2I3PjYQBhlfwIJDoC03qE9zowCayzUNAiQILPy7FaH8br/XHeGV+B7mBBo?= =?iso-8859-1?Q?VpT8hZrLUBkuCHq/PiRPuYL0/LXk28crFsZo+4z8HK8Bg65HEERP2Clt3/?= =?iso-8859-1?Q?IDBWyliYQHCqKAW5z/ynYFz7VldUUFs/DaTkNo3/dQx04CpeMwl8V8lTmh?= =?iso-8859-1?Q?/rIlYx8XN+Rr1W5//8oc5Y9LekqTpL9u4ihfsNmepMFnLPkl0C5BmoWZGn?= =?iso-8859-1?Q?bXE0Ku4grr81QnTJct2LVgdAr8a1WXWefodZBQUPWjf8NbtJFOLMam21mI?= =?iso-8859-1?Q?ikgAIPleo9qdaYNpv5QeAi/8P/zs5iqh+pfNq9PCoTHkJ/WtsI+OgYneI1?= =?iso-8859-1?Q?y9hSKiQKHr3kmYWpxlxZtu8MXl2Db/XOzrz25ymr3PWOs9CB8Z1riaeGui?= =?iso-8859-1?Q?UBnPBmSmig2ENWXzSAW1vRnQ+bDS/us65R0kGqpgSFyRM9AXCSVdhYK5Jf?= =?iso-8859-1?Q?yqOjaw69JkZnyNCoNFQIM/CNC0109lnEC0Y2w8VIcbuspH4t/G2AtgpDPQ?= =?iso-8859-1?Q?eOFB89nsGg/Zu1ZDZWh+cyAUP1pcqn8tycSK+SUaIiuFy9V0XNiOuy8tVT?= =?iso-8859-1?Q?5o1+k8zRuJccnwOq7sfiBIeMDDBbRF65UokvbXSO0EMXzTjxTpAuBNzu4P?= =?iso-8859-1?Q?hRWnQUWjoVX/yXTbVVVzn1WPsP7f4yMHtu/k5bfn63kCmqaPVhwiRA97+r?= =?iso-8859-1?Q?umYi/aDi5awWet9dAvP+9X94V4eiJOFMHJZJ0o2zS0uZcscG3wV7zqQirD?= =?iso-8859-1?Q?0D7psdhbkN1FGkdsj1avxu5wsMut+Op8TJQ9t3xe3CSyrnNoI0faYEhM7N?= =?iso-8859-1?Q?eRFEx255pKug2H6f8v2XhPSbegyzB5plmx95SQiTswA5yPNxvLTt6IcaTm?= =?iso-8859-1?Q?pWndUA4Anp86es/gNWaINXcm0Txi6e+rmP3rg7Q2T6x7sHF7yt9/L3OVnM?= =?iso-8859-1?Q?YFraU06XtnF8qPhAgDHnCbjmZSizL0lZ9HSgyVQghhnAOTq4Ks3eWQFOeD?= =?iso-8859-1?Q?98r7YqslTkmMQ3vVdXyN/vcJsf6nsn0G9JQz5wiHz0BxZCMJfFpo4EJTsy?= =?iso-8859-1?Q?V3NHCqdBWSx9LZOOb01WRgOk8ZverA39wd+NW+6lZRzOUnrtBMqIyBGyIT?= =?iso-8859-1?Q?FcRIddYkIebIfrRH7Qmdv4EMLqOU8PgytOxzIhIrxxZMo1LDX7aFOY4fJv?= =?iso-8859-1?Q?ZVb9L3S1cKIF+99ozGeXiuZbewcNLs0K96S0GDWnUbnxBXL7IdcUH48bVr?= =?iso-8859-1?Q?DJuEikX1UQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ac34e2d-af57-4e0a-a800-08de7a079c20 X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2026 16:03:43.8055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7YOGijwFwMD5CpJYPOsnQP5jRxFeBDwOOIwUHYMQbhU5Ho1wNXHYjESdI7GiJwXxwEwy53h/YQwa+f+4ZHo+wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB10498 On Mon, Mar 02, 2026 at 11:15:55PM +0100, Thomas Weißschuh wrote: > This structure is never modified, mark is as read-only. ioat_ktype is never modified, so make it const. Frank > > Signed-off-by: Thomas Weißschuh > --- > drivers/dma/ioat/dma.h | 4 ++-- > drivers/dma/ioat/sysfs.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/ioat/dma.h b/drivers/dma/ioat/dma.h > index e187f3a7e968..e8a880f338c6 100644 > --- a/drivers/dma/ioat/dma.h > +++ b/drivers/dma/ioat/dma.h > @@ -190,7 +190,7 @@ struct ioat_ring_ent { > }; > > extern int ioat_pending_level; > -extern struct kobj_type ioat_ktype; > +extern const struct kobj_type ioat_ktype; > extern struct kmem_cache *ioat_cache; > extern struct kmem_cache *ioat_sed_cache; > > @@ -393,7 +393,7 @@ void ioat_issue_pending(struct dma_chan *chan); > /* IOAT Init functions */ > bool is_bwd_ioat(struct pci_dev *pdev); > struct dca_provider *ioat_dca_init(struct pci_dev *pdev, void __iomem *iobase); > -void ioat_kobject_add(struct ioatdma_device *ioat_dma, struct kobj_type *type); > +void ioat_kobject_add(struct ioatdma_device *ioat_dma, const struct kobj_type *type); > void ioat_kobject_del(struct ioatdma_device *ioat_dma); > int ioat_dma_setup_interrupts(struct ioatdma_device *ioat_dma); > void ioat_stop(struct ioatdma_chan *ioat_chan); > diff --git a/drivers/dma/ioat/sysfs.c b/drivers/dma/ioat/sysfs.c > index 709d672bae51..da616365fef5 100644 > --- a/drivers/dma/ioat/sysfs.c > +++ b/drivers/dma/ioat/sysfs.c > @@ -78,7 +78,7 @@ static const struct sysfs_ops ioat_sysfs_ops = { > .store = ioat_attr_store, > }; > > -void ioat_kobject_add(struct ioatdma_device *ioat_dma, struct kobj_type *type) > +void ioat_kobject_add(struct ioatdma_device *ioat_dma, const struct kobj_type *type) > { > struct dma_device *dma = &ioat_dma->dma_dev; > struct dma_chan *c; > @@ -166,7 +166,7 @@ static struct attribute *ioat_attrs[] = { > }; > ATTRIBUTE_GROUPS(ioat); > > -struct kobj_type ioat_ktype = { > +const struct kobj_type ioat_ktype = { > .sysfs_ops = &ioat_sysfs_ops, > .default_groups = ioat_groups, > }; > > -- > 2.53.0 >