From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD4ED3CCA0A for ; Wed, 4 Mar 2026 19:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650962; cv=none; b=LF1LoKlwHZoP9dvUDcqVp+LSqv47x8xF6Pq6ijKUrvvWzUnWRxUwAgIGECB9dtiOkKRuev1cMIs2r/U4w3CoafwIUactm7iw49FDreHe+5YxXQLWlDTg0cV2jNMrJ2NbbLpnJkT4eCU6pxfhKExO8JV56QpmlMGCLmF5HoZ6h3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650962; c=relaxed/simple; bh=vr921QcGtFzVFWMBa2ciMyksUfCqCnRpo0Vb09A4Vu0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eZKXmoy3dsSVhet9u3+3XdvcNbiPNmMB2mZSeE4Pvr/FGnAHe2lZuYzqTAbCVmmoaU3a01iiwojJ8SadZC4pRGFD1ijt0G+sMyZ0quuM7jw+ikG3OmwvSrecnNutM4BlYMulT6RIvHd638wDiv3FizCBMut/jkKS80wW4ktZV/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kdbduWmA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TzM7YlLn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kdbduWmA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TzM7YlLn" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 624E0ZI7029349 for ; Wed, 4 Mar 2026 19:02:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=m3ID+Rt3thScCZWKCweYCrtA tGByTHZygFo61zkltu0=; b=kdbduWmAuOxgRJDnWHrdmZx794TiSXGoPs0P835a UMhWh3w9ExHrKJeno627eEYKhycPJQuEWxv+WeQMflCAKS29mFtKPfc9B3UZFkHd OdIBMrpmBn/Lkm7FWLFyH56RcYiS7X7a/CB4XXwZCi7xpwgCL/QRqWs3bpm/J9wc aETs6Mcq/4ycqyxL0GOK915RX8Cq6fBRdtU4x526NEnNL6tW0KUm7z8kFHkVYAEi vwFbJtZn8H2TD6IzTJYKCCNYmyf5T7XJ+azBvJiJY6+Echrw1NCNt6D3K1W0r04x MGKGz+K+plTRLHayID98c8ZeQETBPmNQJ0xQmWoIPK/RRg== Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpp4fh1u0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 19:02:39 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-56a89808d23so43323338e0c.1 for ; Wed, 04 Mar 2026 11:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772650959; x=1773255759; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m3ID+Rt3thScCZWKCweYCrtAtGByTHZygFo61zkltu0=; b=TzM7YlLnX2045z5gOKFg3FwOjKoPtk0isdEV0z8suUwdRkBTN7KE+neivqBjCKjQOJ F4FcO7UU3eB7idtUeTCs5u+4fXoan41LBHA+ZTxzFHqa6d2dZR1i6s9bssBQEDZP417u oijViTqYaU1A0CzcSz1yl1EVoLN8SCFruU33YtDxWljLilaQMgZ7WKeOLivNU9fsjjtH bB326pSvPCrdxhJFcmcyQkMvXZAG5UBezUca2uPYUC78acovVmW4TxgrHYXXpuxGAViK 0zPuP3MqPKeIJ8E8WyWO0CrFJkMBQNm16HqFkx7PxOsM8pDPLwm0zSZmJil5OTc0qSZw BA+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650959; x=1773255759; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m3ID+Rt3thScCZWKCweYCrtAtGByTHZygFo61zkltu0=; b=rC+eRzidrOBDf7Vm+5xVqWUefaaU3tgm5uh6XY6ErXctMJatowD97cceItpxg25ZaW q6GQdf1rqUNlkQNk9ML4ayAS8NDtrgfjlfsSzh0kuFLaUZIcNxKVJf6XcY31fhOSEM1s KsQQEO3volG5WLXDxBiCP2LqiQLJPZkbbWxPB8m912N26W0LxayOaQOi2QiBWJcATFOw sC8gov0VHqqgxdc1OF4JjWUYiFpamNU8Ma9Md+PNn54+UEPrmk12uHCtHs/tv3kH4IVJ eII6J9tzSfONi4GQQA8E7te4rUln3z8Q9XYSUsvpJr+Zam0ar0eLVT/Dkam0lD0ZJT12 OVMw== X-Forwarded-Encrypted: i=1; AJvYcCUjRgIHx41hwkXIxqJYgkY3m/VZ/Y/pO8eZpngjo5gt72yl5Mygo012dVknm8tdM86XgYcCSAz5Pb2Ma1k=@vger.kernel.org X-Gm-Message-State: AOJu0YwUCMlKQChs6ZlpY6H5X3M3QpXXlU6zMsWwNOsK9hLQwYt5vszR inkcXvuxL9D+UK5Tx1RLcfJ2kS9pOAX0tI48FQ9xRrrIYCjuGPaABeBokdjyGdtYyv9sob37Xan n56j6B2SFFQoyW7XpDIP8t9yvlREvBFhJxoHP8HtUD746BTD146P5SBN+OVcu3Zz4xcA= X-Gm-Gg: ATEYQzy4VigHBGcMKzhLTPqpO9Vpz4JUshsLbevDkGdgYtkd3hG4bghCDCjbblV3ofw 28M6CoHk8SDO5fQqCep5GbhTxkzEjdchaz5BTg6lKFlrkBNN7GINa3US2xqVoLa4i8889zTbqgX yFF5XXl33rtA3K4CPXu6ii5KSw01Gb2SYfQGxysuBmW84tSnMtZyhw/hETuHAEFvqAp7G4D0TsA eeKHrqakcGqWmLozK2fxUY92U1RIxNF0BslnTFOCjxXSgIlT3WxGvIEZZPwskWgQfQoDTlqWzeP hVLeiIptO4JYz3Qn6HFPL8vqOF0KoNeNLASVZp1+potzSWfBsU+NGG0Wo6BGJWJWwDXpiyY/C12 mIzU5jt+KFMOuUoaxzRyaF+LpjhdE X-Received: by 2002:a05:6122:3d03:b0:567:638a:ce16 with SMTP id 71dfb90a1353d-56ae77c396bmr1558846e0c.14.1772650958811; Wed, 04 Mar 2026 11:02:38 -0800 (PST) X-Received: by 2002:a05:6122:3d03:b0:567:638a:ce16 with SMTP id 71dfb90a1353d-56ae77c396bmr1558806e0c.14.1772650958386; Wed, 04 Mar 2026 11:02:38 -0800 (PST) Received: from mai.linaro.org ([2a05:6e02:1041:c10:ee0b:246c:2dae:77b9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851a8a9542sm39209755e9.1.2026.03.04.11.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 11:02:36 -0800 (PST) Date: Wed, 4 Mar 2026 20:02:34 +0100 From: Daniel Lezcano To: Zhipeng Wang Cc: daniel.lezcano@linaro.org, tglx@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chun-hung.wu@mediatek.com, walter.chang@mediatek.com, jstultz@google.com, amergnat@baylibre.com, aisheng.dong@nxp.com, jindong.yue@nxp.com, xuegang.liu@nxp.com Subject: Re: [PATCH v4 3/4] clocksource/drivers/timer-mediatek: Convert timer-mediatek to a loadable module Message-ID: References: <20260304081207.4030882-1-zhipeng.wang_1@nxp.com> <20260304081207.4030882-4-zhipeng.wang_1@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304081207.4030882-4-zhipeng.wang_1@nxp.com> X-Proofpoint-ORIG-GUID: voXXV4SQdSKA11Gy9e_hlj1vWf-puQ56 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDE1NSBTYWx0ZWRfX+ZmAdIyqW8OR ZW9vmlpx3KzPLSYlf4BzaG4y4jgCrMyz4Hk8VolYZ+AhzaGOywhDc7yMP9o2F/BTLJJ1x3vqTMm rbCYIQGVW+rXsE1SJcqtADOiv1IdFbbUbKNG/BLXzsKt+n2X+reef8/c7FQkwcBIxCxBoWvEgiP ohBNZYo4RJmkvnpbSmRunx0y3B/p34sYFtLt/nMRa+yxDEKuKeokTTu77AJYckQ8xF7sV2ZTxFv a7BZmOy/JVH2nnQzcfq0IY1KnBLJlJ8mbwqC0q+X4ErII3qfkYEa6BydX8uU9xCxGWAIUI4Wm75 UZG0Lv/PYlEtll4QRFSQSfb9dIU3gkun4f1nkj48If2Y17mnw+C9ub8xNtVs6RYBzcnpBT9l2YG ka4wYsR9tu33ZB9DBHX33Lbx4V5niJQsjxdUFvAihA2Ff5I1179GeIXRPrx+iivD6SWMS0v4SCu 1GBbKmhU26x72/dWlPg== X-Authority-Analysis: v=2.4 cv=CdMFJbrl c=1 sm=1 tr=0 ts=69a881cf cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=mpaa-ttXAAAA:8 a=QX4gbG5DAAAA:8 a=IpJZQVW2AAAA:8 a=8AirrxEcAAAA:8 a=4XJdlQNtnODeGaihWlIA:9 a=CjuIK1q_8ugA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 a=cvBusfyB2V15izCimMoJ:22 a=AbAUZ8qAyYyZVLSsDulk:22 a=IawgGOuG5U0WyFbmm1f5:22 a=ST-jHhOKWsTCqRlWije3:22 X-Proofpoint-GUID: voXXV4SQdSKA11Gy9e_hlj1vWf-puQ56 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_07,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1011 adultscore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040155 On Wed, Mar 04, 2026 at 05:12:06PM +0900, Zhipeng Wang wrote: > From: Chun-Hung Wu > > Convert the timer-mediatek driver into a loadable module so that it > can register an always-on timer as the tick_broadcast_device on > MediaTek SoCs. This helps support GKI(Generic Kernel Image) modular > configurations. > > Signed-off-by: Chun-Hung Wu > Signed-off-by: Walter Chang > Tested-by: Walter Chang > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: Alexandre Mergnat > Signed-off-by: Zhipeng Wang > --- > drivers/clocksource/Kconfig | 2 +- > drivers/clocksource/timer-mediatek.c | 33 ++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index fd9112706545..2112efb85029 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -488,7 +488,7 @@ config SYS_SUPPORTS_SH_CMT > bool > > config MTK_TIMER > - bool "Mediatek timer driver" if COMPILE_TEST > + tristate "MediaTek timer driver" > depends on HAS_IOMEM > select TIMER_OF > select CLKSRC_MMIO > diff --git a/drivers/clocksource/timer-mediatek.c b/drivers/clocksource/timer-mediatek.c > index 7bcb4a3f26fb..4ad4bac6f34b 100644 > --- a/drivers/clocksource/timer-mediatek.c > +++ b/drivers/clocksource/timer-mediatek.c > @@ -13,6 +13,9 @@ > #include > #include > #include > +#include > +#include > +#include > #include > #include > #include "timer-of.h" > @@ -337,5 +340,35 @@ static int __init mtk_gpt_init(struct device_node *node) > > return 0; > } > + > +#ifndef MODULE > TIMER_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_gpt_init); > TIMER_OF_DECLARE(mtk_mt6765, "mediatek,mt6765-timer", mtk_syst_init); > +#else > +static int mtk_timer_probe(struct platform_device *pdev) > +{ > + int (*timer_init)(struct device_node *node); > + struct device_node *np = pdev->dev.of_node; > + > + timer_init = of_device_get_match_data(&pdev->dev); > + return timer_init(np); > +} > + > +static const struct of_device_id mtk_timer_match_table[] = { > + { .compatible = "mediatek,mt6577-timer", .data = mtk_gpt_init }, > + { .compatible = "mediatek,mt6765-timer", .data = mtk_syst_init }, > + { /* sentinel */ } > +}; > + > +static struct platform_driver mtk_timer_driver = { > + .probe = mtk_timer_probe, > + .driver = { > + .name = "mediatek-timer", > + .of_match_table = mtk_timer_match_table, > + }, > +}; > +module_platform_driver(mtk_timer_driver); > + > +MODULE_DESCRIPTION("MediaTek Timer driver"); > +MODULE_LICENSE("GPL"); > +#endif What do you think about the approach found here: https://lore.kernel.org/all/20250625085715.889837-1-daniel.lezcano@linaro.org/ > -- > 2.34.1 > --