From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] media: i2c: mt9m114: add support for Aptina MI1040
Date: Wed, 4 Mar 2026 23:44:01 +0200 [thread overview]
Message-ID: <aainoYv6RXkXFcHv@kekkonen.localdomain> (raw)
In-Reply-To: <20260304185001.82988-3-clamor95@gmail.com>
Hi Svyatoslav,
One more thing...
On Wed, Mar 04, 2026 at 08:50:01PM +0200, Svyatoslav Ryhel wrote:
> @@ -2646,9 +2658,18 @@ static void mt9m114_remove(struct i2c_client *client)
> pm_runtime_set_suspended(dev);
> }
>
> +static const struct mt9m114_model_info mt9m114_models_default = {
> + .state_standby_polling = true,
> +};
> +
> +static const struct mt9m114_model_info mt9m114_models_aptina = {
> + .state_standby_polling = false,
> +};
> +
> static const struct of_device_id mt9m114_of_ids[] = {
> - { .compatible = "onnn,mt9m114" },
> - { /* sentinel */ },
> + { .compatible = "onnn,mt9m114", .data = &mt9m114_models_default },
> + { .compatible = "aptina,mi1040", .data = &mt9m114_models_aptina },
> + { /* sentinel */ }
The driver also supports ACPI. mt9m114_models_default needs to be added to
the ACPI data, too; otherwise ACPI support breaks.
> };
> MODULE_DEVICE_TABLE(of, mt9m114_of_ids);
>
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2026-03-04 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:49 [PATCH v3 0/2] " Svyatoslav Ryhel
2026-03-04 18:50 ` [PATCH v3 1/2] dt-bindings: media: mt9m114: document MI1040 sensor Svyatoslav Ryhel
2026-03-04 18:50 ` [PATCH v3 2/2] media: i2c: mt9m114: add support for Aptina MI1040 Svyatoslav Ryhel
2026-03-04 21:44 ` Sakari Ailus [this message]
2026-03-05 8:36 ` Svyatoslav Ryhel
2026-03-05 10:00 ` Sakari Ailus
2026-03-05 10:13 ` Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aainoYv6RXkXFcHv@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®