From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC73B1862 for ; Thu, 5 Mar 2026 00:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772669758; cv=none; b=Lrv5f9AKeZGwBh+4YRry5TMg6YC9EtEfrUnf1uHIQzPqwByTBXbe1k5zX0opalRZCIy16kCwakQSzeX1iFMms/HcBEGbLbteHAbWE4P06bIRA3K6VwQa9V0aX3vpoGhI8ujBNxn2vCTy9IHcikb3aULtnjf+J9wJzooYdvzbjYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772669758; c=relaxed/simple; bh=4mR/9KpKWoTBbNEf/LhaL2JbInadCOam1v9oY17Zitw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G2RvBCu13mw4rcR4VaVcGl2+fHYImKs6nKpN5ybfN8kfYMWwduBZQ4/NtkyS2rIrnx3+fNOuxdO4M9JVOcw9LB3LJ0cEtlchkj+75fTAxOT/vcV7qE88c6pS6PerhjXKkQ7FEVZbrLXSw8fjI6c1XYkqiBBAD5dENXyCBHWR2ZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J5YJ/04Z; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J5YJ/04Z" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-8cb3e0093e3so714784985a.0 for ; Wed, 04 Mar 2026 16:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772669755; x=1773274555; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=g0JXk9p5V1fGz1+f2197Ws9DW9uXumXoOAEt9xBTer0=; b=J5YJ/04ZV0DVUt7NtuoiFsjDd58ejJZ6SIYDsX9PAVxaUL31KvT+9lGEbu2/dKzuzz NjaUqO+HlMqZ/TjCmBvQN+wmvXjkLtM7FUKeGOvc8zQ9avlRVOujsroiL96jOME2+cjl qvyQf2MiL5M6saUpkhnAjPF98k05zZ2ERO0ryxdXjqsoOLE2vKs4gVyu+AfN/ztxy7IC nDZMIcMLSoiyAZQbhGBiUuywsjTRxWW0xr2QwPoUCHiwuTMcUIkPojtcwS9WKkORm8j5 VwITGrNqZstle9yvLncG2mISQ4gFPmsMyCye21UoRM1LgjlPl7yyAwar8iS8Ia4xV64b iI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772669755; x=1773274555; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g0JXk9p5V1fGz1+f2197Ws9DW9uXumXoOAEt9xBTer0=; b=CnwX4nmZHwiuYWPjN+pxgSrywlRko1OndnpgX9q/0mDp5PoKVlzPZRzmlWk3HK0zWv OP6/PgmY2Sks+KkDs8fKLsCgB2yNsDlHwgImwmQYOcrVMaJaabh9rJz96TIq6/uEOtdh 7KSxrXHu4UWNnuiXQr/OIVSr0568RwHv7JT1f7M3+t/PcuPYQOVzGqC39udBZ/tEkzmd DtVCOTS7BmeSv8Ub9YGS1yKK1SEhaMddqNSz76j2Xt0BHnAFIp/HfmzBP/aeFXrxR2T9 M4yDCvYIzXskZdtgqBsbaf2svFAeX+/Qc9GCUg9EbA+uRgATmhl5wPYMzd3HUNBwXl7I pxlw== X-Forwarded-Encrypted: i=1; AJvYcCXgeTH4nB2eplWcrQMYsfcsIeVovOk+dtHPsMHHncrIAge6lxDv2k0gm7cY80ShTOhh1blnJO5dNq9pbw8=@vger.kernel.org X-Gm-Message-State: AOJu0YyQib8ARXxl00sDLkfFFmJA+OIt2VmXomu3SdMOFDb7ALiYidxv 8038aJW2sPXGSFaVW0yvb58Ty8IIK2SN9fmZWxcL1YUmL/NbmDoJnGXh X-Gm-Gg: ATEYQzz2Qt3e9FVX/yviuXh/uAZBVcjlmOw9bGEgIIf4O730TtGhBJJoi0LYKATODSq VayXpQY6zZzmcEqatieFXxe3boWtGlviuWPZgafUeG3X1Nk1fyAZlzB/W9OLqJEkmCUe+1HLpIa ta6ZGngoJpIk8xO6abbggR4PZkIxx2mM7fs/3mJFiCr+G6pjv7UY4IvtEcmLbMyoK8DgWTAnvfm 2h+2u357k0pnEk1YkM7XXK1xGhEItDxokCbQgLhQwF+o3k0UK5XT4mMjevnsJwxVU3xiFdy/vYC fmRwKMw9IDgoxhH06yVRQ8IZx7x012rXkQ3kncoLXEAW1mJnhwyBIXNGMxFSr5bYFGd+2eIgh5f RpEtXLR8Xf372besEeutci/+pKpsa/vpKDftfOmWrcBMnPC/rOhoDVfF5T8AA30lGcgzIRiAXnE +rrDsDEPxE7RcTRsTgnvuXmdgIKSM= X-Received: by 2002:a05:620a:4405:b0:8c7:fdc:e872 with SMTP id af79cd13be357-8cd5aef1d4fmr466089985a.19.1772669754629; Wed, 04 Mar 2026 16:15:54 -0800 (PST) Received: from c67c70be8272 ([134.128.219.200]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf7319bdsm1775385585a.43.2026.03.04.16.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 16:15:54 -0800 (PST) Date: Thu, 5 Mar 2026 00:15:51 +0000 From: Yuanshen Cao To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Ulf Hansson , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/2] pmdomain: sunxi: Add support for A733 to Allwinner PCK600 driver Message-ID: References: <20260304-b4-pck600-a733-v1-0-2f54efdb8cc2@gmail.com> <20260304-b4-pck600-a733-v1-2-2f54efdb8cc2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Mar 04, 2026 at 10:33:23PM +0900, Chen-Yu Tsai wrote: > On Wed, Mar 4, 2026 at 12:44 PM Yuanshen Cao wrote: > > > > The Allwinner A733 PCK600, similar to A523 PCK600, is likely a > > customized version of ARM PCK-600 power controller. It shares > > the same BSP driver with A523. According to the BSP provided > > by Radxa, unlike A523, it doesn't require reset. > > > > Make reset optional in the sunxi pck600 driver and add support > > for A733. > > > > Signed-off-by: Yuanshen Cao > > --- > > drivers/pmdomain/sunxi/sun55i-pck600.c | 53 ++++++++++++++++++++++++++++++---- > > 1 file changed, 48 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunxi/sun55i-pck600.c > > index c7ab51514531..8f9fdc3915bd 100644 > > --- a/drivers/pmdomain/sunxi/sun55i-pck600.c > > +++ b/drivers/pmdomain/sunxi/sun55i-pck600.c > > @@ -52,6 +52,7 @@ struct sunxi_pck600_desc { > > u32 logic_power_switch0_delay; > > u32 logic_power_switch1_delay; > > u32 off2on_delay; > > + bool has_rst_clk; > > }; > > > > struct sunxi_pck600_pd { > > @@ -151,9 +152,11 @@ static int sunxi_pck600_probe(struct platform_device *pdev) > > if (IS_ERR(base)) > > return PTR_ERR(base); > > > > - rst = devm_reset_control_get_exclusive_released(dev, NULL); > > - if (IS_ERR(rst)) > > - return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); > > + if (desc->has_rst_clk) { > > + rst = devm_reset_control_get_exclusive_released(dev, NULL); > > + if (IS_ERR(rst)) > > + return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); > > + } > > > > clk = devm_clk_get_enabled(dev, NULL); > > if (IS_ERR(clk)) > > @@ -193,7 +196,14 @@ static int sunxi_pck600_probe(struct platform_device *pdev) > > } > > > > static const char * const sun55i_a523_pck600_pd_names[] = { > > - "VE", "GPU", "VI", "VO0", "VO1", "DE", "NAND", "PCIE" > > + "VE", > > + "GPU", > > + "VI", > > + "VO0", > > + "VO1", > > + "DE", > > + "NAND", > > + "PCIE", > > No need to change this part. > Yes, I agree. But since A733 has more pd_names, that line will be too long if we stick with one line. And we also used this format in sun20i-ppu. It might make more sense if we align with ppu. Please let me know what you think. Thanks! > > }; > > > > static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = { > > @@ -206,7 +216,36 @@ static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = { > > .device_ctrl1_delay = 0xffff, > > .logic_power_switch0_delay = 0x8080808, > > .logic_power_switch1_delay = 0x808, > > - .off2on_delay = 0x8 > > + .off2on_delay = 0x8, > > + .has_rst_clk = true, > > +}; > > + > > +static const char * const sun60i_a733_pck600_pd_names[] = { > > + "VI", > > + "DE_SYS", > > + "VE_DEC", > > + "VE_ENC", > > + "NPU", > > + "GPU_TOP", > > + "GPU_CORE", > > + "PCIE", > > + "USB2", > > + "VO", > > + "VO1", > > +}; > > + > > +static const struct sunxi_pck600_desc sun60i_a733_pck600_desc = { > > + .pd_names = sun60i_a733_pck600_pd_names, > > + .num_domains = ARRAY_SIZE(sun60i_a733_pck600_pd_names), > > + .logic_power_switch0_delay_offset = 0xc00, > > + .logic_power_switch1_delay_offset = 0xc04, > > + .off2on_delay_offset = 0xc10, > > + .device_ctrl0_delay = 0x1f1f1f, > > + .device_ctrl1_delay = 0x1f1f, > > + .logic_power_switch0_delay = 0x8080808, > > + .logic_power_switch1_delay = 0x808, > > + .off2on_delay = 0x8, > > + .has_rst_clk = false, > > }; > > > > static const struct of_device_id sunxi_pck600_of_match[] = { > > @@ -214,6 +253,10 @@ static const struct of_device_id sunxi_pck600_of_match[] = { > > .compatible = "allwinner,sun55i-a523-pck-600", > > .data = &sun55i_a523_pck600_desc, > > }, > > + { > > + .compatible = "allwinner,sun60i-a733-pck-600", > > + .data = &sun60i_a733_pck600_desc, > > + }, > > {} > > }; > > MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match); > > > > -- > > 2.53.0 > >