From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37856366554 for ; Thu, 5 Mar 2026 08:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772698076; cv=none; b=roaFDZrR+LCnrxSm+A/8H/csVQc1gdKDjBo3Zhb2XUfFcSE8XxXum+ROUzIwaQdBXjSaUJ4KxH6cM1tgnLtmDbkXsgvHqoD2H8oUs8oLuc2Hs9qzXmrQjzZrOL2ol4jql6VPlt6DiXNXR4kIJOppUxf9xmj1HQWFn3A3CufQU3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772698076; c=relaxed/simple; bh=MEN4t6jJ7e2OHmB5U6p2JOmY/bDl8ADWl53m94Mp7pQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T5ko/c4HVGKx0D4e3dl+iZpyiRG3dWose+bt9HAiLH75WvUxgT/4RPASxTMe7XJUhSxyKPuX3EsljPqi8pf96tFQTaQHbqc/i8ic/nrMBRhhdZZjmSZoVcggmFhOo1irrcufqm4M7wD2tJ2u0P4DcJSXpeY9ZB1qC9k7XFhFcRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FBFIGZK2; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FBFIGZK2" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-4837907f535so69680425e9.3 for ; Thu, 05 Mar 2026 00:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772698071; x=1773302871; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CpywyGgnXVMi7zDh09DftParmGasnoIPMVnYCXsoHgQ=; b=FBFIGZK2x1OeUWLoN1qkhIq8jwUAY6eCl/rfkyGLdXK84xPhKM7gpg1DAclyHxvyyc xlel7yXiG2XjrWDnChgFm+jQeprD7CLMZsrUd2zbuEjXhD8vkAxsjYXj7KACyI72Podz vCfzflPbp9THVAfNwUvoOffFtfPe0+HE8QvF9sJY/i1xddZHvdcZfz5ca3PUsk6a1FQs kv3Bz7VQigI8fChJConCqagigXEMgBpebkl70aifnmzkl07dU1qvXcWOX/ERdyu8H6NW hXMdpYVI2oL0sJcgEZbzADB+9II/+wwu24Tsypvzb+EYTMqxSDK8FU956/moudaIitpa vFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772698071; x=1773302871; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CpywyGgnXVMi7zDh09DftParmGasnoIPMVnYCXsoHgQ=; b=hkh9B/6hcEhbFHa2Rdz+HWE066a2G8+Vhk6AHZZj0cDcGoQ/L4nUgH8+DDU82ArBEJ CniQ7lkyK7nIaZX18/QTW6Vd7xhqY/Mcho8iK3X1OB04tXioXYlvBVvyV2MKuRRvTSi6 eFqqAhU1P+Xgr60zI5uqs6HI2mRsZxSasdrjrMWBEOVmeiJSed3M3qipq3TiJu61Lk97 qkrq/HaZgQtaR8fuT2lu+nlFppCh4hBltZrAk6qp3nnUA9ZwO8rAaD8ht7VMZgqfE0Cv zlUF88Ymnghmc3/YZbnLIDbz3+4uFq3esmraCLPUNbsgn96BHp6bgDrxZxc3rAgg73H4 uLWg== X-Forwarded-Encrypted: i=1; AJvYcCW5zXRNVOmjAJAyc7hVajGzxrC7snRaWY9Zt5TgVjAHYwvJDExlUEej3UyCpgX4poNw6B3kw5MRXNTodzc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1hm+KtXSBw/xugNzYRs9cFCCxAO1BN9yF+GwhO2HbcZMfmZzC k+zFoBRbUk4bHiUXFSbS++1DK45GHMbMmqI6wsQsno+1frV1f2sawFIYsBs87U60Xck= X-Gm-Gg: ATEYQzz4yE5xnM6OU9V+OuI2XnVx8/EaBpoH3fqkTzfHTc+1cTn5umHBT/FiV5K4gOE fmpYKZhYRjbB0Ks29T4qShrc5O3JbshFP3s1oXMGQG39XNyXXXIQWW///taABqb9rIjQ1bZWVJ9 eihqLc1asbOruH03/xaBsDIg+k2AL0cL+vao892Q5o08mqxm/3vD1Ky8TeNA8WLzO8oZPIBqjgk lAJ0iHcxP953r2hF9EHhCTggSozHKYJbc3G9UzOy0Z6VYany+7tkmU0VJRqOqfGVZsF6Qvuqgmi +/6R92xCJhVYx5xsBdv5W2tGBNlFGmIOp+yyrlOtWKC2e3mC+nfSMxb964LKCt+NWBjFXNWO119 Mynv+7rKtHrYgCRzQpgIUoM0DSe/0xTF7lAbisRU9NJC3PZHxBlGRIBydSE6GnvLv/K11PHMQ+9 gAu25RScPu/Upcf1TXr0uH6LEn6WdONLoep60tCLxBdhEF01kBWa4BkCjChUV9zZ5jHHb9VbWqs surhUhUJ2QBANM= X-Received: by 2002:a05:600c:8105:b0:482:f12f:f35e with SMTP id 5b1f17b1804b1-48519837ec2mr74771565e9.12.1772698071201; Thu, 05 Mar 2026 00:07:51 -0800 (PST) Received: from localhost (p200300f65f20eb044d629f1ad692a1c8.dip0.t-ipconnect.de. [2003:f6:5f20:eb04:4d62:9f1a:d692:a1c8]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4851fae475csm23291195e9.8.2026.03.05.00.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 00:07:50 -0800 (PST) Date: Thu, 5 Mar 2026 09:07:49 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Helge Deller Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: drivers/video/fbdev/au1100fb.c:448:46: error: implicit declaration of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? Message-ID: References: <202603042127.PT6LuKqi-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sx7nivqyo7vfvdjy" Content-Disposition: inline In-Reply-To: --sx7nivqyo7vfvdjy Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: drivers/video/fbdev/au1100fb.c:448:46: error: implicit declaration of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? MIME-Version: 1.0 Hello, On Wed, Mar 04, 2026 at 07:23:30PM +0100, Helge Deller wrote: > * kernel test robot : > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.= git master > > head: 0031c06807cfa8aa51a759ff8aa09e1aa48149af > > commit: 6f366e86481a7503a821de82930df517dddd4047 fbdev: au1100fb: Make = driver compilable on non-mips platforms > > date: 13 days ago > > config: mips-randconfig-r052-20260304 (https://download.01.org/0day-ci/= archive/20260304/202603042127.PT6LuKqi-lkp@intel.com/config) > > compiler: mips64-linux-gcc (GCC) 14.3.0 > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20260304/202603042127.PT6LuKqi-lkp@intel.com/reproduce) > >=20 > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202603042127.PT6LuKqi-l= kp@intel.com/ > >=20 > > All error/warnings (new ones prefixed by >>): > >=20 > > drivers/video/fbdev/au1100fb.c: In function 'au1100fb_drv_probe': > > >> drivers/video/fbdev/au1100fb.c:448:46: error: implicit declaration o= f function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? [-Wimplicit-function-dec= laration] > > 448 | fbdev->regs =3D (struct au1100fb_regs*)KSEG1ADDR(fbd= ev->info.fix.mmio_start); > > | ^~~~~~~~~ > > | CKSEG1ADDR > > >> drivers/video/fbdev/au1100fb.c:448:23: warning: cast to pointer from= integer of different size [-Wint-to-pointer-cast] > > 448 | fbdev->regs =3D (struct au1100fb_regs*)KSEG1ADDR(fbd= ev->info.fix.mmio_start); > > | ^ >=20 > I've pushed the patch below into the fbdev git tree. > It should (hopefully) fix the issue. >=20 > Helge >=20 >=20 > From: Helge Deller > Subject: [PATCH] fbdev: au1100fb: Fix build on MIPS64 >=20 > Fix an error reported by the kernel test robot: > au1100fb.c: error: implicit declaration of function 'KSEG1ADDR'; did you= mean 'CKSEG1ADDR'? >=20 > The header asm/mach-au1x00/au1000.h is unused apart from pulling in > (for mdelay()) and (for KSEG1ADDR()). Then > the only platform specific part in the driver is the usage of the KSEG1AD= DR > macro, which for the non-mips case can be stubbed. This paragraph is copied from 6f366e86481a and doesn't make sense here. I'd write something like: arch/mips/include/asm/addrspace.h defines KSEG1ADDR only for 32 bit configurations. So provide its compile-test stub also for 64bit mips builds. =09 >=20 > Fixes: 6f366e86481a ("fbdev: au1100fb: Make driver compilable on non-mips= platforms") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202603042127.PT6LuKqi-lkp@i= ntel.com/ > Signed-off-by: Helge Deller > Cc: Uwe Kleine-K=F6nig >=20 > diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100f= b.c > index 1a04154bc535..3b104d377d28 100644 > --- a/drivers/video/fbdev/au1100fb.c > +++ b/drivers/video/fbdev/au1100fb.c > @@ -380,7 +380,7 @@ static struct au1100fb_panel known_lcd_panels[] =3D > #define panel_is_color(panel) (panel->control_base & LCD_CONTROL_PC) > #define panel_swap_rgb(panel) (panel->control_base & LCD_CONTROL_CCO) > =20 > -#if defined(CONFIG_COMPILE_TEST) && !defined(CONFIG_MIPS) > +#if defined(CONFIG_COMPILE_TEST) && !(defined(CONFIG_MIPS) && !defined(C= ONFIG_64BIT)) The condition is equivalent to defined(CONFIG_COMPILE_TEST) && (!defined(CONFIG_MIPS) || defined(CONFIG_6= 4BIT)) which is logically a bit easier, but I'm unsure if it's easier to understand (IMHO both are bad). > /* This is only defined to be able to compile this driver on non-mips pl= atforms */ Maybe adapt the comment here, too? Something like: /* * KSEG1ADDR() is defined in arch/mips/include/asm/addrspace.h * for 32 bit configurations. Provide a stub for compile testing * on other platforms. */ > #define KSEG1ADDR(x) (x) > #endif Best regards Uwe --sx7nivqyo7vfvdjy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmmpOdIACgkQj4D7WH0S /k4M1QgAnufkIZRtUdQ4cmY1U5fdSOJSlsuzq0bUmxZjNlGMF8GgZFMN1EdBFR10 klcTxwCWs+LilgolbuNUKBDT6l2kxCHIAxO8IuVrCT7CfgRk1ej0LBZOcWTvoqyv CLuu8IAp01kelaAg58eCPeFgRvDMsTk7UuakLB5NVJr/7B/P5WAExYp+6PlDdHnn bz+BRg8aKAl61TItvo7K+aw01dozKrIEG+0UgWw/AcPjHsAqMD3Oq7SvvC176cDt wHGpLYgtYaMDHXd/z3XuPTe5VnQr9rC/WGLWXiFxLbSgJgWOGTpEVyO3N8aJWnM4 bS96m5AwqBd4I2VZJGCTobMy8Cf37g== =cM5A -----END PGP SIGNATURE----- --sx7nivqyo7vfvdjy--