Re: [PATCH v2 1/4] media: ipu3: fix alignment

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Bogdan,

On Mon, Feb 02, 2026 at 07:50:30PM +0200, Bogdan Sandu wrote:
> Fix alignment with parentheses.
> 
> Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
> ---
>  drivers/staging/media/ipu3/ipu3-css.c  | 22 +++++++++++-----------
>  drivers/staging/media/ipu3/ipu3-v4l2.c | 11 +++++------
>  drivers/staging/media/ipu3/ipu3.c      |  4 ++--
>  3 files changed, 18 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index 777cac1c2..145501e90 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -118,7 +118,8 @@ static const struct {
>  
>  /* Initialize queue based on given format, adjust format as needed */
>  static int imgu_css_queue_init(struct imgu_css_queue *queue,
> -			       struct v4l2_pix_format_mplane *fmt, u32 flags)
> +			       struct v4l2_pix_format_mplane *fmt,
> +			       u32 flags)

Why?

>  {
>  	struct v4l2_pix_format_mplane *const f = &queue->fmt.mpix;
>  	unsigned int i;
> @@ -1241,6 +1242,7 @@ static int imgu_css_binary_setup(struct imgu_css *css, unsigned int pipe)
>  	css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_REF].height =
>  				ALIGN(css_pipe->rect[IPU3_CSS_RECT_BDS].height,
>  				      IMGU_DVS_BLOCK_H) + 2 * IMGU_GDC_BUF_Y;
> +
>  	h = css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_REF].height;
>  	w = ALIGN(css_pipe->rect[IPU3_CSS_RECT_BDS].width,
>  		  2 * IPU3_UAPI_ISP_VEC_ELEMS) + 2 * IMGU_GDC_BUF_X;
> @@ -1248,10 +1250,9 @@ static int imgu_css_binary_setup(struct imgu_css *css, unsigned int pipe)
>  		css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_REF].bytesperpixel * w;
>  	size = w * h * BYPC + (w / 2) * (h / 2) * BYPC * 2;
>  	for (i = 0; i < IPU3_CSS_AUX_FRAMES; i++)
> -		if (imgu_css_dma_buffer_resize(
> -			imgu,
> -			&css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_REF].mem[i],
> -			size))
> +		if (imgu_css_dma_buffer_resize(imgu,
> +					       &css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_REF].mem[i],
> +					       size))
>  			goto out_of_memory;
>  
>  	/* TNR frames for temporal noise reduction, FRAME_FORMAT_YUV_LINE */
> @@ -1269,10 +1270,9 @@ static int imgu_css_binary_setup(struct imgu_css *css, unsigned int pipe)
>  	h = css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_TNR].height;
>  	size = w * ALIGN(h * 3 / 2 + 3, 2);	/* +3 for vf_pp prefetch */
>  	for (i = 0; i < IPU3_CSS_AUX_FRAMES; i++)
> -		if (imgu_css_dma_buffer_resize(
> -			imgu,
> -			&css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_TNR].mem[i],
> -			size))
> +		if (imgu_css_dma_buffer_resize(imgu,
> +					       &css_pipe->aux_frames[IPU3_CSS_AUX_FRAME_TNR].mem[i],
> +					       size))
>  			goto out_of_memory;
>  
>  	return 0;
> @@ -2036,7 +2036,7 @@ struct imgu_css_buffer *imgu_css_buf_dequeue(struct imgu_css *css)
>  				     struct imgu_css_buffer, list);
>  		if (queue != b->queue ||
>  		    daddr != css_pipe->abi_buffers
> -			[b->queue][b->queue_pos].daddr) {
> +		    [b->queue][b->queue_pos].daddr) {
>  			spin_unlock(&css_pipe->qlock);
>  			dev_err(css->dev, "dequeued bad buffer 0x%x\n", daddr);
>  			return ERR_PTR(-EIO);
> @@ -2169,7 +2169,7 @@ int imgu_css_set_parameters(struct imgu_css *css, unsigned int pipe,
>  		map = imgu_css_pool_last(&css_pipe->pool.acc, 1);
>  		/* user acc */
>  		r = imgu_css_cfg_acc(css, pipe, use, acc, map->vaddr,
> -			set_params ? &set_params->acc_param : NULL);
> +				     set_params ? &set_params->acc_param : NULL);
>  		if (r < 0)
>  			goto fail;
>  	}
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 2f6041d34..8ebfcddab 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -245,9 +245,9 @@ static int imgu_subdev_set_selection(struct v4l2_subdev *sd,
>  	struct v4l2_rect *rect;
>  
>  	dev_dbg(&imgu->pci_dev->dev,
> -		 "set subdev %u sel which %u target 0x%4x rect [%ux%u]",
> -		 imgu_sd->pipe, sel->which, sel->target,
> -		 sel->r.width, sel->r.height);
> +		"set subdev %u sel which %u target 0x%4x rect [%ux%u]",
> +		imgu_sd->pipe, sel->which, sel->target,
> +		sel->r.width, sel->r.height);
>  
>  	if (sel->pad != IMGU_NODE_IN)
>  		return -EINVAL;
> @@ -288,7 +288,7 @@ static int imgu_link_setup(struct media_entity *entity,
>  	WARN_ON(pad >= IMGU_NODE_NUM);
>  
>  	dev_dbg(&imgu->pci_dev->dev, "pipe %u pad %u is %s", pipe, pad,
> -		 str_enabled_disabled(flags & MEDIA_LNK_FL_ENABLED));
> +		str_enabled_disabled(flags & MEDIA_LNK_FL_ENABLED));
>  
>  	imgu_pipe = &imgu->imgu_pipe[pipe];
>  	imgu_pipe->nodes[pad].enabled = flags & MEDIA_LNK_FL_ENABLED;
> @@ -303,7 +303,7 @@ static int imgu_link_setup(struct media_entity *entity,
>  		__clear_bit(pipe, imgu->css.enabled_pipes);
>  
>  	dev_dbg(&imgu->pci_dev->dev, "pipe %u is %s", pipe,
> -		 str_enabled_disabled(flags & MEDIA_LNK_FL_ENABLED));
> +		str_enabled_disabled(flags & MEDIA_LNK_FL_ENABLED));
>  
>  	return 0;
>  }
> @@ -750,7 +750,6 @@ static int imgu_fmt(struct imgu_device *imgu, unsigned int pipe, int node,
>  		} else {
>  			fmts[i] = &imgu_pipe->nodes[inode].vdev_fmt.fmt.pix_mp;
>  		}
> -
>  	}
>  
>  	if (!try) {
> diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c
> index bdf5a4577..c33186208 100644
> --- a/drivers/staging/media/ipu3/ipu3.c
> +++ b/drivers/staging/media/ipu3/ipu3.c
> @@ -151,7 +151,7 @@ static int imgu_dummybufs_init(struct imgu_device *imgu, unsigned int pipe)
>  
>  /* May be called from atomic context */
>  static struct imgu_css_buffer *imgu_dummybufs_get(struct imgu_device *imgu,
> -						   int queue, unsigned int pipe)
> +						  int queue, unsigned int pipe)
>  {
>  	unsigned int i;
>  	struct imgu_media_pipe *imgu_pipe = &imgu->imgu_pipe[pipe];
> @@ -774,7 +774,7 @@ static int __maybe_unused imgu_suspend(struct device *dev)
>  	synchronize_irq(pci_dev->irq);
>  	/* Wait until all buffers in CSS are done. */
>  	if (!wait_event_timeout(imgu->buf_drain_wq,
> -	    imgu_css_queue_empty(&imgu->css), msecs_to_jiffies(1000)))
> +				imgu_css_queue_empty(&imgu->css), msecs_to_jiffies(1000)))
>  		dev_err(dev, "wait buffer drain timeout.\n");
>  
>  	imgu_css_stop_streaming(&imgu->css);

-- 
Regards,

Sakari Ailus