From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C619D1E5018 for ; Thu, 5 Mar 2026 05:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772688881; cv=none; b=YQok3Z23NXPr3PgDo5FIP+xHoGZHEFWwARyKOPnyHs8bm81PY5DeBu9YuVGRgBdky1W5VWI7zd8GMmmqphIMjTNvNVXmKoJLghvoQcrwd5JHMDj++kXglUFSr6XR/pFE/RMXjx3rNDjQgVS9kSNfRM0Xf70Gl/jOnKTn65UnU4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772688881; c=relaxed/simple; bh=MdT53VNsJo1KTOqLFXLHrv9hSp5uEa2RzIedrlI5hlE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KGngnR6FAPsuudOVvu1xTay7A+YeyTth7xFJhehobLhJ/LUBUp/HHDNLLzcrlewMAC3wO08xKlK508DUPNewpezm3Kvbmnjd7jLKMAzVyFCQ403FSxhbmwfvONVyVB/pyJGsorAXI+Wo7Jl5sYVzHYzeaqiocDLuXQ/jaFHeD1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uvMzd5VS; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uvMzd5VS" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-439b6d9c981so2778650f8f.1 for ; Wed, 04 Mar 2026 21:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772688879; x=1773293679; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MdT53VNsJo1KTOqLFXLHrv9hSp5uEa2RzIedrlI5hlE=; b=uvMzd5VStfX61P3qkjRU8SsWz5rA/uppZWNuZx6KzoRJhAy6jPX+Yo5UnQRHMLVYzX ++G2dpmTs4MQXxYepuUU6A8FOC/0bEWgn5j7IWpbf1I9Xxhz3AH8dVORNDMhViMSmIJ9 homRZgBjSHRRyO4OacV48b6nSoqd5iMyVXqpvTdnyZrvxG3suw2rT1a6EjPElgUNicMq x5itAnYtoLDCxmareJJ+jrzcs3r6+fDPmxLo7JkEvAGFhGlV1BOuIUyJwLm1nlvMKCJC ZKW5IX9aJHRuFVutx5UXJp9I1tFK2KDMIrlwTHrZPvdCPxyV17DdgyVU7UMdyV42L/P3 hi9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772688879; x=1773293679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MdT53VNsJo1KTOqLFXLHrv9hSp5uEa2RzIedrlI5hlE=; b=XbA7l+KTrXKvqBNHnh4pDVzFa2plsmD2FVulCKFnUOqYncr92TRE+2qzDrM6SKp9oM +CvJqJymHjc4cV0jQLFNmLL/gpH5yOtTphcNSe+b6ibs0MBW1myEgQIi4QnOenmXatN2 C8mmFlm0yvdY3cSbuKYkItD3f42xqiZWuRwFIOG9ljnhJc6/T6IainO3XG8LY+n80hkw mIUGSfEz7LM7rMw4bPrqzyw4cU1H0ecDmkKjsONdAAuzB8xf4fAysA2Z16+CnEGHoJ4Z cEgYAuQ5w/xmTWCH0kPTyuiIGTKo7AGy+JCWsknVLCPPorlDd5zcvg1nQdoFdnN/AT5Z E0Hg== X-Forwarded-Encrypted: i=1; AJvYcCWSx+26SFQH/1Zk+zVnrobVVqpaZIrEcD64YCdrysEoAwcvbGk2oyPxZvtPA7eAOKlqzsHiTncDQViqZEE=@vger.kernel.org X-Gm-Message-State: AOJu0YyKsJWsPN4VUXj8Oiu/EdHweHyGaZkNaQQy2LF6bD0uBYRInUfy 5C1xq+9RJE5p8QvoiSCTaX1GyGhsk2HOse6TykKg5xw2xXvK+8GB9qFgDb4hB8N8WcMw/XR3n8l 1AVJ0 X-Gm-Gg: ATEYQzyK1gZKSZRVtaS3ntmsBaBZc5qhfaZKLMh4JfrZhTWg7DQY60J0DTEiXQ6M9B6 CDpofBNX5CNiyAEAa4Yl56+Cd7+BB8xjwrDOz/7aLokhobQ8n4QgrGcqU9cUTjSVXx4Wbqmf7bp XFdT2JSvER07nxmBDbOjwS6AwGvmRR9TBWU9hK0b9aAQjWbnP++lAkTQoyb8/4M5NpYLsJhYKdp pzxKlfCGE2iytAH/Aei2Ufs8v3cALSQIUHwEVvtLFQwMO9rIOEhBeBlr5LoYr4G7R0rACvoER5T GBiqHqJHlYMVyWX+q7Zvfn/YCs5i0yiGbQ4Fyq2acmP9BVfecpH0MnWagt+GWPAb33NlHPn0LBR T6mV4YyVBSQHx+Wbd8/st+zqZvo4AbobhAROARTBcVpUQQeloCRBfvYh1yohooHGJ1qWoexUoBe 2oM6KNOAwPmokp6y4+uQPovwN4tAUW X-Received: by 2002:a5d:584c:0:b0:439:cc67:abe9 with SMTP id ffacd0b85a97d-439cfd461camr1819806f8f.27.1772688879158; Wed, 04 Mar 2026 21:34:39 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b8807a4esm26871282f8f.4.2026.03.04.21.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 21:34:38 -0800 (PST) Date: Thu, 5 Mar 2026 08:34:35 +0300 From: Dan Carpenter To: Soham Kute Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] staging: sm750fb: sm750_hw_fillrect: propagate de_wait() error Message-ID: References: <20260304173529.192067-1-officialsohamkute@gmail.com> <20260304173529.192067-2-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304173529.192067-2-officialsohamkute@gmail.com> On Wed, Mar 04, 2026 at 11:05:25PM +0530, Soham Kute wrote: > Propagate the error from accel->de_wait() instead of returning -1. > The caller treats all non-zero return values as failure. No, the caller just ignores the errors. regards, dan carpenter