mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com,
	jonathan.cameron@huawei.com, dave@stgolabs.net,
	dave.jiang@intel.com, alison.schofield@intel.com,
	vishal.l.verma@intel.com, ira.weiny@intel.com,
	linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: add a boot parameter to disable parsing CFMWS during NUMA init
Date: Thu, 5 Mar 2026 01:30:04 -0500	[thread overview]
Message-ID: <aaki7DZ78o_vr0kb@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <8ad398f6-995a-489b-8ca2-f21afdce47e4@shopee.com>

On Thu, Mar 05, 2026 at 12:18:05PM +0800, Haifeng Xu wrote:
> On 2026/3/5 01:16, Gregory Price wrote:
> > On Wed, Mar 04, 2026 at 04:06:47PM +0800, Haifeng Xu wrote:
> 
> Every memcg records shrinker info for each possible node. If we use online node
> instead of possible node,then during memory hotplug, we must tarverse all memcgs
> and shrinkers to check whether corresponding node has allocated the shrinker_info.
> This way introduces more complexity.
>

Right, but some systems might actually WANT this many nodes, and this
does not scale well at all as-is.  I also don't think it's as complex as
you think, most of the infrastructure is already there.

> > If you're not actually using CXL, can't you just disable CXL in the
> > BIOS?  Then you shouldn't even emit CFMWS at all.
> 
> I have asked our Intel Support Engineer, he saied that cxl can't be disabled
> in BIOS.
> 

Huh, this is surprising.

If this is the case then see Dan's patch here:
https://lore.kernel.org/linux-cxl/1f5074979a58803ec875dd10c9234c7b1a17192d.camel@intel.com/T/#m0d64b723a63ca7faf44311c52c1ebd5f280ae626

That should deal with your issue more cleanly.

Otherwise, the problem you're describing here really should really be
fixed with either better lock scoping or lazy-allocation.

(Already poking at the issue a bit)

~Gregory

  reply	other threads:[~2026-03-05  6:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  8:06 Haifeng Xu
2026-03-04 14:10 ` kernel test robot
2026-03-04 15:11 ` kernel test robot
2026-03-04 17:16 ` Gregory Price
2026-03-05  4:18   ` Haifeng Xu
2026-03-05  6:30     ` Gregory Price [this message]
2026-03-05  7:43       ` Haifeng Xu
2026-03-05 19:57 ` kernel test robot
2026-03-05 20:19 ` kernel test robot
2026-03-05 23:00 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-04  6:46 Haifeng Xu
2026-03-04  7:55 ` Haifeng Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaki7DZ78o_vr0kb@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=haifeng.xu@shopee.com \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®