From: Dan Carpenter <dan.carpenter@linaro.org>
To: Mark Adamenko <marusik.adamenko@gmail.com>
Cc: linux-staging@lists.linux.dev,
parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: dim2: convert ROUND_UP_TO macro to static inline function
Date: Thu, 5 Mar 2026 09:33:30 +0300 [thread overview]
Message-ID: <aakjuiUqhYHCrSuh@stanley.mountain> (raw)
In-Reply-To: <20260305023000.64609-1-marusik.adamenko@gmail.com>
On Wed, Mar 04, 2026 at 06:30:00PM -0800, Mark Adamenko wrote:
> @@ -758,7 +761,7 @@ static u8 init_ctrl_async(struct dim_channel *ch, u8 type, u8 is_tx,
> return DIM_INIT_ERR_CHANNEL_ADDRESS;
>
> if (!ch->dbr_size)
> - ch->dbr_size = ROUND_UP_TO(hw_buffer_size, DBR_BLOCK_SIZE);
> + ch->dbr_size = round_up_to(hw_buffer_size, DBR_BLOCK_SIZE);
We already have roundup() and round_up(). Use one of those.
regards,
dan carpenter
prev parent reply other threads:[~2026-03-05 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 2:30 Mark Adamenko
2026-03-05 6:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aakjuiUqhYHCrSuh@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marusik.adamenko@gmail.com \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®