From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 450BD387570 for ; Thu, 5 Mar 2026 15:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772723393; cv=none; b=rROVS8B1Ka8a8gXEa0djtL2P7dFPXmPELPov42FrIxhkW+GHBwccQ19b2GXR9d6zsdYViulUA+Rpzu6tV3opOkkzHhCGvzIOOOYW0kzmDkQfEp4V6O1sTfH6qlQdeNVqhG2LqSRmmb/dMyRftbwn7GV7sowvRDXuaV66C+U3mwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772723393; c=relaxed/simple; bh=PXmcl4tPFlOnNNYThEePOc90/m+UkIgholOL+Kk70Tw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k1eaK0MT+wJEFfCUWCpgH13H3Vm1BjpSYK1gnwhxES4fvxY2YoR3j6GFK3xqJF5rReVaHiN/7CfZ9JRQzzueAeSBweGSXH32CR7kf5FraLH7UddLm7RqPJ4+cti4LNAIurDPB7/6nqjdRLSgw8hRoxR7Nmz044ojCLoM8yj+OXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=b9DxdZM8; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b9DxdZM8" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b9382e59c0eso298129366b.0 for ; Thu, 05 Mar 2026 07:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772723390; x=1773328190; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3OmpzvQpYMJXClO5qkjGcMYeXJMiSrkcfp4KTo3+tdE=; b=b9DxdZM8BTbK2wUZrlOEzdh+u8ZCpWMj69r3lHxIguyPceTZxUTRRpu6NRtRIje2aY 2N+++LJOrB4YbZV4MucDOuYgfv+uotxYcTrNygU3Dy3jXYZ9JMjmNsJrnjeDjrCzIGQc r667V9tBmC+F80nNvOWum15AsD3UppRXtqH98m2BoNO/hsVinN6+H7myT+OYz0HEZIxv SUq4kXaEPUiCMPGRSH4y6+3GCpQoLBr6q4DJ60A8LcvkGWUU9WkVFtr1KFOsM446oeGj lIAt55H1MDQ+1Xv84KdV9K1C3ZNUrl6jFNoBbzAZo4AhYdnWZXucpsZ8W42V45q/jobT 7++w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772723390; x=1773328190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3OmpzvQpYMJXClO5qkjGcMYeXJMiSrkcfp4KTo3+tdE=; b=XMuuPF9wfgcoYu3FrXiABz1D/cLSjh6u289ax7xzYemv6QgHf1EoBJd3nI3SqjWlmk W02+mkqNv/GEcOmss7NwcJAmCf9CFuXjYpmwd3E1vDdn8j9pFjZBnVCuZqml6KeTTz0j ocEgZFTf5JWf9KrvJsS+FASwaz4Yby0Ebnq1oXwvQKbAEgFgzsKol5/V4F5t3exBDtse WuopAe/2ah/6pk2UiEJq5pW6MnUY4SjP6GJ2xSqLrHoT6NXwXsjKGLlZXroGV/wv+VhB EZaIhwEXOyl/v3Rijl+y4/R7qrtuPZx8Bpv5icsDVDz4zZQ+iI9XjKAe3iUlv7urHG18 7Qhw== X-Gm-Message-State: AOJu0YwSewT0xZ5GY2gIGKT+9pogs4n3nHjDSz8+11zHmmZefUtli22H r7jlYnoOd99aHWP7kO4UOC8XtvuGW9W4QL3hFjuzoL/pwrmgL3r5GcBf02lnZ3N0a2Q= X-Gm-Gg: ATEYQzyR4UjqfPCu4bxPTxGxUTBl3sdB7o5HeTxmLZd+MqpjFwEy9uKhHYSnG3qugGb X8/wlv/xAiq34X69t4Kr5leRRrEKCF2PBeQlVgP7pP+Asrtw5eciuyCCU3/3wcVTM5fOZsiUuRy D+dXZC/yEjfWOSeqes4KCCVB3vbjM2sdlYu0zcasu2mSCl2ZY3ZJPfSHzzTKI5JGE234OVgyQ+I fUqBC6ZZoUFQPXCfztsAK9M5NbWC1iRwQi00atuWSfWy2fE2dr0jK/JupQ43ycqbXFu7lgm6zUO PhP13DXz9Wz1smBQP3VvMjNcTvHUh4886cdDYd3Q0/2QXA0vSl3cFuphfyIwXHfA8/d0ltDONE8 oiYjwKoupU+waiRN9hnLsz7sxbqP/KNDUgrsMgiMaEQv3EF0dtHKiRvjKwjFo7JC78vYyeCG36G dGKRAal42lLOj9HAIq88xjU065/ESm X-Received: by 2002:a17:907:3f8a:b0:b8f:87a9:27b5 with SMTP id a640c23a62f3a-b93f1432d73mr412111666b.41.1772723390403; Thu, 05 Mar 2026 07:09:50 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b941f016ef9sm26138366b.39.2026.03.05.07.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 07:09:50 -0800 (PST) Date: Thu, 5 Mar 2026 18:09:47 +0300 From: Dan Carpenter To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, philip.radford@arm.com Subject: Re: [PATCH] firmware: arm_scmi: Fix NULL dereference on notify error path Message-ID: References: <20260305131011.541444-1-cristian.marussi@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260305131011.541444-1-cristian.marussi@arm.com> On Thu, Mar 05, 2026 at 01:10:11PM +0000, Cristian Marussi wrote: > Since commit b5daf93b809d1 ("firmware: arm_scmi: Avoid notifier > registration for unsupported events") the call chains leading to the helper > __scmi_event_handler_get_ops expect an ERR_PTR to be returned on failure to > get an handler for the requested event key, while the current helper can > still return a NULL when no handler could be found or created. > > Fix by forcing an ERR_PTR return value when the handler reference is NULL. > > Fixes: b5daf93b809d1 ("firmware: arm_scmi: Avoid notifier registration for unsupported events") > Signed-off-by: Cristian Marussi > --- Reviewed-by: Dan Carpenter I feel a bit bad about this. I saw this as a Smatch warning last August but I somehow marked it as a false positive. :/ regards, dan carpenter