From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C35B3190462; Thu, 5 Mar 2026 15:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772724582; cv=none; b=A23y+zohjYvwTrPUIyycMpgtWN2cETnKQ7Znnnkm+AfqhxI0l+Z/v+pmLuY8igaXJZeAFxNlCHdpJaKMuY0pHhIV73S+HMMFSViCbynqIvFgOAU2Cx5ZOyDZo95P+6wFdcq5NkZwfoxoEVPIJLBH0uajwSY3IVbN1erWXfRvhgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772724582; c=relaxed/simple; bh=l66jhLVas2Ia2awwsrvJbzUpshjuGV3BhaadeglMitE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QHN1WsugOj36x1mlcNWK4zff9t0w5hWJTHH3FG8R34P/7aXn7V2gUSeBKp1zgVTs6ZJCD42Gi7oxtw/Y3P2DYvwPbfzl1C1HwTuuaUfat3c0d3U4WisHJOohw4G7dmdFj1J0KT1A9hbMXIHZA/g8DFmrdhUZ0/jLHOeQIeCjNYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G3C+WYLD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G3C+WYLD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50600C116C6; Thu, 5 Mar 2026 15:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772724582; bh=l66jhLVas2Ia2awwsrvJbzUpshjuGV3BhaadeglMitE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G3C+WYLD2+TXiDLmNWENrPfCpAs87hi9rMNOJSI8+ruJyRvDR30BFYjn5MOe/iAT1 DwHbvb5dq/kVM+a0WCmVYYzD3lofyBem3Pc+O33foHoRDCw2dVunNcUn8SwHN/GRvG sMTG9MhfYFz6zHekkNsDzlqx8DjHFd1CgVnb7nw9YrI0bYjgbk9NECERsryLMdrnIN LxdA+4H3+WTOjTdL9VgvStkfSA1q/EkJHokGTonisDbcsMy44f8qyMJOX/AQ+qHLbk LoEzfveJooU0zUdeL9vIhyqrXU/9d2zZM6qcYvUxgqUi+uMRfu1UrKEfptOAzJjfsm j/r/61HZQbNaQ== Date: Thu, 5 Mar 2026 23:29:37 +0800 From: Tzung-Bi Shih To: "Rafael J. Wysocki" Cc: chrome-platform@lists.linux.dev, LKML , Linux ACPI , Benson Leung , Enric Balletbo i Serra , Ravi Chandra Sadineni Subject: Re: [PATCH v1 4/6] platform/chrome: chromeos_tbmc: Convert to a platform driver Message-ID: References: <2274474.Mh6RI2rZIc@rafael.j.wysocki> <2553054.jE0xQCEvom@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2553054.jE0xQCEvom@rafael.j.wysocki> On Wed, Mar 04, 2026 at 07:44:26PM +0100, Rafael J. Wysocki wrote: > static void chromeos_tbmc_notify(acpi_handle handle, u32 event, void *data) > { > - struct acpi_device *adev = data; > + struct device *dev = data; > + struct acpi_device *adev = ACPI_COMPANION(dev); > > acpi_pm_wakeup_event(&adev->dev); ^^^^^^^^^^ If I understand it correctly, I think this should also be changed to `dev`?