From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8C6D2BD597 for ; Fri, 6 Mar 2026 07:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772782676; cv=none; b=ULS8vsnYbLHppOMEW1gnQNQepPgGNSGYK9g6+ZcBx6v+Nac/jRV8O9UuG26P2tz0MVXwPAlt7laZU1QLHRBWzMOyHZGc8XXnMU7wxh6dHPLWSwcu9g1nxL52Ol/5TtWmJArwFOro8Kn8iuOs+BqC9g9jd0m3r75mruzGUmRx8k8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772782676; c=relaxed/simple; bh=uXJMq5NihzlfjA+MCDH1l1an7MdcB9XB4r0mkOIwJB0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gIDCRBXBb89oVrnBkrxhVoYYFn9VXujWD9qe74Qqa65u7Bj59BcyC4/n6THpNVmT5p5vROLIOdTq0x/eWBRecjqUydajE/1aB2ZGBknjdQ33l2Nw96GtYVKEPG0g0/rqNVroJScHnn/VQu3YSLI+at5sZ8Lc8QNdh6NajM7wTCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BR0e3QRt; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BR0e3QRt" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso73913865e9.1 for ; Thu, 05 Mar 2026 23:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772782672; x=1773387472; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ESIsX+czZQWUv1elVg3NAnroQwJHdnafYZW/tGLRov8=; b=BR0e3QRtCgqSsYWjD6Gp9kQY14mPRBhT1vswGLObXGImO2IvS34pds5+IKTFUO9yE/ WPcOJqlHFHDXQ9nQL7wMp3tJgX9DeePmdWRXJipRE6yulymzlrqlSJxh9ixe0aQFp1dr JzC9kQgt5uJJDF7sRqzpCftXQRVb2eBxu3srUSBDEtBdzr7DF1vuPQ3VI5B73JsZvYEy rDNgUgKp9NtjfoN69BM5owVpTd0ba2Cu4GLiPwfEkHaOMO/TcZXK77X9ZNQjiWmZaDQz n2dsF118GkAH9sW1MEyC5OyvaVDh6wLc68Gnh6fdXVtFDODuVExyfR86yhf6d9G4+XsG IVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772782672; x=1773387472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ESIsX+czZQWUv1elVg3NAnroQwJHdnafYZW/tGLRov8=; b=nB6ZEjFr0GlSLj+6KfXKocxg18UnT9YTJQ+DB8iPlFtY7EQlBDEQdBjIHDitmAkGus 7TS8/zReANn+vwdD0O5Xm5TEuPunSk6NcwB0tpoxhTml0ktuxy7lcTT3QLl/M0Ua+ytg FacaQWhFMOS9eocznjQBoE4aJcq2ZexLTnLUjSe291MuHkOcEfpUZvHLOnVElqhYLAMZ CZBqOMv+EaWKb5/DyQnHmPYB7ea/9lpMG+By2KXveFJpCxCrj5iOo9+SwUqjyh4NcQVA DxAc/FdslFWaeqT+GGtHw3UiMWCNf8lLukho064Q5wfJKC2RDxt1GAGxogFt7i40ZdAt +EPA== X-Forwarded-Encrypted: i=1; AJvYcCWl9NUyK9Ao6ov2Vt2NfyeOeoL4rlwR1YXfy3vP+w1OWBEQJJMAV3Y+pYC0AGEvFhwXeNwzoY7ir8hQsBg=@vger.kernel.org X-Gm-Message-State: AOJu0YzYrVTE2w4xLrjeBOSNHJ1AZChWEh0kKSrpH8GXS+qi/IOzz/T/ cVqLAlAEnJUAFs+nbfr8odDrLBH1QM2Q2tuEByggtbs5n/nxHhZuUrMY4IRARkJx2rY= X-Gm-Gg: ATEYQzxOah4lM3gUELye7V2IAU9zsCeLr6kTP70e5U4PFhUYUJXSbgEC65+J0xeATKc F4qhKpIttEZ0FBhQY8d6/Sk8puuWu+k7FncuvoqcMF9XSdutiVdayAakP3O2uNkHS9xogiLLbsh aLmkhrRrc8F2eDfdqk7OIEy1f4+oind3IkQ88bILVwCBWeILGuqIhvZwX0aEIN5vnNPEQ/ZvTqv iLwWDWbZ3ITwYFyuYTUFlAjyWtoyV5d5aTCmyFSQR2mReXs4KZxD7wWuvZ5fgNsi4K4BlBOQaQP WMRQCZv+7hDP3UXB1qyTaIvdJEueuB36AfIlJaBKAI752oOa9x6AY4exm7LVf0AGBKei3vw3aUZ INkqnjY5bE59svZ7F7YZWk5b10jBy7aEiCU4kUXU3y59fdf0Dk2qdU0/vJVg+3CaquwnWcS/Uwv l5OQNfV84w96I0Ued55FKH/DdjuYAj X-Received: by 2002:a05:600c:6091:b0:483:348a:d3f3 with SMTP id 5b1f17b1804b1-48526951407mr15751015e9.18.1772782672156; Thu, 05 Mar 2026 23:37:52 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485276b0c38sm18617615e9.9.2026.03.05.23.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 23:37:51 -0800 (PST) Date: Fri, 6 Mar 2026 10:37:48 +0300 From: Dan Carpenter To: Mark Adamenko Cc: linux-staging@lists.linux.dev, parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: most: dim2: replace ROUND_UP_TO macro with round_up() Message-ID: References: <20260306021926.7475-1-marusik.adamenko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306021926.7475-1-marusik.adamenko@gmail.com> On Thu, Mar 05, 2026 at 06:19:26PM -0800, Mark Adamenko wrote: > The ROUND_UP_TO macro reuses argument 'd', which can cause unintended > side effects. Remove it and replace the macro call with the existing > round_up() function. > > Signed-off-by: Mark Adamenko > --- > v2: use existing round_up() instead of a custom inline function Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter