From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEF0F3368B9; Fri, 6 Mar 2026 20:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772828132; cv=none; b=YhrD+b/FxzNj05Rfw7Bq5M9y6DB1OvkHAqJ50nbKZG7KitTlod/jYzKzkfeV6RUHvrXCtFYqRTMGZVY52+9BkCIfMW9+4rnyFqoPrmTTSzB3FtzU6wxWZbNdghL/yfJGE/YZA4cke6ioD+HclhoylVtoFV1TfIfcdAl3taxTr4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772828132; c=relaxed/simple; bh=AXun7U2GjUr+BGdb5GDBtBrxp5rjVX2GakYwThhVkH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bTK5y69KnseSKXABHLp2WQtpgdelzt1diCbQtZi43ZJQXJp/fqQYQOTO6c9E+NTVZBvsXMAQZc5B0lFPQLxmWiVw/0xjJyfEkSzJQmSbCKEWsFkxQZ629xgZn1C1Z+68fCudSJVo4tFGOlvOL/Sefsvip8prxSlHIW7FAEWyIbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=sBhsbe/F; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sBhsbe/F" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kqDtRxUnfGVfrmPs+B6wD6LFhV7Vqmyopjf7Cm65ZXU=; b=sBhsbe/FNOqE/9HPmw8kY8dloZ D3l7DInSbFxSaRAGRZ5ESjNCK30kpnNJQmpNy3wd8uaJncNSI5SYn5GVyFQhbgef9IvfE+J7x8I8G cuP+fHX7rowitDNg++hVYOrVbs14VVSv44OUNdEmldYhWz9/jwbLuy1n3bLwc8KQ0EoXK894aH0h8 zKF+b7TywvlXPi+nLe51Tyk9qcfLYN8wrn/c7B7tuazL+jq4bfFgo7TUmNSBNQCHwbA0XxC40V59t rieSdE4cYACXiuUHwRIGtxm9sozlM2dgZRKVH7ySQjtMS6D2DiwVJOwDPoay2PKrl6rEr2TNPudxE f5cE6rDg==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyba4-0000000HGPN-1QDp; Fri, 06 Mar 2026 20:15:28 +0000 Date: Fri, 6 Mar 2026 20:15:28 +0000 From: Matthew Wilcox To: Josh Law Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Josh Law , Yi Liu , Jason Gunthorpe Subject: Re: [PATCH] lib/idr: fix ida_find_first_range() missing IDs across chunk boundaries Message-ID: References: <20260306200319.2819286-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306200319.2819286-1-objecting@objecting.org> On Fri, Mar 06, 2026 at 08:03:19PM +0000, Josh Law wrote: > ida_find_first_range() only examines the first XArray entry returned by > xa_find(). If that entry does not contain a set bit at or above the > requested offset, the function returns -ENOENT without searching > subsequent entries, even though later chunks may contain allocated IDs > within the requested range. Can I trouble you to add a test to lib/test_ida.c to demonstrate the problem (and that it's fixed, and that it doesn't come back)? Also this needs a Fixes: line. I suggest 7fe6b987166b is the commit it's fixing. Add Jason and Yi Liu as well as the author and committer of that patch.