Re: [PATCH v11 2/2] dmaengine: dw-edma: Add non-LL mode

[Frank Li <Frank.li@nxp.com>]

On Fri, Mar 06, 2026 at 05:22:28PM +0530, Devendra K Verma wrote:
...
> +		/*
> +		 * When there is no valid LLP base address available then the
> +		 * default DMA ops will use the non-LL mode.
> +		 *
> +		 * Cases where LL mode is enabled and client wants to use the
> +		 * non-LL mode then also client can do so via providing the
> +		 * peripheral_config param.
> +		 */
> +		cfg_non_ll = chan->dw->chip->cfg_non_ll;
> +		if (config->peripheral_config) {
> +			non_ll = *(int *)config->peripheral_config;
> +
> +			if (cfg_non_ll && !non_ll) {
> +				dev_err(dchan->device->dev, "invalid configuration\n");
> +				return -EINVAL;
> +			}
> +		}
> +
> +		if (cfg_non_ll || (!cfg_non_ll && non_ll))
> +			chan->non_ll = true;

this logic have a little bit complex

if (cfg_non_ll)
	chan->non_ll = true;
else
	chan->non_ll = non_ll;


> +	} else if (config->peripheral_config) {
> +		dev_err(dchan->device->dev,
> +			"peripheral config param applicable only for HDMA\n");
> +		return -EINVAL;
> +	}
>
...
>
>  struct dw_edma_irq {
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index b8208186a250..f538d728609f 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -295,6 +295,15 @@ static void dw_edma_pcie_get_xilinx_dma_data(struct pci_dev *pdev,
>  	pdata->devmem_phys_off = off;
>  }
>
> +static u64 dw_edma_get_phys_addr(struct pci_dev *pdev,
> +				 struct dw_edma_pcie_data *pdata,
> +				 enum pci_barno bar)
> +{
> +	if (pdev->vendor == PCI_VENDOR_ID_XILINX)
> +		return pdata->devmem_phys_off;
> +	return pci_bus_address(pdev, bar);
> +}
> +

Reduce each patches's changes, make each patch is straightforward

Create Prepare patch firstly, change pci_bus_address() to dw_edma_get_phys_addr()

just

dw_edma_get_phys_addr() {
{
	return return pci_bus_address(pdev, bar);
}

So this patch just add
two lines here

if (pdev->vendor == PCI_VENDOR_ID_XILINX)
	return pdata->devmem_phys_off;


others look good.

Frank

>