From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034492E62A9 for ; Sat, 7 Mar 2026 14:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772894652; cv=none; b=lACPCojEL6RBnskO6bJ/XH0SRnh2fXy9NQaNpt4ebp495EtSb2kfn9sxEd5u8fiTcvFeJzOIckdOjKRRQ9n9nG4/TM0c9mLLnZuUQ+X4fmiMzV7hHS8knTCgR3NcpYJJc1bX/LBCwzhX8CgVvh9DkRGjtkZl7whRl8oC0IV6UGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772894652; c=relaxed/simple; bh=s5D80duEhfer91OrynpHJ+oK+KbxEzXuy9AKUJMhQJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mIc+yQEGQpSr596VJp+7sz+AhNvnE3bi2N7up6LOGYkBuuRhVHYHRJfyXf8kkNBmVhn8S+gv8xyqwjP95h1v8JUQbUYdIoOcFVuFzom8idn3XU+qumZX5glaXw8HRmVOqn6mUWJKobNYrMAsYRDtZDRofJAxZLjdVsrOD/uATFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PCx3KQ9r; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PCx3KQ9r" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-439a89b6fd0so6835977f8f.2 for ; Sat, 07 Mar 2026 06:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772894649; x=1773499449; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h0Woosv//31tm6oZiSnSnGD51f8ZcgGW6Us1yWUdGTI=; b=PCx3KQ9rv/m5bVvf3HiuhYmhvWgzMOdMblbeV2G82XKn/I8KYNeqowR0lNo7WxKd+I /oioxDVkfltXEzf24km7w+7TFg5Jz2Qd23yM5/G7Kdhd8XT5Uzko+W0rjlzupT4S0pup w8CQFTzbhq6tQH+Jd1WhBJNWBkKKyyjFKiDsUxHVll5jlHIg4d2BpS87hKyxOVKJvNse pDgeLxgQxb+RWchYx1BjCHObQanIbavWGaQuYGicP9MFdvTlk78FLDRJHknhookEKWI9 qvez/XcU+pEVhgTOBVz5/bws852SOCPEHN3y4mf70J/RmblC0Kv98VHpxGZnro+SDOP6 QONQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772894649; x=1773499449; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h0Woosv//31tm6oZiSnSnGD51f8ZcgGW6Us1yWUdGTI=; b=YJlf6GVPEkGlyDT6FLHXv1nx4irluN7A/cbf6NCU3MHz6vFuIAr7FfTWIBepBKVEMd u5eJ088ZrRfsarTqJz6dtzntnxCr/KT5Jlk+2zt+V7lq34QYPQ9vkXFLHcYm3DlV10CK BcTrBle7NlbYg5da/HtLCAYZkN5bSpJp5EsyTDkcME6FPs+Y/MuWQpZ/QUGjDCNd1y10 wVV0nZvL2r4HIov/cmOrdhpSZ8hUS6UST5NhT9RAwRNZau5Ao/t5K4DZvNgpb8N157sT 7BYRCTsikN7FG8YgXSdxxSi2HkreeQ+cK4cOFyQWrNtaRt+gEemjpO7SGZ65GzN8xq4F F21g== X-Forwarded-Encrypted: i=1; AJvYcCWh49ong9pD1l7tpTpatm6B/X84dFNx1xIH0OiGomFV8sd/uKPrmaB5VH6crK13kipiFyjS4nnK/7Wbj0U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywx7jEjCnxnQplHP03+B2hPXu9dMA1NFSTBALO15qsHKJskpk23 TNOtBsWTuVjLpf7OV8Xd35SHsLwXSOjJ0JmWIDqO6NRw57wvNvAbWLWY1yH9AjiLVKk= X-Gm-Gg: ATEYQzzYyIaYdviOh5ba0sLowWRhubXba0JVtMLjz1nNOJG7d/zCzwrEbx00kOTNBw0 HIj1vNhFpnI/SHDzc4PGeAXyT8Jp1rOQ3M96GS80r+U3XlnDX9RBac1BJ7JxNpE2YmkYKmkNicz CZMgOya978KmN+H7Te4lMYOFuKGRNOcXAuTDtDAQmP9w4BQ8IqR1sJoFFI+tknKzYsjuW6rTuJo PB6qhXvhzSKJ9k/hPsFO/oddiyW8dsVRm5jerIDDsqGLL7+VEErf0vEXqDC/JE3BmZXf6W5uam+ m4G9O1EoJiGigX6Vwx/ghk7vBKQRQ3yxuQkv664TEBISU+BUkeum19urB6Agd3K9doDoRQ9u4Lc /iZP93cB2CkD7UZuOEYCghH8j5a9GJYWJYfLO2WymZMxxvs2sBV7jyvcS+z+HEctACoX4jZGa/j 6cjd9yrZNQBy9ZjCt+eKRfUW88MDcb8Pj99wP7Ew8= X-Received: by 2002:a05:6000:4027:b0:439:b8b2:fad0 with SMTP id ffacd0b85a97d-439da555606mr9905810f8f.5.1772894649084; Sat, 07 Mar 2026 06:44:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae35cf7sm11931501f8f.26.2026.03.07.06.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 06:44:08 -0800 (PST) Date: Sat, 7 Mar 2026 17:44:05 +0300 From: Dan Carpenter To: Rachit Dhar Cc: Viresh Kumar , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Rui Miguel Silva , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] staging: greybus: resolved checkpatch checks for light.c Message-ID: References: <20260307140930.1732-1-rchtdhr@gmail.com> <20260307140930.1732-3-rchtdhr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260307140930.1732-3-rchtdhr@gmail.com> On Sat, Mar 07, 2026 at 02:09:25PM +0000, Rachit Dhar wrote: > Added comments to mutex declarations, to resolve the associated checkpatch.pl checks: > > CHECK: struct mutex definition without comment > + struct mutex lock; > > CHECK: struct mutex definition without comment > + struct mutex lights_lock; > > Signed-off-by: Rachit Dhar > --- This is a v4 so there should be a explanation of what changed since v3. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter