From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A4E1799F for ; Sat, 7 Mar 2026 12:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772885497; cv=none; b=klHYnjpxwU3dreMLPLSnQz7aboMHZNp4Cw/yG1jYU1H6yz/dxsstpDOyQBqAkn0SpIYANhh9uJBOX4yGl/IsvOftu8JeWiVTrooQZYdOlOU1TVXdKmBuNV4gl+OE/bGYZWz0M4kGgegwkuPRjHxS5qhF/04QbrDFWzW0KG5gzoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772885497; c=relaxed/simple; bh=+WO9KxHNwVnsfIeNE1gfsT0voV0Zy2jtiCaZ3RnOnoU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oIOuweJFv3OH899KunpYO3GC3lafwck1EC9M6a3ZrLuOlixBLai+1qqWQq9ANhNIKv109lJAtVIXUxeHdbRj0yXIZK84Q5vunKCOPwSu48RbqS0IdACtpG4iiowZF3l/2na5UsXn5ZHcdcK24Ap7my/dMfc8HCDtSsPmblX6ypg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EGztRvi8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EGztRvi8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772885495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BXTMSOZayuB6LOw8FILsdffQXhPWAaVM+3qLhyjMXao=; b=EGztRvi8isuYXVKFjnJDIaMzmxPNcLdeRcSqegPg9+84HjKIcwY6NGYRhVncQwG7aGggS+ 1nZuryLtMszK4UD/tAO0+tHI2RD3pePE2N4UgMv2eeABkv4xvsN1TbrdD0R+9PqMHsFIf3 xxLxNln26OJxoX2CGVYxbqrwpSybUR4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-y9DUh456NvKYiqjoeeDP7Q-1; Sat, 07 Mar 2026 07:11:32 -0500 X-MC-Unique: y9DUh456NvKYiqjoeeDP7Q-1 X-Mimecast-MFC-AGG-ID: y9DUh456NvKYiqjoeeDP7Q_1772885491 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB5B219560B5; Sat, 7 Mar 2026 12:11:30 +0000 (UTC) Received: from fedora (unknown [10.45.224.43]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 74C37180066F; Sat, 7 Mar 2026 12:11:28 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sat, 7 Mar 2026 13:11:30 +0100 (CET) Date: Sat, 7 Mar 2026 13:11:27 +0100 From: Oleg Nesterov To: Mateusz Guzik Cc: Andrew Morton , Pavel Tikhomirov , brauner@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] pid: cosmetic changes to alloc_pid() Message-ID: References: <20260306190100.1900572-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 03/07, Mateusz Guzik wrote: > > On Sat, Mar 7, 2026 at 10:23 AM Oleg Nesterov wrote: > > > > On 03/06, Mateusz Guzik wrote: > > > > > > Commit 6d864a1b182532e7 ("pid: only take pidmap_lock once on alloc") > > > landed v2 of the patch instead of v3. This patch remedies the problem. > > > > > > No functional changes. > > > > > > Signed-off-by: Mateusz Guzik > > > > The patch looks obviously good, but it conflicts with Pavel's > > > > [PATCH v4 0/4] pid_namespace: make init creation more flexible > > https://lore.kernel.org/all/20260225133229.550302-1-ptikhomirov@virtuozzo.com/#t > > > > In particular, this change: > > > > - for (tmp = ns, i = ns->level; i >= 0; i--) { > > + for (tmp = ns, i = ns->level; i >= 0;) { > > > > With 2/4 from Pavel we need to decrement "i" before the ->child_reaper > > check. > > > > That patch will be fine as it modifies the other loop which already > had i-- towards the end. > > So I don't think there is any need to rebase. Indeed, I misread your patch, sorry for noise. Oleg.