From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C57D838F933 for ; Sat, 7 Mar 2026 15:09:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772896145; cv=none; b=fIBl3dd5kQ2cusS53Xi317E7Xonavbg4UDgR79GJdpWDolYZwGXhLTqEIXYBWNl8GzQFI5xGoEFab1hv/g8GiSuY78Qp0rgyLEEHY/hWFKt1ebUbAwadJBP7NRtvvQZN6RPheyUYnryV5e8oS8RuBOrxRVmpqxkifvn3YM1dR1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772896145; c=relaxed/simple; bh=Kf20q3KKi+xM3qNss1cCgTlfjVY+Zi/cdmEhEb/OiyE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IvPw5suhaBfaC+7lZ/dF20gab7HVAnnf9oxuHzLuFIiPmv3L6wrE/H9QQpzEjdRjW6xhDY0K7F8jOn4pEAtilEHJ5kZtJw0ZoelPQTisRLIBynSyVuiBjoggNiKTejH3Su8cMgZTsrw8y6Y8E7KTiaFX2tc1JgdOtq5crq5B1d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=tWbuLXLw; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="tWbuLXLw" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c7393536e53so1077469a12.2 for ; Sat, 07 Mar 2026 07:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1772896144; x=1773500944; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=u7B+3R/eVcF0a4VFyKy9Mj+9RSgZdL4bns+9ocGpr2c=; b=tWbuLXLwgkd9q2RaAt/EUrPS6FS+oWLn3rYIqLMl71DyKAeAAsnW001HrIGVyZdtNp 9ZI4OcrQGxkySHuey1cPMDU4hqiaVQqsUSp48N0AZzXUuTCJySDgX1GjKfpQY628S/i+ x3UJNNqOGKWoPlns70GH5eQyISEv2FVL6Q29A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772896144; x=1773500944; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u7B+3R/eVcF0a4VFyKy9Mj+9RSgZdL4bns+9ocGpr2c=; b=GVPfIwCxxWLjtDTLnj8q5QFDZJIgqNZY6SaLC7nRemlyRKramFdMkfxgg4D9bBZU1M lirEW90HIvuohJsmyBtJOkdCB0B2roDpRAfSUPXi78jt9KIq17RbFGjM5oIixgYdPDWc Udrx1JczmNbvMFu7LDJ0QV4DSiQEPmJtlwUeVXsV72faR72OMCTnheiOFNRhNXEJxJmh L7zQwe/2xyhr/DMtMbQaSCeoOiGjyUKdChWGLufwLqC4PiaLj04U+rSAOZcVNI6DIbjD 254F2gaQaY6G7rjreLqLdmIwukrR+UHgS/hJ5HRtFlhpe8siG0qH1pKtHQU/LI3k8hnT /vMQ== X-Forwarded-Encrypted: i=1; AJvYcCXbXOcoMmzT9VIMIZXPCY22KXnUNXESTDeuu+0i8FWdTdkViNc5KTTCLexzvHMIRHAUovBCiTauPnLtgoo=@vger.kernel.org X-Gm-Message-State: AOJu0YxSOz0Yaz0BHLAWZFNWJ6mQXG/bk6YkD4JxyOiiqS1sqAyozlva P3uleIVBHdhUmpXwPX+aPmJtl3/LRnN54+/4umeNVB1v+q15pJ3MP1pVCEjlrBDcQZM= X-Gm-Gg: ATEYQzypA4byMJTAaIalupAbIUpmXlYutsQwa4SiC4NafhnaLDWcaDAZUOTKM3egHcw t6obPrVYhwD2DksGgCb3oTtvzBmbVmttWLk0VM1QSb8HZF7Q8fDFvqJaJIypCU6BzoyymWZrcws MFNZ4E9HS/HmnMe6Go7CbJp0/eBJ9V1FKDGydztYQalBuk2zZbHOKQpOhtxO3CeN6IQt/oSIPTS eD1hG3LJKAEMbU0os4YI/TMR/rrB0dFZFz4rOWUPYqdW4yEDYYnHqtNOjZa1HP9gQauCB4x/RCP 8I8DpLS96P8vVn8GHBlHeOxFewxylSMskeqE8KMKIlsSz9kq5lSM/eY6FnvkyaVX7Mam4H4YlsE sgj6+m6WZ7Yl+uFKcNQXuaYMPi4HbxjpjFT/OFJj7Zmc7To5RXTGt7qDx7/36Uq2HePBI57fiXf osQbGiwtSUonpMAOOQHBI= X-Received: by 2002:a17:902:ef46:b0:2ae:3b36:23e7 with SMTP id d9443c01a7336-2ae82398d80mr56455605ad.16.1772896144073; Sat, 07 Mar 2026 07:09:04 -0800 (PST) Received: from localhost ([149.28.151.93]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f8baa3sm58418835ad.65.2026.03.07.07.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 07:09:03 -0800 (PST) Date: Sat, 7 Mar 2026 23:08:57 +0800 From: Chris Down To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Matthew Wilcox , kernel-team@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 2/3] mm/huge_memory: Prevent huge zeropage refcount corruption in PMD move Message-ID: References: <6147cf80-9d02-4c5c-ab81-8cb9b00044f0@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <6147cf80-9d02-4c5c-ab81-8cb9b00044f0@kernel.org> User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) David Hildenbrand (Arm) writes: >Please squash that patch directly in #1. > >It doesn't make sense to leave something partially fixed in #1. It's >been completely broken from the start. folio_mk_pmd() should never have >been used. The reason was to make sure that in theory the correct trees can be updated based on Fixes: for each. But I agree that it probably doesn't really matter. > >Apart from that, the end results LGTM, thanks