From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B1123ABAA for ; Sun, 22 Mar 2026 08:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774169405; cv=none; b=U5808y/tVL6kyygcONZLjXTBW2uL9TUUSPqY+FYDya3s7AFTQTQ3RYPAjsiWlL6m6e9yRmvFOyLCU3+BSNq2r7uyoA5S2jSGV+Z1ZDJA7zwj906ZFAlPNg1cIfk9e0RpRvSB5R37XMGrh6LPfcEyPiVDKLLJN8vm7wtjZg5cnu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774169405; c=relaxed/simple; bh=YfbGDMWbxpye+5Q8O0GAkDHciD4xhqX/DIs5j9dtYrI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HjV2IwwbpTc5U37NXlwLtnDAJln0p7sXpFY1yyJvxxahFqX2+RwozfJbK6nyFfNVEhS2CKvbBK+BJ95T2LSMCxwI6PLcGmcWTghjQMdXItxItfXqBhzQEaGWn0Emyxv3SrxQsqF0VZGp+O31qV5CjUuNKJ+bhmWayDqh3AC3S08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=T8gkuxl4; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="T8gkuxl4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1774169402; bh=2wyAYSPGXmflLvzdL7DWraDibq2iZoPh7AdwJ+/B2v4=; h=From:Message-ID:From; b=T8gkuxl4lQRgo7IvFYh2OL9RVsKnBMGWxtMJrHWqBLsQyG2SQ50y1Qey13QzGW7Zi fPavmqyQIOVMtrMthBum7poQhpP56V9OXxS/QVIfI6RA2bcMtz5686m3rQ5OUIvfqT Y+Y1ujtROMQAR0Do+yyGRaqyw9BbH5uUC710l7ng= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 6A5EEC0A40; Sun, 22 Mar 2026 09:50:02 +0100 (CET) Date: Sun, 22 Mar 2026 09:50:00 +0100 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kernel@vger.kernel.org, "Maciej W. Rozycki" Subject: Re: [PATCH v2] tools/nolibc: MIPS: fix clobbers of 'lo' and 'hi' registers on different ISAs Message-ID: References: <20260317-nolibc-mips-clobber-v2-1-5b9a97761a9e@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260317-nolibc-mips-clobber-v2-1-5b9a97761a9e@linutronix.de> On Tue, Mar 17, 2026 at 09:40:36AM +0100, Thomas Weißschuh wrote: > All MIPS ISAs before r6 use the 'lo' and 'hi' special registers. > These are clobbered by system calls and need to be marked as such to > avoid miscompilations. Currently nolibc ties the clobbers to the ABI. > But this is wrong and leads to ISA<->ABI combinations which are not > handled correctly, leading to compiler errors or miscompilations. > > Handle all different combinations of ABI and ISA. > > Fixes: a6a2a8a42972 ("tools/nolibc: MIPS: add support for N64 and N32 ABIs") > Fixes: 66b6f755ad45 ("rcutorture: Import a copy of nolibc") > Suggested-by: Maciej W. Rozycki > Link: https://lore.kernel.org/lkml/alpine.DEB.2.21.2603141744240.55200@angie.orcam.me.uk/ > Signed-off-by: Thomas Weißschuh Looks clean, thank you Thomas & Maciej! Acked-by: Willy Tarreau Willy