From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A748F478E5E for ; Wed, 13 May 2026 15:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778684968; cv=none; b=sWgJ7FxeA1JOPIDbtdnpvt1WTFcDpVsUphfkIpBX732s5PiK7TscXLfy33+llTd9MbPxMgMIxSmnGr5Q5h6OXKamEwUnx0OP2itAB+5pVaOR3Mv/+q5rdkuCmxDImjt0KyHl+IWoEl0+SK1FHWv3NAIDD++0zTmczN081w8O/JY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778684968; c=relaxed/simple; bh=G4SWJdH8lfXq/Q55qE5sancsJQ5dvaiL1/ql5G+w7cg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=r9SCzSju7LtXhMDedNbPNSyRXcUbfgG4nqqELAh3YQH8Ax1Wa9gEMwrP4mb+tFxP8D4SR40eHLOFPu8+2YMx7OVxk00TO2HnXsml552hv5pvHyOPhYglshYXLmdUv1ipsUwS2ugWMBmO5RJVpQIOL6fE1ZQmvNKMm67Z5NL1Hd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cB9U0Ih6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aRBF2G9e; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cB9U0Ih6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aRBF2G9e" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64DF2o4B3474770 for ; Wed, 13 May 2026 15:09:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j0hB+em0HhLvyCaV2q9m7G7h2H9vaqkFqmGjp5daVGU=; b=cB9U0Ih6c22UxiBH PO/hyD4elkmS7CcgC/FwoeTSgjYN9OHqqOSSOMrm7oq+KnPdjokxYKSTKQ9WbPDl zQcZ9YUtQ6q4Rej8lsHH3aABaF9LdlW9aLT4Q7cKjp5DJEwPNXkN6m8RbimDGefz R6eUWhpJUb1Th5UBykxAodBRbBcZ7lBftIlGHoxTlnba/0l4YXweAooM2ZtzyD1t Z+ipbUgVyrs7rovkHMvl8n0JkYPIlF4Iavq5Qgb1Vv6qtUybwHDZrEhCZ9Im8eMD fzBGIYB9FKgGrtsFTcMkwilYNjLaJcqX5lxHDNPVdAV2O/GTe9YksSGBl60WcZa3 H/DKOQ== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4p419fvr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 15:09:26 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-575b9b7cc20so300733e0c.3 for ; Wed, 13 May 2026 08:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778684966; x=1779289766; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=j0hB+em0HhLvyCaV2q9m7G7h2H9vaqkFqmGjp5daVGU=; b=aRBF2G9erJ68RGU/2jdelBn9rAa5kuE7FyFkI+ysSDxebCyGliFgOZ7szd101KhpHj fbyxd2VPsll8XLmGCWF3BZasWVXJ+9/IYDmiyXFQQOBHiyWv8YclqKSxgKkbzMtJjITk wsYVZ/oAK45ex6yRLipuGm1bPnXKPaZVt5770cCaqxDMVKMPQRLHhX8FmfrYWe/qNFhW zwS6ZIAAR57pg9NQGCD2jPRy9LsLDsdyTmeFE3T/cU4BU3/RaO+lVRt4MMldLZ+t+ydl EFgEaDVv4hr8JCbgQwLiWL2sTSA5nCKXDuty9fVwbJGaEef2z9BOg8CpiDTDif5ev0DW z3ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778684966; x=1779289766; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j0hB+em0HhLvyCaV2q9m7G7h2H9vaqkFqmGjp5daVGU=; b=VV8tSCiLHYDFdzfDc3BR5oL6+dCzS8jPs6VDi2xK1l0it2TPJzqXCfLNxZJy0h1QcL ecMyj/W6A8NlaKcdQ99hKyaG+xEfPG4Qz/3dcRdteQ+JcUhpcocQPbhv//ORD3SFaRNS sLx6l7QOL7tbj8efhd39PKUeOC6yIVP1FTqs5mdOuS3KWYo5AesJW76I9V9iu6XTCX5D ohVOdTg3stesjXAxC+7bQVSWCYAY31n7s9NJb9j/gfl9RKLFFIfDLRenKoNeXv5zu055 65iNL7AOzNmaN/reliDq33YInhAfJi0JEjwWs7GyTGdpQnj2Nng2O3moA+yLr+RaIdaR o26g== X-Forwarded-Encrypted: i=1; AFNElJ8hD8qv1mMcKz54h86WsYQfvPiXoVJ/GLgIbJYOUvmxvSjUWErwyladFudtEm2H+hsG3UaaRaDvmA7pEcw=@vger.kernel.org X-Gm-Message-State: AOJu0YyHq4zdiekSGg3LqTFX1ZrZkK1TR39yQnFhp59R8ofvAmSJrxoO 3yOgbgx0mYKxa19ZC0bcqN7ORVLa6hAeeLGn94ewQd+DWKY2e23ZGTWvKIJmrTarZMRVmUkf63A gafYFUWLf5m9dMDS5SEgREvwnfsWCA4rnTbHt+kSZvtpJ6HZ5ApcYM6H0PBeUXFA3jx8= X-Gm-Gg: Acq92OHSW9d6tE0oMtyImVlG3jEDidkhr9rAPLY8mJkOOtP89zNosSVLNsT+UBMbxsM 0VcxBLtbTGV0cdzUDAbjHTikPZSok3Htg7Dda6PjDA9XYvNeqVHb9t8noXCqsVuBa3ywXvDeMVq 1QPEv+fPBC0hkrYC4QXCxa+4cIHXilpSUOSf9NSW8vvttix19VeJxw12oX24fpKalJxRtwXZVlb edqOphiqn38m5CwMGy8WUITjHfDk8x6PZXvSPUket/MBcoovt1y6u2rC/veUl2M8yXfrKZH57Vm WHda0aLdGE4i2dqd8HMSwbQ7s1KCpfme2iktsXgp7T39n7BD+a56PoP2uZWOprgavcWomXgdnyK aasIyBrnGdydHxpHWeMuIEDnyCO04xj8Di6lrmpM6vjntoZvZcSbVekSVAZhv0cec3wKsAmLq0W ZTESs= X-Received: by 2002:a05:6122:1d9:b0:575:1954:439d with SMTP id 71dfb90a1353d-575e719b22bmr541768e0c.3.1778684966042; Wed, 13 May 2026 08:09:26 -0700 (PDT) X-Received: by 2002:a05:6122:1d9:b0:575:1954:439d with SMTP id 71dfb90a1353d-575e719b22bmr541715e0c.3.1778684964835; Wed, 13 May 2026 08:09:24 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bcfebf0ab11sm502646366b.62.2026.05.13.08.09.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 08:09:24 -0700 (PDT) Message-ID: Date: Wed, 13 May 2026 17:09:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 8/8] arm64: dts: qcom: Add Microsoft Surface Pro 12in To: Harrison Vanderbyl , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <67c50d27e133774e0a4edc17403e4218ddd86efd.1778498477.git.harrison.vanderbyl@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <67c50d27e133774e0a4edc17403e4218ddd86efd.1778498477.git.harrison.vanderbyl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=df+wG3Xe c=1 sm=1 tr=0 ts=6a049426 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=B2TC37y4lXDFjVec2ukA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE1NSBTYWx0ZWRfX4pOYzU+Fs/Am gvmHP5KWeCsjKj3EmWZXz5FBH30v96ovqVFok6qyayj/ASzlUn60mOBMxjTzqvecwRq94MiPZA3 XHjwKnmltaG/VMY9j0OPCxiYRCWghzd4LnGvht8+ZCwS+XmWMKKvU8ZZgMLIi06TLTFzvmrX9Ru wzuGSHqE5ELiMpc/M/OT4WyjhORGUUumSuXt2IRIYaSuz/QLalgew6MCSMhrFFCdrByzyFTWxJ0 PLoGagFOEEIQZZyj8G8hvCjU0q5CvYBJg+bSq4ag/nnXIPb2JHILCMa1yoFY4PBfrtBpOg9K0P/ xdM2OKUU6bVGY8zwUCsFFVPmsXklVVpC3+G/74l0owg+MJmeVbyZ1dRzp0+0l6CqSdJWt33oFCi q5qLTA01Dcjirj9aMRNPudW16YdQ6X1Zqtq09NvzCpxShFshy6kqzyF4SAFyzvldx3kcemeil9O zktkwVhZxDgxP7U0GZQ== X-Proofpoint-GUID: n3EwhsnLdTFeCgEHEb4ipdMtA0AOtgRE X-Proofpoint-ORIG-GUID: n3EwhsnLdTFeCgEHEb4ipdMtA0AOtgRE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_01,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130155 On 5/11/26 4:40 PM, Harrison Vanderbyl wrote: > Initial device tree for Microsoft Surface Pro 12in [...] > + pmic-glink { > + compatible = "qcom,x1e80100-pmic-glink", > + "qcom,sm8550-pmic-glink", > + "qcom,pmic-glink"; > + #address-cells = <1>; > + #size-cells = <0>; > + orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>, > + <&tlmm 123 GPIO_ACTIVE_HIGH>; Please align the "s and + va-dai-link { > + link-name = "VA Capture"; > + > + cpu { > + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>; > + }; > + > + codec { > + sound-dai = <&lpass_vamacro 0>; > + }; 'co'dec < 'cp'u [...] > +&mdss_dp3 { > + /delete-property/ #sound-dai-cells; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp0_hpd_default>; Please make sure to keep this order, file-wide: property-n property-names [...] > +&ufs_mem_hc { > + status = "okay"; Let's keep status uniformly the last property, preceded by a \n [...] > +&usb_1_ss0 { > + status = "okay"; > + dr_mode = "host"; You declared the Type-C ports as dual-role - does it work if you skip this bit? Konrad