From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Lu, Brent" <brent.lu@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, "Zhi, Yong" <yong.zhi@intel.com>,
"Bhat, Uday M" <uday.m.bhat@intel.com>,
Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
Arnd Bergmann <arnd@arndb.de>,
"Song, Gongjun" <gongjun.song@intel.com>,
Terry Cheong <htcheong@chromium.org>,
"Chiang, Mac" <mac.chiang@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
ye xingchen <ye.xingchen@zte.com.cn>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ASoC: Intel: sof_rt5682: add jsl_rt5650 board config
Date: Wed, 12 Jul 2023 12:20:24 +0200 [thread overview]
Message-ID: <ab085fff-ade7-02b1-22e0-acba8e6c1846@linux.intel.com> (raw)
In-Reply-To: <CY5PR11MB6257F77DBF1D123FAD0DF4689736A@CY5PR11MB6257.namprd11.prod.outlook.com>
On 7/12/23 08:15, Lu, Brent wrote:
>>> + {
>>> + .id = "10EC5650",
>>> + .drv_name = "jsl_rt5650",
>>> + .machine_quirk = snd_soc_acpi_codec_list,
>>> + .quirk_data = &rt5650_spk,
>>> + .sof_tplg_filename = "sof-jsl-rt5650-dual.tplg",
>>
>> what does 'dual' mean in this context? it's not something we've used before
>> so a comment would be needed IMHO.
>>
>> two DAIs, two codecs?
>
> Dual I2S. Should we remove it? Just sof-jsl-rt5650.tplg?
that would be my preference, we have lots of configurations with 2 I2S
and never mention it in the topology file name. 'dual' sounds more
confusing than helping here.
The rest of the patch is fine.
next prev parent reply other threads:[~2023-07-12 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 10:08 Brent Lu
2023-07-12 6:12 ` Pierre-Louis Bossart
2023-07-12 6:15 ` Lu, Brent
2023-07-12 10:20 ` Pierre-Louis Bossart [this message]
2023-07-12 11:02 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab085fff-ade7-02b1-22e0-acba8e6c1846@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dharageswari.r@intel.com \
--cc=gongjun.song@intel.com \
--cc=htcheong@chromium.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=uday.m.bhat@intel.com \
--cc=ye.xingchen@zte.com.cn \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®