mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Denis Benato <denis.benato@linux.dev>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Hans de Goede" <hansg@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Linux ACPI" <linux-acpi@vger.kernel.org>,
	platform-driver-x86@vger.kernel.org,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D. Jones" <luke@ljones.dev>,
	"João Paulo Rechi Vita" <jprvita@gmail.com>
Subject: Re: [PATCH v1 2/4] platform/x86: asus-laptop: Convert ACPI driver to a platform one
Date: Mon, 2 Mar 2026 13:21:45 +0200 (EET)	[thread overview]
Message-ID: <ab094189-b333-895a-7238-f20050966d37@linux.intel.com> (raw)
In-Reply-To: <c9697592-c70b-4ef8-864f-213b5ea4782d@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On Sat, 28 Feb 2026, Denis Benato wrote:
> On 2/28/26 16:11, Rafael J. Wysocki wrote:
> > From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> >
> > In all cases in which a struct acpi_driver is used for binding a driver
> > to an ACPI device object, a corresponding platform device is created by
> > the ACPI core and that device is regarded as a proper representation of
> > underlying hardware.  Accordingly, a struct platform_driver should be
> > used by driver code to bind to that device.  There are multiple reasons
> > why drivers should not bind directly to ACPI device objects [1].
> >
> > Overall, it is better to bind drivers to platform devices than to their
> > ACPI companions, so convert the Asus laptop ACPI driver to a platform
> > one.
> >
> > While this is not expected to alter functionality, it changes sysfs
> > layout and so it will be visible to user space.
>
> Alright I will take a look if asus-linux software is affected and act accordingly.
> How much time do I have?

Please take your time, we don't need to rush things, especially 
refactoring when there are open questions to answer.

> Thanks. 
> > Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/ [1]
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Reviewed-by: Denis Benato <denis.benato@linux.dev>

-- 
 i.

  parent reply	other threads:[~2026-03-02 11:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28 15:09 [PATCH v1 0/4] platform/x86: asus: Bind drivers to platform devices instead of ACPI ones Rafael J. Wysocki
2026-02-28 15:10 ` [PATCH v1 1/4] platform/x86: asus-laptop: Register ACPI notify handler directly Rafael J. Wysocki
2026-02-28 16:59   ` Denis Benato
2026-02-28 15:11 ` [PATCH v1 2/4] platform/x86: asus-laptop: Convert ACPI driver to a platform one Rafael J. Wysocki
2026-02-28 17:01   ` Denis Benato
2026-03-01 13:08     ` Rafael J. Wysocki
2026-03-02 11:21     ` Ilpo Järvinen [this message]
2026-03-31  8:14     ` Ilpo Järvinen
2026-03-31 19:19       ` Denis Benato
2026-02-28 15:12 ` [PATCH v1 3/4] platform/x86: asus-wireless: Register ACPI notify handler directly Rafael J. Wysocki
2026-02-28 17:02   ` Denis Benato
2026-02-28 15:12 ` [PATCH v1 4/4] platform/x86: asus-wireless: Convert ACPI driver to a platform one Rafael J. Wysocki
2026-02-28 17:02   ` Denis Benato
2026-04-07  9:49   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab094189-b333-895a-7238-f20050966d37@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=corentin.chary@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=hansg@kernel.org \
    --cc=jprvita@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®