From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB4C371D03 for ; Fri, 20 Mar 2026 08:29:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773995356; cv=none; b=XYZ2w0OAtJUQCf4mySVc8i/zFYuv5IG/s28F8dxZkFpPDiMyLqDUa9iyuWVXIoCiaI7nO79UOllodEs87lA48BP3vPMKDj+lhLngUd5k9YIgw2L8uGoPoGw7Go6JCjiF548DAHTot0aQf2T2XTkLolM0S92net+BZcawIMi66HM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773995356; c=relaxed/simple; bh=SEx4lyvi/eOHrpVqLdiKesdACMhBb/GHogPdO6mnEds=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fWGt4MEdxsB6cRlOmLo7VZiP1WL74OeHGwNVSh3nyt7Mw1Aa8BqXX8UzLOZsJNmO1/4pLyiTVBGbP/jRUJR358B77ETZC1WzIF1p9z8oGj2j3qS9MoUWIt0ZZ7kWfAC5CCwZB7aCUY6wKHCmy+mJylZquFX5RRS5rATyOeiPeQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s2t36hw0; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s2t36hw0" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486fda2a389so2356165e9.1 for ; Fri, 20 Mar 2026 01:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773995354; x=1774600154; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U9yuP5I9+Z4GLNb1XV6GtNUUDpta/L1s+WH94C7rXg8=; b=s2t36hw0yMyXYsvgfgF/TOMWT+ayEjMu2INk/lV54cU14cifUf/Q0iPmjV81Zbflag bo1J5TnUG/fIUXbfstGjXtQ/ihKAwARiFdPAHkFyQslDGvkby2Izi9KABn0HWHsDB3hQ /0mp4PzYiQPcv1CeOan/1kEbftYp+1xY3nPGawMJX7mAKTVOImhAWDCVfLrexdJcSCI0 9zmvJGRAj9meKgFO8AGlz6Hcyxz4LIlBZ9Si4S+6BZv1yCvooin0zyMUcKYhGjmbkwik Ho39sW9Vtf7GJZuPE1wAISdQmmvYLh7jumLOgX+QqzDCKIOrJs5eeKhRtOwencMePBNV UapQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773995354; x=1774600154; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U9yuP5I9+Z4GLNb1XV6GtNUUDpta/L1s+WH94C7rXg8=; b=Batx1tlLvJlAlsXbQUx6sYzKfvnY2l0rmo5lPa4r5a5OPafGQVnjmG7wimrL2PoOeM rtxpwVUWLtN0gPLYC4HHcAWEoFxxxfN+qnJFuKB31wday6ejN/TyaNnPw86XLY7CXv23 Qjmh9LnKUZw5JKRK8x4L+q7jH0c97/E0Dw50zz+VEU1b6MvYnVYMvrpaohYoo4wREAhB x4YnRsJo+Z5yvVAiJHoVq+83Tgeqv8nkksJzjjscpOI6H+Z52/jV5NjdvMV5hLT5lcPe kVnjepwatcIsTO07trs8ae3cfpphAbRaBDT/mfrB1P/zUtPQs9deB0l87CuB7TPau8R6 9juQ== X-Forwarded-Encrypted: i=1; AJvYcCUb4nR08OSPS7Sn/WzQBtDYZymwekxHC2Z1C4Yy0MLJCq1Sd9Q26FEjWRqODYMnmUpNUapCuzGfA4k8fhQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyKFr+7HJ1slUYSCI2TLKN3rwGZEXs+qOkRkaj4jWseLSGD1xJC 2KjS/2Jtyg0hBrsEcTKEcfCL5stbIHECmXFENQ3DYvgJYrZRXbBv+0bdiWMfU/Kc7g0= X-Gm-Gg: ATEYQzxOwLDpX6YuH/Vc4k/4vqE/cVHQz872LCA6n103zHnv25ogiwFN/RAMeNEMbOH HjkqA37huWJQVsAtgwsI8Hei8ur81PmjOtl50TAU/3v5Q5wYpN5wJUwKL+wpxr53ZHF0aIahc2G Zwewjjxe4iYOySEW+iZzYn4+JsNITnw9iVdHZt8LUhEvGbE0+/iN/eSfON4af4esfBuEhrwdlkM DGOSDOCN4NHiFxNqNHYgZImUUReOO8l1U9lI4HrgMtXmxd1n1hMuyy7vNCXt14M3YZ1VFjsGq0z PofzzkfdhyaKOmARhNZYHz6xQ7224yofxwIxwaZFBdFpVY4XsXi2O6yUfRpeu44Ujq6n575cq2e TbtHsSQUfRVsnMSgAaRawLAZwRoe9LqU/fHDGaiYSuPlNbpgWNcPQMclfheIinz2c5XaEzlrqgD CgPCa2MVJSU+rYWUl4w4FqM9ADE2Lk X-Received: by 2002:a05:600c:8119:b0:485:54cc:2e7c with SMTP id 5b1f17b1804b1-486ff034137mr25205295e9.24.1773995353693; Fri, 20 Mar 2026 01:29:13 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64703343sm4243982f8f.19.2026.03.20.01.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 01:29:13 -0700 (PDT) Date: Fri, 20 Mar 2026 11:29:10 +0300 From: Dan Carpenter To: Lin YuChen Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: initialize le_tmp64 in rtw_BIP_verify() Message-ID: References: <20260319170312.71408-1-starpt.official@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319170312.71408-1-starpt.official@gmail.com> On Fri, Mar 20, 2026 at 01:03:12AM +0800, Lin YuChen wrote: > Initialize le_tmp64 to zero in rtw_BIP_verify() to prevent using > uninitialized data. > > Smatch warns that only 6 bytes are copied to this 8-byte (u64) > variable, leaving the last two bytes uninitialized: > > drivers/staging/rtl8723bs/core/rtw_security.c:1308 rtw_BIP_verify() > warn: not copying enough bytes for '&le_tmp64' (8 vs 6 bytes) > > Initializing the variable at the start of the function fixes this > warning and ensures predictable behavior. > > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/linux-staging/abvwIQh0CHTp4wNJ@stanley.mountain/ > Signed-off-by: Lin YuChen > --- Add a Fixes tag? Otherwise, it looks good. regards, dan carpenter