From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BE838237D for ; Fri, 20 Mar 2026 09:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773999456; cv=none; b=KXpMUclv94ocnqg7rY35OgtAysjYAsv2Kl1HOddeS2PQHafmUoZfqqnGVte+Xd1gUAtQSXki5BYfcaNziKLthJi7tMpJfv6n8EXFI8e3Zdl4lAYwv2FJYqNrQEBvOEX73Q5UbFmzkbGZg+OOOXva4LYntIJnCCmkNjSuTgb+Ujk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773999456; c=relaxed/simple; bh=/RroFt/aDThaig1a7ciA5DMyFlmPG1G0vZnwb7/wNb0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XuKyASwePRmy9zh3laktSaYurNRcJHX8PflNgM0PdAeGEowTucWARga4p97ASRLsUHxm2wuSj+T94irTXAZx8h3MrnUE13TKGBFghmBOOrgCVSN5w4ZKo31J7AJ/yEtVF78n30qSViNyhBzslr7uargzaKo8bTrVMrKvqRt98eY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mLI4IOsN; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mLI4IOsN" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4853e1ce427so3758555e9.3 for ; Fri, 20 Mar 2026 02:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773999448; x=1774604248; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eD4dBMvjtmZ/uGxmRy1So/8YVPy0MK5aKa2M09OXdww=; b=mLI4IOsNodpyfdYPs/3nAj3/qLlMYjxybpdfUFRWNXrxvvxK/uU7FOd7jO+SLzEdeX x9ryKe+SJkhW5gzAz/d/YNEiXfKBgafuUevD51gnAI4N3pnst87cQhUMsHWropHiH0Xi J4JrNQyWlXDjJzWYibHd+2zTtHJC9Xj9BfADpbARMaFAcvAhAGYpDvdvRheR9u3fnZly Fqxsi7uEoCNiCgTSJDwxQYa/3QY2wlP6Z6ttssdBp+pio968FIw3+HgXHPScguXoeS6J 0PQvj3djI/c7VgZCQgo7mj0Dqw8RPeW2jyXUxqIFxS/m5Fx+QkyoVv71Af6aFfu1kHCd wAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773999448; x=1774604248; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eD4dBMvjtmZ/uGxmRy1So/8YVPy0MK5aKa2M09OXdww=; b=JWPqeoEdh1xSZ0Jw7xeWrqR4p/zfBL0fi9goGx7ikiE/gHdx1v7XCOjLy3v7ZYl1HT yYM/zkh+G+8wDHWppdSNnLH1anFFDl2xIHDtwEApRyopBnsmMNjGoPul6dTwnxsoBKm3 BPPUrOxpOSt64rlyn4zq97/InucMsW2X+K0uE4nkc+Ciu2nZmouQVmKDG7uJxNqgq/A/ V24TuaUp5JXCRCUAbLXSM4tHVTx5qo74unvvN3u7jZt51MckimXe9MN0bnIoCH7ymgER 8+dHmHovD4YxLaMZIi7u1duSIOQlLDd1/c7noB+cGbz6qCN1WpfN+y4UzbYxveGhGSfN o5gg== X-Forwarded-Encrypted: i=1; AJvYcCXxi/AzAetYzOJZLavA2DaWF6MI7YowaisrXBpn9UuV5hLGxkfx8aDctDytxUAuxUnkMcKAQLBDQ53X1Cc=@vger.kernel.org X-Gm-Message-State: AOJu0YwBrg8Yqch5RnLrvUjG1PWfqqwFgqDyTDebr52wDX80v+LGVfuO 4f9ERaBkhllYgXogal+dH4gCL0HSugO9pUk5QY/H0mWbVyv7oRHJ80SOVQpNeQNjczE= X-Gm-Gg: ATEYQzwIONK5W1s+WMhvsTs/F1uDqhnppUsO4mijBizajmCMJVOsfityU87gO/Bd4a1 WwAI3A0GhZZYTQas4TJSCb3MmhJkZLbHcsy90Sf+ok4Y17lwrDnY0RfpNzyhyAmo3YQgZwviM3E YJYc0HCpg1JsSWGhx/SBa2eWKgd3JtqO7W1f2JCqQzorBnaXFXWZjZWBTGd0XxpA9jKnd/DONMz yp4QJIFWWK3fdpAQgwBEYQsMiHwueIXWW5e4Y3CmdKsEe/H0DGiajIm/9DlXtNJuYIPGMeNm/QE CJnZ5kDfu94AUHIib1CTDHfZUhfAyPS0MvLEjvB/KDlCCoNmNVc6fKCeowCCtAlNw7ApxHIXAbt 3jqx4ItDMvDOtC7SZfuJyxt1CZRlGUoj5vrOemoI82Xb6Lw9dKNmiVdOJtdU8wZXdSLevpYC1u/ kUB8bamvWrSwuoweksC8bGwfAeaFRA X-Received: by 2002:a05:600c:17d8:b0:483:703e:4ad9 with SMTP id 5b1f17b1804b1-486ff0291d7mr19670865e9.19.1773999447715; Fri, 20 Mar 2026 02:37:27 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae048sm5267437f8f.1.2026.03.20.02.37.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 02:37:27 -0700 (PDT) Date: Fri, 20 Mar 2026 12:37:24 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: av7110: remove print_time() dead code Message-ID: References: <20260320-av7110-remove-print-time-v1-1-05402287078a.ref@yahoo.pl> <20260320-av7110-remove-print-time-v1-1-05402287078a@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260320-av7110-remove-print-time-v1-1-05402287078a@yahoo.pl> On Fri, Mar 20, 2026 at 09:46:15AM +0100, Tomasz Unger wrote: > The DEBUG_TIMING macro is commented out and can never be defined, > making the print_time() function body always empty. Remove the > commented-out macro, the unused function definition and all its > call sites as they serve no purpose. > > Signed-off-by: Tomasz Unger > --- > Checked with scripts/checkpatch.pl - no errors, no warnings. > Compiled and verified by loading the module in QEMU. > --- > drivers/staging/media/av7110/av7110.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c > index 607992100baf..9f4ed1e24b17 100644 > --- a/drivers/staging/media/av7110/av7110.c > +++ b/drivers/staging/media/av7110/av7110.c > @@ -314,17 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len, > } > } > > -//#define DEBUG_TIMING > -static inline void print_time(char *s) > -{ > -#ifdef DEBUG_TIMING > - struct timespec64 ts; > - > - ktime_get_real_ts64(&ts); > - pr_info("%s(): %ptSp\n", s, &ts); > -#endif > -} > - > #define DEBI_READ 0 > #define DEBI_WRITE 1 > static inline void start_debi_dma(struct av7110 *av7110, int dir, > @@ -353,7 +342,6 @@ static void debiirq(struct tasklet_struct *t) > int handle = (type >> 8) & 0x1f; > unsigned int xfer = 0; > > - print_time("debi"); > dprintk(4, "type 0x%04x\n", type); > > if (type == -1) { > @@ -473,7 +461,6 @@ static void gpioirq(struct tasklet_struct *t) > txbuf = irdebi(av7110, DEBINOSWAP, TX_BUFF, 0, 2); > len = (av7110->debilen + 3) & ~3; > > - print_time("gpio"); > dprintk(8, "GPIO0 irq 0x%04x %d\n", av7110->debitype, av7110->debilen); > > switch (av7110->debitype & 0xff) { > @@ -2785,7 +2772,6 @@ static void av7110_irq(struct saa7146_dev *dev, u32 *isr) > { > struct av7110 *av7110 = dev->ext_priv; > > - //print_time("av7110_irq"); > > /* Note: Don't try to handle the DEBI error irq (MASK_18), in Delete the extra blank line as well. regards, dan carpenter