From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Jonas Gorski <jonas.gorski@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: b53: fix bcm63xx RGMII port link adjustment
Date: Mon, 3 Nov 2025 08:49:12 -0800 [thread overview]
Message-ID: <ab0e31be-47a1-453f-9d73-26b8d02bd882@broadcom.com> (raw)
In-Reply-To: <20251101132807.50419-3-jonas.gorski@gmail.com>
On 11/1/25 06:28, Jonas Gorski wrote:
> BCM63XX's switch does not support MDIO scanning of external phys, so its
> MACs needs to be manually configured for autonegotiated link speeds.
>
> So b53_force_port_config() and b53_force_link() accordingly also when
> mode is MLO_AN_PHY for those ports.
>
> Fixes lower speeds than 1000/full on rgmii ports 4 - 7.
>
> This aligns the behaviour with the old bcm63xx_enetsw driver for those
> ports.
>
> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2025-11-03 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 13:28 [PATCH net 0/2] net: dsa: b53: fix bcm63xx rgmii user ports with speed < 1g Jonas Gorski
2025-11-01 13:28 ` [PATCH net 1/2] net: dsa: b53: fix resetting speed and pause on forced link Jonas Gorski
2025-11-03 16:48 ` Florian Fainelli
2025-11-01 13:28 ` [PATCH net 2/2] net: dsa: b53: fix bcm63xx RGMII port link adjustment Jonas Gorski
2025-11-03 16:49 ` Florian Fainelli [this message]
2025-11-04 1:10 ` [PATCH net 0/2] net: dsa: b53: fix bcm63xx rgmii user ports with speed < 1g patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0e31be-47a1-453f-9d73-26b8d02bd882@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®