From: Mark Salter <msalter@redhat.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org
Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>,
linux-c6x-dev@linux-c6x.org
Subject: Re: [PATCH 02/14] c6x: entry: Remove unneeded need_resched() loop
Date: Wed, 13 Mar 2019 13:21:58 -0400 [thread overview]
Message-ID: <ab0f6cff1dd07ec42f13894d0833fbd506bdc10a.camel@redhat.com> (raw)
In-Reply-To: <20190311224752.8337-3-valentin.schneider@arm.com>
On Mon, 2019-03-11 at 22:47 +0000, Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Mark Salter <msalter@redhat.com>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
> Cc: linux-c6x-dev@linux-c6x.org
> ---
> arch/c6x/kernel/entry.S | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
> index 2721c90b0121..17926e942edb 100644
> --- a/arch/c6x/kernel/entry.S
> +++ b/arch/c6x/kernel/entry.S
> @@ -567,7 +567,6 @@ resume_kernel:
> NOP 4
> [A1] BNOP .S2 restore_all,5
>
> -preempt_schedule:
> GET_THREAD_INFO A2
> LDW .D1T1 *+A2(THREAD_INFO_FLAGS),A1
> #ifdef CONFIG_C6X_BIG_KERNEL
> @@ -584,7 +583,7 @@ preempt_schedule:
> #else
> B .S2 preempt_schedule_irq
> #endif
> - ADDKPC .S2 preempt_schedule,B3,4
> + ADDKPC .S2 restore_all,B3,4
> #endif /* CONFIG_PREEMPT */
>
> ENTRY(enable_exception)
Acked-by: Mark Salter <msalter@redhat.com>
next prev parent reply other threads:[~2019-03-13 17:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 22:47 [PATCH 00/14] entry: preempt_schedule_irq() callers scrub Valentin Schneider
2019-03-11 22:47 ` [PATCH 01/14] sched/core: Fix preempt_schedule() interrupt return comment Valentin Schneider
2019-03-11 22:47 ` [PATCH 02/14] c6x: entry: Remove unneeded need_resched() loop Valentin Schneider
2019-03-13 17:21 ` Mark Salter [this message]
2019-03-11 22:47 ` [PATCH 03/14] csky: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 04/14] h8300: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 05/14] microblaze: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 06/14] MIPS: " Valentin Schneider
2019-03-14 18:13 ` Paul Burton
2019-03-14 18:38 ` Valentin Schneider
2019-05-10 16:16 ` Maciej W. Rozycki
2019-03-15 16:31 ` [PATCH v2] " Valentin Schneider
2019-03-19 23:18 ` Paul Burton
2019-03-11 22:47 ` [PATCH 07/14] nds32: ex-exit: " Valentin Schneider
2019-04-24 7:18 ` Greentime Hu
2019-03-11 22:47 ` [PATCH 08/14] powerpc: entry: " Valentin Schneider
2019-05-03 6:59 ` Michael Ellerman
2019-03-11 22:47 ` [PATCH 09/14] RISC-V: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 10/14] sh: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 11/14] sh64: " Valentin Schneider
2019-03-11 22:47 ` [PATCH 12/14] sparc64: rtrap: " Valentin Schneider
2019-03-11 23:13 ` David Miller
2019-03-12 9:43 ` Valentin Schneider
2019-03-11 22:47 ` [PATCH 13/14] x86/entry: " Valentin Schneider
2019-04-05 13:13 ` [tip:x86/entry] " tip-bot for Valentin Schneider
2019-03-11 22:47 ` [PATCH 14/14] xtensa: entry: " Valentin Schneider
2019-03-12 1:10 ` Max Filippov
2019-03-12 9:45 ` Valentin Schneider
2019-03-12 18:03 ` [PATCH 00/14] entry: preempt_schedule_irq() callers scrub Vineet Gupta
2019-03-12 18:18 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0f6cff1dd07ec42f13894d0833fbd506bdc10a.camel@redhat.com \
--to=msalter@redhat.com \
--cc=jacquiot.aurelien@gmail.com \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®