From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E7F22E2665 for ; Thu, 11 Jun 2026 14:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781188586; cv=none; b=cxAzgrtNljeqPKPE35vpWoK6hYHmQphIuJ90sOi/WUV8jGcs1ltJk2cLzSUKQ7pNh37/1c6EVQXOXrIj0/Ek/nWpyGvg5R+Cni7Cg+2xZnwyCvNDsVe9JtRDE6GstBCF7laIHqlJdK2Rc2EwKP01y2t2qkPyCxsJO6+FOt07l9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781188586; c=relaxed/simple; bh=qnv1fAGXCtLVIjll5OZjfkQjjlkL/oatmHWaQJUPthU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t4TXibYFZT8xQNhoS0gjNWNxc9zsfnvAbViGYpYK0i9abQu6e6s4vmWLrt5kPmIjo4IgJIV3NIHjulI1gh8puKg4MB1F2Kfv4zsqjzYButpmixtgQT2HpwrPNwaqCoZ8n2S/gDD/BGTncgjTe4mjgkpjZ1W5rTdEdzs6aEdST3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xYQzB2DW; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xYQzB2DW" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-6913fb25322so7719589a12.1 for ; Thu, 11 Jun 2026 07:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781188579; x=1781793379; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sr3m8r/i7ovHfjfbNC82N3Y0eijmiJMV+xkhP6DvT20=; b=xYQzB2DWHdtUO2kVszPWBJnsDsb83mivWggIjMOTuCYejfnCtOM0ysSmqmjgJUsfve mUOnxWryQCZEfGjcF16Hk+UKfDYR8UeTW9HUlHSn691NDGwUlJR+cp/Wl8ut+jurud9z CjzhL41ePAlgMNeGOhTDLHcbPYhGqr8c0SxiuqFl5sDJDWxeMRcLRoE1Qduic85+MfXU 19jCHwkHzTxt4HzZuI6bnIyWq5VXcUIc5p6X4I2bfyZ5unS6L0LwCoTJuQKb/tYhPyeo 9tqNxrCUhjKacMZrS46E/+jncAvZrx1GO1tXdgFgb9d1eKLX7E5hxysklo14JLLJXqY8 IrfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781188579; x=1781793379; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sr3m8r/i7ovHfjfbNC82N3Y0eijmiJMV+xkhP6DvT20=; b=dnjMcK4jmzogIV3dyHWQuUNtyuTwfgykDp7rv7hW1WQcjvZHut8oYmW84zDJdAm0OB 9hQN4FbIyrJT/Ex+ojVdRU56wVGcykGDMSQyzuIDZr4kDUh3+se5Ftqfn/FvmZXKROoC F+v8we+LLS5BJPDfazNeWfkb8+Ea1cTz4TAniF8+7lQTTcQtbXoSjsNA0cn2GvtqzBMz mfUJOeF8fyO1UA7c9P/8n1/kCbh964PeSYUI5AKeSYiZnBVbdxzC1h5O3J91g84KprHy NVRQ4/QZs0xuRqQHYGayqPP7tKuaDZnXckO2VYHmJVlcst9HIbOC3DdgOv+zi2pgT7uD u31w== X-Forwarded-Encrypted: i=1; AFNElJ9KmVM0lirH8hVzJrJYvVP238hY3oK5Mi4I91sEYTo2WENaWcABIaBsibyfCt7KKsGk+Yd0Uf50aUwX+RM=@vger.kernel.org X-Gm-Message-State: AOJu0YwddN3cPGR/c9KUozZ6o7/f0zogPOuNrMq3SgRuA2vpLQ+pOb3O WCFqLn0anNCIUmz5Ri/orHcSOd4pZTTpkNFtSTGgKz6rySeMI+4fp2Kf1F+X5wxhHLQ= X-Gm-Gg: Acq92OE4OuEJz6mIdk6u3tCn3Tl5swF/8DsMn+iyLk/NMmwPhyLcB3jPJuBoWLNbrAl sITAq5TmlhArprRd1rS7KkV8sYlY2S8nxlB24l7T6JXyOrydfG0hq9YuJcj0N82k9ydeBg4t9yr OwqtOgXCMz9VL0q564u8XPo7wu3zBvM+K/VRZHB7U8XMaoFTmz+ROlyVZRxaONihqh2hSmTfoYA j2Wj51a76DuWcwYKSHTg/I+xlrfw9htyjBHj8HV/4ttGaFd65VE31HWYVyPd2yYLkC9tg63EmTa THF17QNvpi+DiwgEfIlNeElor4tq4Fq5fXWqjhdy5XVcntE4pGvgO4Vsb3fmOYK0LOusH0vW01J 2D+3XLdLE1ACi2XNbOGJEgtNNQrxVynsuYeO3Q44SjHI/y7DIZYPNW4Kkt4+qKbcshiHtFOJ45O 84y8Auy3xgp3CTg0NULn/xtVM3ULa8uNsGU2uoDt8pxK0cJQ== X-Received: by 2002:a17:906:6a05:b0:bda:8e57:5639 with SMTP id a640c23a62f3a-bfc85e9049dmr144570566b.20.1781188578927; Thu, 11 Jun 2026 07:36:18 -0700 (PDT) Received: from [192.168.0.101] ([109.77.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6914f3b583bsm7011436a12.29.2026.06.11.07.36.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 07:36:18 -0700 (PDT) Message-ID: Date: Thu, 11 Jun 2026 15:36:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] dt-bindings: media: qcom: Add Shikra CAMSS compatible To: Krzysztof Kozlowski , Nihal Kumar Gupta Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Andi Shyti , Bjorn Andersson , Konrad Dybcio , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Suresh Vankadara , Vikram Sharma References: <20260608-shikra-camss-review-v2-0-ca1936bf1219@oss.qualcomm.com> <20260608-shikra-camss-review-v2-1-ca1936bf1219@oss.qualcomm.com> <20260608-reliable-vivid-stork-f4ea6c@quoll> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260608-reliable-vivid-stork-f4ea6c@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/06/2026 21:46, Krzysztof Kozlowski wrote: > On Mon, Jun 08, 2026 at 07:36:38PM +0530, Nihal Kumar Gupta wrote: >> Shikra contains the same Camera Subsystem IP as QCM2290. Document the >> platform-specific compatible string, using qcom,qcm2290-camss as >> fallback. >> >> Unlike QCM2290, Shikra omits the CDM and OPE blocks, requiring only a >> single IOMMU context bank instead of four. >> >> Signed-off-by: Nihal Kumar Gupta >> --- >> .../devicetree/bindings/media/qcom,qcm2290-camss.yaml | 16 +++++++++++++--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> index 391d0f6f67ef5fdfea31dd3683477561516b1556..4f39eefb4898ebc22117407f26cfb4f41deb111b 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> @@ -14,8 +14,11 @@ description: >> >> properties: >> compatible: >> - const: qcom,qcm2290-camss >> - > > Do not remove blank lines. > >> + oneOf: >> + - items: >> + - const: qcom,shikra-camss >> + - const: qcom,qcm2290-camss >> + - const: qcom,qcm2290-camss >> reg: > > With this fixed: > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > @Nihal. If this is the only change you get asked to make, I will just fix this up on application for you. There's no need to v3 the series for this. --- bod