From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FFF2FE056 for ; Fri, 22 May 2026 19:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779477509; cv=none; b=hG4zMpebKqANEE/JP7ngixPEnlrWgvg434jCutkDCs8B80Epcflj5QGQ0Iz9CZzQevZ5P8f1K//aTK2LD1r7vaCTpqbdlTNux03mWgo7DFPT5ZjTJs8sZHIHCaVj5Kxrk5R6qxvPJLAtIpE1+CMG1QW+UoHgIIuwPLQCtbDv+1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779477509; c=relaxed/simple; bh=+M7nz02sQlaSb9wXgPlogCaUPVFoVHtTVt/irwnSluM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xk+8Mll8KUYBJTk8zYTIdPDWELVCcgeO41WdFLv/EA8zYLCZgA1NmQPwuVEBE7bh2YsHJEEl1CJ1QSMUtdaGvDje/6OIMQT0RDkVSF2moDxgeHTwJfNSLtp9LMeFKqkeH3O/sExn5btvsdxAgNDIoKDs4KB/L039JVRbotI8CfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YhOWlhPz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Zlk5My65; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YhOWlhPz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Zlk5My65" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MCGfWq1959859 for ; Fri, 22 May 2026 19:18:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yfeBdn9I839cIzTOxhmlrtqQXwdT6JRrFiSz3uU8HCA=; b=YhOWlhPz7Tiwrvzq Ws7v2hJZsA6WcU+1/L0HmDmpH45ppQdfXCkqhHQR1BO1pJXIsAMtma9wtzIqQsXx MuwxhI/NSQSuiSri+fb+vZXLNIsHBp0jFtQL93KK4bEF6XV6kVI2vgsMcUgEVeVW 3EiU9sFdfF7U3H46r3PiCvi7kmqyotp6QytdKLg8m1dA4A5F5nCJyd7T2TXKYBZh aqUUlbozT4njPvtjj4IjSU9CsMLQ29aPfWujyYVLFFsHnextvVMb3qVpmx14hDoM 5RmHkfLsJvM1HgvO0o5EGaEakyFcZ9FCFHBufImvUg+WB7QkcAU0HGJUcQGlZT81 jga1xg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eahxeu0y6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 19:18:26 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3663cbff31cso18263121a91.2 for ; Fri, 22 May 2026 12:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779477505; x=1780082305; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yfeBdn9I839cIzTOxhmlrtqQXwdT6JRrFiSz3uU8HCA=; b=Zlk5My650i3WGv7CDWIjX5WvW2TElx7oxPsX4HUrDTslSQPh/X4GzrkUKROBgCRuDX dUx7ZRFM8VgnyFQ6B6RnGGCNgJ+zN9G/ns7B1w8tZ8LKIRLiv3x14o7YmS1L6TIUCSXT mjMSdoAfx0JMaF+dKEnV/8q7CZjMxmEDVJuQTgLB8fi8VgE+6hjmdOstrlCu2KgjGU4c QAtqoA2rD3PUjUbxLLj0WZ3u0OEJ6MV3DKMI9wLm0Rak9uA+p05pX9gV3oMeWl8bsEha SpBiowN+bLxFRWz7vT496fTL7L3UuvVZEcYDT1h12KQJZAD/vEApj72GF3B3kEz2CU1z fkwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779477505; x=1780082305; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yfeBdn9I839cIzTOxhmlrtqQXwdT6JRrFiSz3uU8HCA=; b=ETGuDz91+E5uJLzuyrI+9wGVMqsOsE+Q67huoMnzIyXfDzrMyCq4416B+vNYtjebSo aaMIgexkZ4Zv3ug7KVN14fTZsR8xe8o/G288v51oEDmb2T93IF+KlnfQp4THRpIdOMSL oja+qRyRbuo6BzBpLbWqba9o/JxAjc0SiDBhk7SGamrTGQO5etLZ7kMR29bv5EwaKdYt KZg4wymtwX89V3VfQKELlQoCO3jsLHSLRZc5lTeyCqH2s3osWF8uLYuDxpuz/x1vqbIN LqOhvQVYtJuZZaHRTFfMUSYhZJZWXX6U86I+ezyFZZKjaXox8xL0f5aAYHFpuZSHQjvA 3KKg== X-Forwarded-Encrypted: i=1; AFNElJ95og194t2b9K6tcsToQvxNQHwZJcB7g6X297sDpLzKozxZem+OKS31Jkp+JgvGunXMQrI3x/EtNLmMZNM=@vger.kernel.org X-Gm-Message-State: AOJu0YwOaqz1utzNmbi73Q8jdPW/5g4g0Wu/GJo1epr7FU3bHTDX26Ud zym9KPGxwQVkcUks6dBOIRfTfbP1KTjJblC6CzXpbjTZZ3OIaunYpzup8TIIJ3WQpChP7tBs4zI TjHXVqcrA06+f/p+0xydwbSv0BJKnui91tWGHVJzKD5nMlthTsWkH0a6DhgbyyYnpCxk= X-Gm-Gg: Acq92OFX7wIUvE1SS7Eirz21CzPMeHWsm1fkz5SKL4TPQmR3P3sA0YZCt/O1j23ekak N9Yb9j+VedNcUK2oVweniw0SngRz3anriBEOgL8leET9wAyF5jvPw95pcA/iY9i5fSM3TkN0pXl 9kkK9r86yR7FYkauUW1VV4+nR90AQr4MyNgX1cYhCixZ/pSY4Hn4jmEEqnRP4m1j2Kwte386Af2 EX9Y53PYZ7yEKkvYvPeVx1Dl13RN8EFbXnV4vHI0FIbFf+5IalCtpwbglhPL6H6ZIJmiOEBQTt5 pEoE/SpdW3ntpbyzo55HNPUtUlt0wRI3QPg4eEqtRfsa3VGk+P+O2ozRtZH8AP6hCuRf7aLvfT6 y2wJpjdLL4RLvWht8iEWrM9cC1HWUC5eRe5YxWcTq/WYYjV6LUlxI48pswuUj X-Received: by 2002:a17:90b:3d09:b0:367:cb53:7435 with SMTP id 98e67ed59e1d1-36a678478c0mr5065135a91.24.1779477505472; Fri, 22 May 2026 12:18:25 -0700 (PDT) X-Received: by 2002:a17:90b:3d09:b0:367:cb53:7435 with SMTP id 98e67ed59e1d1-36a678478c0mr5065109a91.24.1779477505007; Fri, 22 May 2026 12:18:25 -0700 (PDT) Received: from [192.168.1.6] ([223.230.21.136]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8520560ff8sm2218068a12.24.2026.05.22.12.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 12:18:24 -0700 (PDT) Message-ID: Date: Sat, 23 May 2026 00:48:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com References: <20260522073324.e18bb240b6f6@oss.qualcomm.com> <20260522130459.3411038-1-ajay.nandam@oss.qualcomm.com> <0c408230-61cc-4751-938a-06e715744c66@sirena.org.uk> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <0c408230-61cc-4751-938a-06e715744c66@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDE5MiBTYWx0ZWRfX+bHkH2YXRZg3 1f+UIV6SypmNGzKZmsxvcQMvk70Ewt1qdRSpYhK5iIEzB3xHV8PsGVckABgorsd5hZhdw3Tz+pq WTh9nH7lrLAas9khe90nD4VCa0VQUzS3669yXeAFYX81g6A/avC1hhIlm9VcPsaLk4nbj9te3GK Etx+WudTBk+CI2DAKnY718ojGA5Mv1vLL+oioJbhrSkFbm+ECjZ3tT51Wrvty3yh/ITYevwBHAo /fdC9GLdnLW2ZifYUTzItRar5fR8D2qN+PSPXbvHJGGeFdhL6Jds9F8TPJTCbUQchkFNAPslr9/ /+l0sonEFN6+db/+K2cdNw0NMA+3FcKZRPmNy8obT9z90889AfE06UGyucT9Ydr5fU+ZBdIAGX/ lpN4RbjCJsZHPElpXOwY4EWXdmlGAXnNk5Zh6TfUTeCLv4hZOfumvoI9nqs7BHKMfcOp2TUhzbd 5YeakjYLZlyp6z7OiSQ== X-Proofpoint-GUID: 7BTiZJvw8Rs6kK8jknAp1gBPo5tCUAYD X-Proofpoint-ORIG-GUID: 7BTiZJvw8Rs6kK8jknAp1gBPo5tCUAYD X-Authority-Analysis: v=2.4 cv=ar2CzyZV c=1 sm=1 tr=0 ts=6a10ac02 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=dyxLLOf8pC0bdfPLpLFr6A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=knVCPYfzRBhieiZ2OR0A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_05,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220192 On 5/22/2026 6:47 PM, Mark Brown wrote: > On Fri, May 22, 2026 at 06:34:40PM +0530, Ajay Kumar Nandam wrote: > >> The driver now relies on pm_clk helpers and runtime PM instead of >> manually enabling and disabling macro, dcodec, mclk, npl, and fsgen >> clocks. Runtime suspend and resume handling is delegated to the PM >> core via pm_clk_suspend() and pm_clk_resume(), while existing runtime >> PM callbacks continue to manage regcache state. > >> config SND_SOC_LPASS_WSA_MACRO >> depends on COMMON_CLK >> + depends on PM >> select REGMAP_MMIO >> select SND_SOC_LPASS_MACRO_COMMON >> tristate "Qualcomm WSA Macro in LPASS(Low Power Audio SubSystem)" > > Shouldn't this be PM_CLK? That's what the APIs are actually conditional > on, currently this will work out since PM_CLK depends on PM and HAVE_CLK > but the indirection leaves a window for things to break in future. ACK, agreed with your statement will update in V6 Thanks Ajay Kumar