From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E0820317; Thu, 21 Dec 2023 19:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.104] (178.176.75.203) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Thu, 21 Dec 2023 22:40:40 +0300 Subject: Re: [PATCH net-next v2 13/21] net: ravb: Set config mode in ndo_open and reset mode in ndo_close To: claudiu beznea , , , , , , , , , CC: , , , Claudiu Beznea References: <20231214114600.2451162-1-claudiu.beznea.uj@bp.renesas.com> <20231214114600.2451162-14-claudiu.beznea.uj@bp.renesas.com> <78688143-e777-c98b-01eb-813f0fe67491@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Thu, 21 Dec 2023 22:40:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 12/21/2023 19:09:30 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182285 [Dec 21 2023] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.75.203 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.75.203 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.75.203 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 12/21/2023 19:13:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 12/21/2023 5:11:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 12/17/23 4:15 PM, claudiu beznea wrote: [...] >>> From: Claudiu Beznea >>> >>> As some IP variants switch to reset mode (and thus registers' content is >> >> Register. >> >>> lost) when setting clocks (due to module standby functionality) to be able >>> to implement runtime PM and save more power, set the IP's operation mode to >> >> Operating. >> >>> reset at the end of the probe. Along with it, in the ndo_open API the IP >>> will be switched to configuration, then operational mode. In the ndo_close >>> API, the IP will be switched back to reset mode. This allows implementing >>> runtime PM and, along with it, save more power when the IP is not used. >>> >>> Signed-off-by: Claudiu Beznea >> [..] >> >>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c >>> index db9222fc57c2..31a1f8a83652 100644 >>> --- a/drivers/net/ethernet/renesas/ravb_main.c >>> +++ b/drivers/net/ethernet/renesas/ravb_main.c >> [...] >>> @@ -1821,13 +1845,19 @@ static int ravb_open(struct net_device *ndev) >>> if (info->nc_queues) >>> napi_enable(&priv->napi[RAVB_NC]); >>> >>> + /* Set AVB config mode */ >>> + error = ravb_set_config_mode(ndev); >>> + if (error) >>> + goto out_napi_off; >>> + >> >> I suspect this too belongs in ravb_dmac_init() now... > > What I can do here is to keep PTP/GAC specific settings from > ravb_set_config_mode() in a separate function close to PTP setup and remove > ravb_set_config_mode() at all as ravb_dmac_init() switches anyway the IP to > config mode. But with this I don't know how the PTP/GAC will be influenced My manuals say there are certain limitations (currently reflected in ravb_set_config_mode()) WRT setting CCC.CSEL and CCC.GAC bits. > as I don't have a setup to check it. From my memories, the commit that > introduces the setup of PTP when switching to config mode did this by > intention, so I'm not sure weather playing around with this is the way to > go forward. Do you remember something specific about this? I haven't ever tested PTP, IIRC... [...] MBR, Sergey