From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE26C282DE for ; Wed, 5 Jun 2019 06:16:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C28120673 for ; Wed, 5 Jun 2019 06:16:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbfFEGQh (ORCPT ); Wed, 5 Jun 2019 02:16:37 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53374 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbfFEGQh (ORCPT ); Wed, 5 Jun 2019 02:16:37 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x556C6c4087517 for ; Wed, 5 Jun 2019 02:16:36 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sx7rqs5vc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 05 Jun 2019 02:16:35 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Jun 2019 07:16:33 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 5 Jun 2019 07:16:29 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x556GSU860358882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Jun 2019 06:16:28 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6B408A4057; Wed, 5 Jun 2019 06:16:28 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 194CFA405F; Wed, 5 Jun 2019 06:16:28 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 5 Jun 2019 06:16:28 +0000 (GMT) Received: from [10.61.2.125] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id DE255A01BD; Wed, 5 Jun 2019 16:16:26 +1000 (AEST) Subject: Re: [PATCH] ocxl: do not use C++ style comments in uapi header To: Masahiro Yamada , Frederic Barrat Cc: linuxppc-dev , Thomas Gleixner , Greg KH , Arnd Bergmann , Joe Perches , Randy Dunlap , Linux Kernel Mailing List References: <20190604111632.22479-1-yamada.masahiro@socionext.com> <90aa6d91-7592-17b0-17fd-e33676bd0a46@linux.ibm.com> From: Andrew Donnellan Date: Wed, 5 Jun 2019 16:16:23 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19060506-4275-0000-0000-0000033D5779 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19060506-4276-0000-0000-0000384D6887 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-05_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=778 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906050039 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/19 10:12 pm, Masahiro Yamada wrote: > On Tue, Jun 4, 2019 at 8:54 PM Frederic Barrat wrote: >> >> >> >> Le 04/06/2019 à 13:16, Masahiro Yamada a écrit : >>> Linux kernel tolerates C++ style comments these days. Actually, the >>> SPDX License tags for .c files start with //. >>> >>> On the other hand, uapi headers are written in more strict C, where >>> the C++ comment style is forbidden. >>> >>> Signed-off-by: Masahiro Yamada >>> --- >> >> Thanks! >> Acked-by: Frederic Barrat >> > > Please hold on this patch until > we get consensus about the C++ comment style. > > Discussion just started here: > https://lore.kernel.org/patchwork/patch/1083801/ If you choose to proceed with this patch: Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited