From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Atharv Dubey <atharvd440@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>, <qat-linux@intel.com>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Crypto : qat: Replace scnprintf with sysfs_emit function
Date: Fri, 20 Mar 2026 21:10:51 +0000 [thread overview]
Message-ID: <ab232/oVbFU/+7Pd@gcabiddu-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <20260320-sysfs-v1-1-91fd5ef42dea@gmail.com>
Thanks.
Can you re-submit with the headline below?
crypto: qat - replace scnprintf() with sysfs_emit()
On Fri, Mar 20, 2026 at 11:49:28PM +0530, Atharv Dubey wrote:
> Replace 3 sysfs functions in the Intel Qat Driver
> to use sysfs_emit() instead of scnprintf.
nit. scnprintf().
>
> - erros_correctable_show(): Replace scnprint() with sysfs_emit()
> - errors_nonfatal_show(): Replace scnprint() with sysfs_emit()
> - errors_fatal_show(): Replace scnprint() with sysfs_emit()
>
> This change is in accordance with Documentation/filesystems/sysfs.rst,
> which recommends using sysfs_emit/sysfs_emit_at in all sysfs show()
> callbacks for buffer safety, clarity, and consistency.
>
> Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
> ---
> drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Apart from the commit message, it looks fine.
Thanks,
--
Giovanni
next prev parent reply other threads:[~2026-03-20 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 18:19 Atharv Dubey
2026-03-20 21:10 ` Giovanni Cabiddu [this message]
2026-03-21 4:44 ` Atharv Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab232/oVbFU/+7Pd@gcabiddu-mobl.ger.corp.intel.com \
--to=giovanni.cabiddu@intel.com \
--cc=atharvd440@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®