From: Nikhil Gautam <nikhilgtr@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org
Subject: Re: [PATCH 1/1] iio: atlas-ezo: Fix humidity channel read support
Date: Tue, 13 Oct 2026 22:15:23 +0530 [thread overview]
Message-ID: <ab328578-08a6-455d-a9bf-411aeb561c8c@gmail.com> (raw)
In-Reply-To: <as1G0yGQ5wKhd-dh@ashevche-desk.local>
Hi Joshua, Andy,
Thanks for the review and feedback.
I checked the Git history and found that the channel type check was
already present
in commit dc3ebfc ("iio: chemical: atlas-ezo-sensor: add humidity sensor
support").
It was not removed when humidity sensor support was introduced, and
I couldn't find any commit message explaining the original intent of the
check.
Regarding the potential I2C read issue reported by Sashiko,
I'll investigate it and address it in a separate patch series.
I'll also omit the cover letter for future single-patch submissions.
Thanks,
Nikhil
On 13-10-2026 02:15 am, Andy Shevchenko wrote:
> On Mon, Oct 12, 2026 at 05:15:53PM +0530, Nikhil Gautam wrote:
>> The atlas_ezo_read_raw() function rejects channels that are not of
>> type IIO_CONCENTRATION, preventing the relative humidity channel
>> from reading raw and scale values.
>>
>> Remove the early channel type check to allow both concentration
>> and relative humidity channels to reach the mask-specific handling.
> Have you checked the Git history on this change? Anything interesting there?
>
next prev parent reply other threads:[~2026-10-13 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 11:45 [PATCH 0/1] " Nikhil Gautam
2026-10-12 11:45 ` [PATCH 1/1] " Nikhil Gautam
2026-10-12 13:56 ` Joshua Crofts
2026-10-12 20:45 ` Andy Shevchenko
2026-10-13 16:45 ` Nikhil Gautam [this message]
2026-10-12 13:57 ` [PATCH 0/1] " Joshua Crofts
2026-10-12 20:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab328578-08a6-455d-a9bf-411aeb561c8c@gmail.com \
--to=nikhilgtr@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®