From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A882C1E2016; Wed, 30 Oct 2024 09:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730282072; cv=none; b=Xfr1okE5uC9wVxpfrUeaeOkbAxTX8fVZFoxIo3KqqZayKnwEeiJGSgKL0jKThHDlx3Dacn2wz0J+D8eiLP/0tzBC09xQDdgv7iPZAt/RCikH5AtrKtR8MBAMPfaiXQ831jTtnEgsBERFdtxM9EPTFfN38o8GlpuKoy8TGb49+Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730282072; c=relaxed/simple; bh=Flqqcm/cz8s1x0wdzu31nHt4ZmJzcO34SY4lU9SNcT0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fX5OZ/A0q4UHXtGDRo7HLCY1RrATX+q8376LPUcULzRgQXcS7H3RUm2FgZaSAaluYppeHgGJcfyhe+UWR1nBDGG3Gurg9+IlDM5kVpSmK51IiVPDyMTB2wLTlK/K0yr8Lmd8rEyliwch+NvQ3Y9gIoyXefPqAVzKCDyxF5sbg64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F6DD113E; Wed, 30 Oct 2024 02:54:57 -0700 (PDT) Received: from [10.57.58.72] (unknown [10.57.58.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D2FBD3F73B; Wed, 30 Oct 2024 02:54:24 -0700 (PDT) Message-ID: Date: Wed, 30 Oct 2024 09:55:38 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 1/1] cpufreq: scmi: Register for limit change notifications To: Cristian Marussi , Sibi Sankar Cc: sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, pierre.gondois@arm.com, vincent.guittot@linaro.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com, linux-arm-msm@vger.kernel.org References: <20240603192654.2167620-1-quic_sibis@quicinc.com> <20240603192654.2167620-2-quic_sibis@quicinc.com> Content-Language: en-US From: Lukasz Luba In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/30/24 09:32, Cristian Marussi wrote: > On Tue, Jun 04, 2024 at 12:56:54AM +0530, Sibi Sankar wrote: >> Register for limit change notifications if supported and use the throttled >> frequency from the notification to apply HW pressure. >> > > This sort of got lost in mbox...apologies. > > As discussed offlist, the issue with cpufreq and multiple SCMI instances > remains BUT it will be solved later on with a different approach, so > as of now this LGTM. > > Reviewed-by: Cristian Marussi Thank you Cristian for re-visiting this. That code also LGTM and fits into my other construction built on top of it [1] [2]. I had a talk with Rafael below that [1] about this subject patch. Feel free to add: Reviewed-by: Lukasz Luba [1] https://lore.kernel.org/lkml/20241029094452.495439-1-lukasz.luba@arm.com/ [2] https://lore.kernel.org/lkml/20240403162315.1458337-1-lukasz.luba@arm.com/