From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD5FC282E1 for ; Sat, 25 May 2019 03:21:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC0652175B for ; Sat, 25 May 2019 03:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbfEYDVv (ORCPT ); Fri, 24 May 2019 23:21:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57716 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbfEYDVu (ORCPT ); Fri, 24 May 2019 23:21:50 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 015C8308424C; Sat, 25 May 2019 03:21:50 +0000 (UTC) Received: from Hades.local (dhcp-17-185.bos.redhat.com [10.18.17.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4D13503EF; Sat, 25 May 2019 03:21:48 +0000 (UTC) Subject: Re: [PATCH net] bonding/802.3ad: fix slave link initialization transition states To: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS1?= =?UTF-8?B?4KS+4KSwKQ==?= , Jay Vosburgh Cc: linux-kernel@vger.kernel.org, Veaceslav Falico , Andy Gospodarek , "David S. Miller" , linux-netdev , Heesoon Kim References: <20190524134928.16834-1-jarod@redhat.com> <30882.1558732616@famine> From: Jarod Wilson Message-ID: Date: Fri, 24 May 2019 23:21:47 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Sat, 25 May 2019 03:21:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/19 6:38 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Fri, May 24, 2019 at 2:17 PM Jay Vosburgh wrote: >> >> Jarod Wilson wrote: >> >>> Once in a while, with just the right timing, 802.3ad slaves will fail to >>> properly initialize, winding up in a weird state, with a partner system >>> mac address of 00:00:00:00:00:00. This started happening after a fix to >>> properly track link_failure_count tracking, where an 802.3ad slave that >>> reported itself as link up in the miimon code, but wasn't able to get a >>> valid speed/duplex, started getting set to BOND_LINK_FAIL instead of >>> BOND_LINK_DOWN. That was the proper thing to do for the general "my link >>> went down" case, but has created a link initialization race that can put >>> the interface in this odd state. >> > Are there any notification consequences because of this change? No, there shouldn't be, it just makes initial link-up cleaner, everything during runtime once the link is initialized should remain the same. -- Jarod Wilson jarod@redhat.com