From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECAF83876A4 for ; Thu, 17 Sep 2026 06:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789624804; cv=none; b=EVYKmHiZN9yg6Ky5tRG9qTZLm94d2VYfHeM1wuS2L4WfHIBb+/5Wiif0Q2sLpXwTPgwQQr+OCVYLaHiMjf4M6jh/fAdVSMNsQWHlePksuFHdWrbrw2zHv/JUa1lZDMW8N3mTa/eR4wrKelsjzlRtUXaHIH/vCrR0Ji3j2rA40Zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789624804; c=relaxed/simple; bh=uQxXDjAMftTafTiqVXFFt+5SqDu0vaDRqbtTXavF2ts=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=l3swCHdAJxGVvjGfZPsrJFo2JxK14Y9ulQbPdaBpYq5Rm6fl0Ygwq8AbKJbyMotZG0vVlK3sjP+ZHxVgBQgOXbTrpehrJgKImKdKDjMe2uAX/5c2MDo6acyNhnuj3/JtkWvjAYGoP8UPZOR1Bki3j+LaZmFvVtUais+454stqN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=HXWR4qpy; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=eZ4T4XrA; arc=none smtp.client-ip=103.168.172.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="HXWR4qpy"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="eZ4T4XrA" Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfout.phl.internal (Postfix) with ESMTP id E5B96EC0174; Thu, 17 Sep 2026 02:00:00 -0400 (EDT) Received: from ams-imap-03 ([10.64.2.23]) by ams-compute-02.internal (MEProxy); Thu, 17 Sep 2026 02:00:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1789624800; x=1789711200; bh=hpYOpcv/DfS/Pb4Hs6wOC5rsHRD7H9hoSeQow9V/WII=; b= HXWR4qpy1hhU0ysj+5+skgxT+PHWnzdNM/AliO/+nC1j1rqi+ouVYtkwi3GJuQVn psrfPgMnGp3/d9/5yLK3sJq/iLcd1Y7ADopubVGNMxi9kuHmDOx7zb24YuTrs25S QrzmYojcgci1rPSGcEyYtwgNf1QvIijJ96dXUA/lA6d/0dKHPWrzB5CWd21CK+H9 RRZEpgw9TD+g4Y5sjDoI2fWE0C6zkJUsNvY2NHIbrfc3goNJNTOk26jnrO8e4uNC Mf37O3hjC4z6vKbSPZhzMjrAef6afDMhk2WydNEEoYQqV0qAWWx6/sgVy1hnVOEv o9VecjX2Iv4nImkxwixxpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1789624800; x= 1789711200; bh=hpYOpcv/DfS/Pb4Hs6wOC5rsHRD7H9hoSeQow9V/WII=; b=e Z4T4XrAJc7P6lECDiyn55gaUXcoCZsUBZvdXxzyhe1i0r8mxtKJWixmLzGwlo2pt 4I/aGH3INzs5teF4B3Ebg5UbinLT0Gnn7krVK91kO7RRJPCG1reMgqrNzLk60xUw KAe/J7RcC7a3mceQPAzjSPtlHgzIw7+2Rsb6UbGUfm31QwtkMbJDMct1xwqRdRa8 RGIsy/csrPVOzRMYM9wCwZVewKC3vtV/f7RIWASvi5r4umpKBtMAgcFZrfCaDfxu h+cqL4159Ok+KAVRDcq7WAqWZGaEC1VpMUjKorXMoonszbwBqwVPWRqwOAWp0dSL ZunJ7gSsoX06tghWJ6wZg== X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFpVz0820YlZmLNkO+O0IGQnLOxVxkCbLx01MDLZkNaa0IdAtdZ0T/xMbjA/ru7ry wUcpkRNCigJIN67W79Hh0J4UA9oZLRs8QbBKE8RGGDrjEF/MqQhtRS4MPKynowQUUrCeMN HCo9Z4focITIriBC/AvzkWZhni4fOTdKhS8VewXYGIH+LPi9qfe4u3ahTBDqyyOj91I+qC xBlMezsyqRVso5Wyww0vt7+vUmApVtSx6bNXtBlvipTnqu8p56A5h11RqbJvxTjXN+GUWE ZfrAvbEHk1m26BuTBbcD+WqPiXsRrz2FpIIvqMYnvgBPAm3TG7viJ+sJpvweH/+83eOCGN DixyRWARpYcescPWHsfrEwWsDwvKWAyUCYukZvFSZXXAvIa5tIuQ+Tgn+HT5Dl5lbBV1h/ LfQnggZvM8iimbztFxrdo6EdhpVHutYUMtv+Dp1kazq07ClBlDqVT44wkpioGBZSIerXQC UPLu3CNJhoSHmm8aRtSppmXKEhwzc5sQvz3XaAJXtz/RRUeyOAl6Tv8ZpcoB+e9DdmM3hc ssO/8CpYUM62EvehjGxAGHbQJ0MV+p1VgMv0QmXMVQHzwVvACOJip3bF6FjelTcqFm+zlG Q42DQ+oqGZfAPkktGVHelkr1Gjt2/bN7YAg+6XF3DSUqxHgiF+WE9ol8NOzQ X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 7804E32A0084; Thu, 17 Sep 2026 01:59:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AfnFG7kA3Ny- Date: Thu, 17 Sep 2026 07:59:34 +0200 From: "Arnd Bergmann" To: "Nilay Shroff" , "Arnd Bergmann" , "Keith Busch" , "Jens Axboe" , "Christoph Hellwig" , "Sagi Grimberg" , "Maurizio Lombardi" Cc: "Hannes Reinecke" , "John Garry" , "Martin K. Petersen" , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <1b36e312-222b-4052-8a8c-0583c908ea19@linux.ibm.com> References: <20260916114533.237863-1-arnd@kernel.org> <1b36e312-222b-4052-8a8c-0583c908ea19@linux.ibm.com> Subject: Re: [PATCH] nvme: work around -Wformat-security warning Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 17, 2026, at 06:14, Nilay Shroff wrote: > On 9/16/26 5:14 PM, Arnd Bergmann wrote: > > The changes look good. However, I applied the patch and built > drivers/nvme/ with -Wformat-security, and I still see a couple of > additional warnings: > > $ make M=3Ddrivers/nvme/ KCFLAGS=3D"-Wformat-security" > make[1]: Entering directory=20 > '/home/nilay/Development/linux-x86/drivers/nvme' > [...] > host/sysfs.c: In function =E2=80=98cntrltype_show=E2=80=99: > host/sysfs.c:682:9: error: format not a string literal and no format=20 > arguments [-Werror=3Dformat-security] > 682 | return sysfs_emit(buf, type[ctrl->cntrltype]); > | ^~~~~~ > host/sysfs.c: In function =E2=80=98dctype_show=E2=80=99: > host/sysfs.c:699:9: error: format not a string literal and no format=20 > arguments [-Werror=3Dformat-security] > 699 | return sysfs_emit(buf, type[ctrl->dctype]); > | ^~~~~~ > > I think that if we're fixing -Wformat-security warnings in the NVMe > driver, it would be useful to address above warnings as part of this > patch as well. Good point, I forgot to check for the patches I already had fixed in my randconfig branch and only addressed the new one here. I'll send a separate patch to fix the two instance above. Arnd