From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754449AbdCIJ3u (ORCPT ); Thu, 9 Mar 2017 04:29:50 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34155 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbdCIJZw (ORCPT ); Thu, 9 Mar 2017 04:25:52 -0500 Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem To: Sekhar Nori , Bartlomiej Zolnierkiewicz References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <8ea5971a-338d-e8b9-6be8-8fe2658fc04d@ti.com> <1709119.SQyio4Ct6n@amdc3058> <1fd840c5-b0bb-726b-6357-669977c4ae5f@ti.com> Cc: Kevin Hilman , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Russell King , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson From: Sergei Shtylyov Message-ID: Date: Thu, 9 Mar 2017 12:25:47 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 3/9/2017 11:39 AM, Sekhar Nori wrote: >>> It took a while to get to it but here is the draft driver patch >>> against v4.11-rc1. Please test. >> >> I tested this on DM6446 EVM. I was able to mount existing partitions on >> the hard disk and see that the directory listing looks good[1]. I will do >> more tests (including comparing performance with old driver) tomorrow. I > > I completed the tests I wanted to, including some read/write/data > integrity tests. Performance is same as before too. > > Tested-by: Sekhar Nori > > Here are the additional changes I did. These changes do not clash with > what I have already queued for v4.12. That said, its probably better if > I carry the platform pieces through my tree. Let me know how you want > to proceed. > > Thanks, > Sekhar > > ---8<--- > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig > index b9a7cb98ffda..67db82999c06 100644 > --- a/arch/arm/configs/davinci_all_defconfig > +++ b/arch/arm/configs/davinci_all_defconfig [...] > diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c > index 023480b75244..60a1f23890cd 100644 > --- a/arch/arm/mach-davinci/board-dm644x-evm.c > +++ b/arch/arm/mach-davinci/board-dm644x-evm.c > @@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device *phydev) > return 0; > } > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) I think it would be more correct to check for both libata and IDE drivers here... > #define HAS_NOR IS_ENABLED(CONFIG_MTD_PHYSMAP) > > diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c > index f702d4fc8eb8..589f3c33c4a0 100644 > --- a/arch/arm/mach-davinci/board-dm646x-evm.c > +++ b/arch/arm/mach-davinci/board-dm646x-evm.c > @@ -119,7 +119,7 @@ static struct platform_device davinci_nand_device = { > }, > }; > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) And here... > > #ifdef CONFIG_I2C > /* CPLD Register 0 bits to control ATA */ > diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c > index 0a7838852649..075e304ce7be 100644 > --- a/arch/arm/mach-davinci/board-neuros-osd2.c > +++ b/arch/arm/mach-davinci/board-neuros-osd2.c > @@ -163,7 +163,7 @@ static struct davinci_mmc_config davinci_ntosd2_mmc_config = { > .wires = 4, > }; > > -#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > +#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) And here... [...] MBR, Sergei